<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-2022-jp">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Intel Clear Light";
panose-1:2 11 4 4 2 2 3 2 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:ZH-CN;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Intel Clear Light",sans-serif;
color:#1F497D;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Hi Cheng,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Thank you for submitting a patch. The OFA NVMeWin community always welcomes and encourages contributions.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Kindly please refer to the patch submission process defined by OFA NVMeWin. The details of the patch submission process have
been published on this distribution list. Here is a link to the OFA website (where there are links provided for archived list distributions).
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">For reference, below is the patch submission process (also attached). All of the tools required for unit testing are open
and available online. If you need assistance in obtaining any of the tools, please let me know.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">This is a reminder of the procedure to submit patch:<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Process:
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Submitter needs to base their changes on the latest (and re-base/re-test prior to sending their patch).
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- They send the patch to the email list "<a href="mailto:nvmewin@lists.openfabrics.org"><span style="color:blue">nvmewin@lists.openfabrics.org</span></a>".<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Some review will happen over the reflector, the maintainer will send a message out that the db is locked
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> when they’re ready to apply the patch which will be once at least one member from each company
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> on the review panel has approved (can be via email or con call if needed). Once the patch is applied,
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> the maintainer will send an email out.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Patch contents:
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Code changes, short summary for SVN log, more verbose write up for release notes, confirmation of what Windows platforms had been tested.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Patch must follow the coding guidelines as attached.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- All source files should be zipped up into a .zip file with password enabled. The zip file name should properly describe the main changes of
the patch.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Reviews:<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Patches submitted by anyone, email to distribution list "<a href="mailto:nvmewin@lists.openfabrics.org"><span style="color:blue">nvmewin@lists.openfabrics.org</span></a>".<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Patch submission should include time sensitivity/expectations.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Patch submission should include justification for the patch (what value will it add, and are
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> tradeoffs what are they and why would we want to take a hit). If multiple implementation
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> options were considered, what data/reasoning was behind the implementation choice.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- At a minimum reviews need to be completed by Intel, PMC, HGST, and Samsung representatives.<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- Reviews include compliance with coding guidelines (in SVN) as well as logic<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Unit Testing:
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US">- All patches and release candidates required, at a minimum, the following;<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - 1 hour of data integrity testing using sdstress (Microsoft Tool)<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - 1 hour of heavy stress testing using IOMETER covering, at least, 512B, 4KB and 128KB ranging
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> from 1 OIO to 64 OIO both sequential and random<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - Quick and slow format of both MBR and GPT partitioning<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - Microsoft SCSI Compliance, no failures except (warnings OK)<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - Additional testing with other tools is encouraged<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - Occurs in all supported OSs for the release
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - 64-bit, Windows 7, 8.0, 8,1, server 2008R2 and 2012<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - 32-bit, Windows 7, 8.0<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> - Minimum test platform is latest QEMU. Those with their HW should test on it as well.
<o:p></o:p></span></p>
<p class="MsoNormal" align="left" style="text-align:left"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> QEMU is available at
<a href="https://github.com/nvmeqemu/nvmeqemu"><span style="color:blue">https://github.com/nvmeqemu/nvmeqemu</span></a>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Ray Robles<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear Light",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" align="left" style="text-align:left"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Cheng Peng<br>
<b>Sent:</b> Monday, July 06, 2015 4:58 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org<br>
<b>Subject:</b> [nvmewin] issue a patch<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal" align="left" style="text-align:left"><o:p> </o:p></p>
<p class="MsoNormal">Would you merge the patch into SVN trunk<span lang="ZH-CN" style="font-family:SimSun">？</span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thank you.<o:p></o:p></p>
</div>
</body>
</html>