<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hi Ray</p>
<p><br>
</p>
<p>Other colleagues take over my jobs, I have forwarded the email to them.<br>
</p>
<p><br>
</p>
<p>Thanks</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>发件人:</b> Robles, Raymond C <raymond.c.robles@intel.com><br>
<b>发送时间:</b> 2015年8月7日 3:34<br>
<b>收件人:</b> nvmewin@lists.openfabrics.org; Cheng Peng<br>
<b>主题:</b> RE: patch submission</font>
<div> </div>
</div>
<div>
<div style="">
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D; background:yellow">Hi Cheng,</span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"></span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">I have not seen a response from you on my question below. In order for your patch to be accepted, you must respond to any and all questions/comments from the reviewing
companies… as well as from the reflector list. If you do not respond within a timely fashion, your patch will not be considered for integration to the OFA driver. Please respond at your earliest convenience.</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D; background:yellow">Reviewing Companies,</span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"></span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Any feedback, questions, or test results on the patch submission below? The deadline for review is August 12<sup>th</sup>. Thanks!</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Thanks,</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Ray Robles</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Friday, July 31, 2015 11:37 AM<br>
<b>To:</b> nvmewin@lists.openfabrics.org; Cheng Peng<br>
<b>Subject:</b> Re: [nvmewin] patch submission</span></p>
</div>
</div>
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
</p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Hi Cheng,</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">I’ve reviewed your code and have some questions.
</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">It looks like NVMeWaitForCtrlRDY is added in init and reset path. Previously controller ready wait is performed in passive init path. I did not see any benefit of adding
NVMeWaitForCtrlRDY in init path (I feel, old passive init path wait will be right approach to have minimal processor usage).</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Could you please provide an explanation on why you moved wait for controller ready to init path?</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Thanks,</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Ray</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">
nvmewin-bounces@lists.openfabrics.org</a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">mailto:nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Thursday, July 30, 2015 3:24 PM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">
nvmewin@lists.openfabrics.org</a>; Cheng Peng<br>
<b>Subject:</b> Re: [nvmewin] patch submission</span></p>
</div>
</div>
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
</p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D; background:yellow">Reviewing Companies,</span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">
</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Please provide any review comments and testing results before August 12<sup>th</sup>. We also have a patch from ULINK Technology after this patch.</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D; background:yellow">In the meantime,
<b>Cheng could you please provide the following information about your patch</b>:</span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"></span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="text-indent: -0.25in; margin: 0in 0in 0.0001pt 0.5in; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"><span style="">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Reason fix was needed.
</span></p>
<p style="text-indent: -0.25in; margin: 0in 0in 0.0001pt 0.5in; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"><span style="">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Files modified and what was modified in each file.</span></p>
<p style="text-indent: -0.25in; margin: 0in 0in 0.0001pt 0.5in; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"><span style="">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">How you unit tested your fix.</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Thanks,</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D">Ray</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="font-size:10.0pt; font-family:"Intel Clear Light",sans-serif; color:#1F497D"> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">
nvmewin-bounces@lists.openfabrics.org</a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">mailto:nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Cheng Peng<br>
<b>Sent:</b> Monday, July 06, 2015 10:32 PM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org" style="color: rgb(5, 99, 193); text-decoration: underline;">
nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> [nvmewin] patch submission</span></p>
</div>
</div>
<p align="left" style="text-align: justify; margin: 0in 0in 0.0001pt; font-size: 10.5pt; font-family: Calibri, sans-serif;">
</p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="">fix: Wait for device ready when enable adapter</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style=""> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="">It had been tested on Windows 2008 R2\Windows 2012 x64 platform</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style=""> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="">Please review it, and if you think it OK, please merge it to SVN trunk, thank you</span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style=""> </span></p>
<p style="margin: 0in 0in 0.0001pt; text-align: justify; font-size: 10.5pt; font-family: Calibri, sans-serif;">
<span style="">Btw, the password of ZIP is ofa_nvme</span></p>
</div>
</div>
</div>
</div>
</body>
</html>