<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Microsoft YaHei";
panose-1:2 11 5 3 2 2 4 2 2 4;}
@font-face
{font-family:"\@Microsoft YaHei";
panose-1:2 11 5 3 2 2 4 2 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@MS Gothic";
panose-1:2 11 6 9 7 2 5 8 2 4;}
@font-face
{font-family:"Intel Clear";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:SimSun;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:SimSun;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:SimSun;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Intel Clear";
color:#44546A;
font-weight:normal;
font-style:normal;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1216821457;
mso-list-type:hybrid;
mso-list-template-ids:1361187976 -1572800282 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-start-at:6;
mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Intel Clear";
mso-fareast-font-family:SimSun;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Yizhong,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thank you for the information. I’ve also been waiting for the explanation on why this is necessary.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">As Ray said, it seems like this only addresses a problem with your non-standard setup.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">So, unless there is evidence that this fixes a general problem, HGST declines to accept this fix.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="line-height:90%"><b><span style="font-size:10.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">Tom Freeman</span></b><b><span style="font-family:"Arial",sans-serif;color:#1F497D"><o:p></o:p></span></b></p>
<p class="MsoNormal" style="line-height:90%"><b><span style="font-size:10.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">Software Engineer, Device Manager and Driver Development</span></b><span style="font-family:"Times New Roman",serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:90%"><span style="font-size:10.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">HGST, a Western Digital company</span><span style="font-family:"Times New Roman",serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:90%"><span style="font-size:10.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D"><a href="mailto:thomas.freeman@hgst.com"><span style="color:#0563C1">thomas.freeman@hgst.com</span></a></span><span style="font-family:"Times New Roman",serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:90%"><span style="font-size:10.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">507-322-2311<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:90%"><span style="font-family:"Times New Roman",serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:90%"><span style="font-size:11.0pt;line-height:90%;font-family:"Calibri",sans-serif;color:#1F497D"><img border="0" width="172" height="56" id="Picture_x0020_1" src="cid:image001.png@01D0D5A7.B77D20B0" alt="HGST_Logo_email"><o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;line-height:90%">
<span style="font-size:8.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">3605 Hwy 52 N
</span><span style="font-family:"Times New Roman",serif;color:#1F497D"><br>
</span><span style="font-size:8.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#1F497D">Rochester, MN 55901</span><span style="font-family:"Times New Roman",serif;color:#1F497D"><br>
<a href="https://hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/" target="_blank"><span style="font-size:8.0pt;line-height:90%;font-family:"Arial",sans-serif;color:#0563C1">www.hgst.com</span></a><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> nvmewin-bounces@lists.openfabrics.org [mailto:nvmewin-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Wednesday, August 12, 2015 8:09 PM<br>
<b>To:</b> Yizhong Zhang <yizhong.zhang@memblaze.com>; Wenbo Wang <wenbo.wang@memblaze.com><br>
<b>Cc:</b> nvmewin <nvmewin@lists.openfabrics.org><br>
<b>Subject:</b> Re: [nvmewin] patch submission<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Thanks for the response.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">My biggest concern here is how this change will work on currently released NVMe products in the market (i.e. Intel, Samsung, etc.). Do you have a means of unit testing
with other NVMe devices?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">This fix seems very specific to your “proprietary” NVMe device. No other IHV for NVMe devices is using a similar power methodology. Based on this alone, I’m inclined
to not include it in the OFA baseline. However, please keep in mind that the OFA driver is a “reference” driver, and not a production driver (i.e. Linux NVMe driver).
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Therefore, your company can take this driver and modify it as you need and release under the FreeBSD license with your H/W. Many IHV vendors do this. In the end, this
patch does not “need” to be in the OFA baseline… as it only resolves an issue on your company’s NVMe controller.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">For now, I think the next steps are:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Get feedback from rest of OFA NVMeWin reviewing companies on such a fix<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Test your patch on other 3<sup>rd</sup> party NVMe drives<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A">Ray<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear";color:#44546A"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Yizhong Zhang [<a href="mailto:yizhong.zhang@memblaze.com">mailto:yizhong.zhang@memblaze.com</a>]
<br>
<b>Sent:</b> Monday, August 10, 2015 1:21 AM<br>
<b>To:</b> Wenbo Wang; Robles, Raymond C<br>
<b>Subject:</b> </span><span style="font-size:11.0pt;font-family:"MS Gothic"">答复</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">: patch submission<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Hi Ray,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks for your information and sorry for delayed response. My name is Yizhong and I will track this effort. I am a rookie in NVMe
Windows driver, so please correct me if there is anything wrong in my statement.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Cheng already left company so I can only talked with other guys for some internals. Here is the problem background: we have a special
NVMe test setup. We have a self-made NVMe card slot, which separates PCIe signals from power. In such way, the NVMe card gets power with a separated power module, instead of power from PCIe slot. We found a bug in such setup. If we unplug the power cable and
plug the power cable again, we observed Windows hang (no any response). So we add the patch later, and it proves the bug is fixed.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">I looked into code and found the passive wait in NVMe reset path (</span><span style="font-size:9.5pt;font-family:Consolas;color:black;background:white;mso-highlight:white;mso-fareast-language:ZH-CN">NVMeInitialize</span><span style="font-size:9.5pt;font-family:Consolas;color:black;mso-fareast-language:ZH-CN">
and <span style="background:white;mso-highlight:white">NVMeResetAdapter</span></span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">), but I didn’t see
</span><span style="font-size:9.5pt;font-family:Consolas;color:black;background:white;mso-highlight:white;mso-fareast-language:ZH-CN">NVMeWaitForCtrlRDY</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">
been called in </span><span style="font-size:9.5pt;font-family:Consolas;color:black;background:white;mso-highlight:white;mso-fareast-language:ZH-CN">NVMeEnableAdapter</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">.
So this fix make sense in my opinion. The side effect is driver may spends ~1s (estimated) to wait for controller ready after power recover.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">We only test the fix with the bug reproduce steps. There is no unit test here. As I mentioned above, it should be safe for all other
functionalities except extra delay during NVMe initialization stage.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Could you please let us know your further advice? Thanks in advance.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">-yz<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="ZH-CN" style="font-size:11.0pt;font-family:"Microsoft YaHei",sans-serif;mso-fareast-language:ZH-CN">发件人</span></b><b><span style="font-size:11.0pt;font-family:"Microsoft YaHei",sans-serif;mso-fareast-language:ZH-CN">:</span></b><span style="font-size:11.0pt;font-family:"Microsoft YaHei",sans-serif;mso-fareast-language:ZH-CN">
Wenbo Wang <br>
<b><span lang="ZH-CN">发送时间</span>:</b> Saturday, August 8, 2015 11:43 PM<br>
<b><span lang="ZH-CN">收件人</span>:</b> <a href="mailto:raymond.c.robles@intel.com">
raymond.c.robles@intel.com</a><br>
<b><span lang="ZH-CN">抄送</span>:</b> Yizhong Zhang<br>
<b><span lang="ZH-CN">主题</span>:</b> FW: patch submission<br>
<b><span lang="ZH-CN">重要性</span>:</b> <span lang="ZH-CN">高</span><o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span style="mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Hi Ray,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks for your email.
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Due to some changes, Cheng will not work on this OFA driver any more. I and Yizhong will
be doing that. <o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">We need to take some time to understand all the history and after that we will response
ASAP. Sorry for the inconvenience.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">-Wenbo<o:p></o:p></span></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center;background:white">
<span style="font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<hr size="2" width="98%" align="center">
</span></div>
<div id="divRplyFwdMsg">
<p class="MsoNormal" style="background:white"><b><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">发件人</span></b><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com">raymond.c.robles@intel.com</a>><br>
</span><b><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">发送时间</span></b><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
2015</span><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">年</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">8</span><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">月</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">7</span><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">日</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
3:34<br>
</span><b><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">收件人</span></b><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>; Cheng Peng<br>
</span><b><span lang="ZH-CN" style="font-size:11.0pt;color:black;mso-fareast-language:ZH-CN">主题</span></b><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
RE: patch submission</span><span style="font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="background:white"><span style="font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;background:yellow;mso-fareast-language:ZH-CN">Hi Cheng,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">I have not seen a response from you on my question below. In order for your patch to be accepted, you must
respond to any and all questions/comments from the reviewing companies… as well as from the reflector list. If you do not respond within a timely fashion, your patch will not be considered for integration to the OFA driver. Please respond at your earliest
convenience.</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;background:yellow;mso-fareast-language:ZH-CN">Reviewing Companies,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Any feedback, questions, or test results on the patch submission below? The deadline for review is August 12<sup>th</sup>.
Thanks!</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Ray Robles</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p style="text-align:justify;background:white"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org">nvmewin-bounces@lists.openfabrics.org</a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org">mailto:nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Friday, July 31, 2015 11:37 AM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a>; Cheng Peng<br>
<b>Subject:</b> Re: [nvmewin] patch submission</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
</div>
</div>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Hi Cheng,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">I’ve reviewed your code and have some questions.
</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">It looks like NVMeWaitForCtrlRDY is added in init and reset path. Previously controller ready wait is performed
in passive init path. I did not see any benefit of adding NVMeWaitForCtrlRDY in init path (I feel, old passive init path wait will be right approach to have minimal processor usage).</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Could you please provide an explanation on why you moved wait for controller ready to init path?</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Ray</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p style="text-align:justify;background:white"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org"><span style="color:#0563C1">nvmewin-bounces@lists.openfabrics.org</span></a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org"><span style="color:#0563C1">mailto:nvmewin-bounces@lists.openfabrics.org</span></a>]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Thursday, July 30, 2015 3:24 PM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org"><span style="color:#0563C1">nvmewin@lists.openfabrics.org</span></a>; Cheng Peng<br>
<b>Subject:</b> Re: [nvmewin] patch submission</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
</div>
</div>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;background:yellow;mso-fareast-language:ZH-CN">Reviewing Companies,</span><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">
</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Please provide any review comments and testing results before August 12<sup>th</sup>. We also have a patch
from ULINK Technology after this patch.</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;background:yellow;mso-fareast-language:ZH-CN">In the meantime,
<b>Cheng could you please provide the following information about your patch</b>:</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="margin-left:.5in;text-align:justify;text-indent:-.25in;background:white">
<span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">-</span><span style="font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D;mso-fareast-language:ZH-CN">
</span><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Reason fix was needed.
</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="margin-left:.5in;text-align:justify;text-indent:-.25in;background:white">
<span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">-</span><span style="font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D;mso-fareast-language:ZH-CN">
</span><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Files modified and what was modified in each file.</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="margin-left:.5in;text-align:justify;text-indent:-.25in;background:white">
<span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">-</span><span style="font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D;mso-fareast-language:ZH-CN">
</span><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">How you unit tested your fix.</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Ray</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"> </span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p style="text-align:justify;background:white"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">
<a href="mailto:nvmewin-bounces@lists.openfabrics.org"><span style="color:#0563C1">nvmewin-bounces@lists.openfabrics.org</span></a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org"><span style="color:#0563C1">mailto:nvmewin-bounces@lists.openfabrics.org</span></a>]
<b>On Behalf Of </b>Cheng Peng<br>
<b>Sent:</b> Monday, July 06, 2015 10:32 PM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org"><span style="color:#0563C1">nvmewin@lists.openfabrics.org</span></a><br>
<b>Subject:</b> [nvmewin] patch submission</span><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"><o:p></o:p></span></p>
</div>
</div>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">fix: Wait for device ready when enable adapter<o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">It had been tested on Windows 2008 R2\Windows 2012 x64 platform<o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">Please review it, and if you think it OK, please merge it to SVN trunk, thank you<o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN"> <o:p></o:p></span></p>
<p style="text-align:justify;background:white"><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:black;mso-fareast-language:ZH-CN">Btw, the password of ZIP is ofa_nvme<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial",sans-serif"><strong>HGST E-mail
Confidentiality Notice & Disclaimer:</strong><br>This e-mail and any files transmitted with it may contain confidential
or legally privileged information of HGST and are intended solely for the use
of the individual or entity to which they are addressed. If you are not the
intended recipient, any disclosure, copying, distribution or any action taken
or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error,
please notify the sender immediately and delete the e-mail in its entirety from
your system.<o:p></o:p></span></p></body>
</html>