<div dir="ltr">Attached a patch file.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 29, 2015 at 12:24 AM, Robles, Raymond C <span dir="ltr"><<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<u></u><u></u>
<div lang="EN-US" link="#0563C1" vlink="#954F72" style="margin-left:7.5pt;margin-top:7.5pt;margin-right:7.5pt;margin-bottom:7.5pt">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">Hi Iuliu,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">As I was getting ready to merge your patch, I did a diff of your patch with the current OFA trunk and noticed that you don’t have the latest updates from
the OFA trunk within your patch.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">I did not want to do a manual merge of your patch on top of the current source in case there was any overlap. Could you please rebase your patch with the
latest OFA trunk? Thanks!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">This also brings up another point that you had previously raised to me… patch submission. I spoke with Ken Strandberg (OFA admin) and he reminded me that
all SVN clients have a “create patch” and “apply patch” option. So, if you don’t mind, once you are done with rebasing your code with the latest trunk, could you please create a patch using the SVN tools? I use TortoiseSVN and it’s pretty straightforward.
You just need to copy your files over your working copy of the trunk and select “create branch”. You should then just be able to send me the patch.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">Thanks for being the guinea pig for this, but I think it makes sense to use a patch tool as you recommended. Let me know if you have any questions.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#002060">Ray<a name="15017fd3f77691ef__MailEndCompose"><u></u><u></u></a></span></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin:0in;margin-bottom:.0001pt"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Monday, September 28, 2015 4:16 PM<br>
<b>To:</b> <a href="mailto:suman.p@samsung.com" target="_blank">suman.p@samsung.com</a>; <a href="mailto:nvmewin-request@lists.openfabrics.org" target="_blank">nvmewin-request@lists.openfabrics.org</a>; <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a></span></p><div><div class="h5"><br>
<b>Subject:</b> Re: [nvmewin] FW: NVME fuzz test fixes<u></u><u></u></div></div><p></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Thanks Suman! I’ll push the patch today and it should be ready by tomorrow.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Intel is up next with the Namespace Management patch. However, we are not fully done with unit testing. Suman, is Samsung ready to push any of its patches
next?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Ray<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"><u></u> <u></u></span></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin:0in;margin-bottom:.0001pt"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> SUMAN PRAKASH B [<a href="mailto:suman.p@samsung.com" target="_blank">mailto:suman.p@samsung.com</a>]
<br>
<b>Sent:</b> Wednesday, September 23, 2015 4:49 AM<br>
<b>To:</b> <a href="mailto:nvmewin-request@lists.openfabrics.org" target="_blank">nvmewin-request@lists.openfabrics.org</a>;
<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>; Robles, Raymond C<br>
<b>Subject:</b> Re: FW: NVME fuzz test fixes<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p> <u></u><u></u></p>
<p>SAMSUNG approves the patch.<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>Thanks,<u></u><u></u></p>
<p>Suman<br>
<br>
------- Original Message -------<br>
Sender : <a href="mailto:nvmewin-request@lists.openfabrics.org%3cnvmewin-request@lists.openfabrics.org" target="_blank">
nvmewin-request@lists.openfabrics.org<nvmewin-request@lists.openfabrics.org</a>> <br>
Date : Sep 23, 2015 06:10 (GMT+05:30)<br>
Title : nvmewin Digest, Vol 45, Issue 21<br>
<br>
Send nvmewin mailing list submissions to<br>
<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.openfabrics.org/mailman/listinfo/nvmewin" target="_blank">http://lists.openfabrics.org/mailman/listinfo/nvmewin</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:nvmewin-request@lists.openfabrics.org" target="_blank">nvmewin-request@lists.openfabrics.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:nvmewin-owner@lists.openfabrics.org" target="_blank">nvmewin-owner@lists.openfabrics.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of nvmewin digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: FW: NVME fuzz test fixes (Robles, Raymond C)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Wed, 23 Sep 2015 00:40:46 +0000<br>
From: "Robles, Raymond C" <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>><br>
To: Alex Chang <<a href="mailto:Alex.Chang@pmcs.com" target="_blank">Alex.Chang@pmcs.com</a>>, Thomas Freeman<br>
<<a href="mailto:thomas.freeman@hgst.com" target="_blank">thomas.freeman@hgst.com</a>>, Iuliu Rus <<a href="mailto:iuliur@google.com" target="_blank">iuliur@google.com</a>><br>
Cc: "<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>" <<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>><br>
Subject: Re: [nvmewin] FW: NVME fuzz test fixes<br>
Message-ID:<br>
<<a href="mailto:49158E750348AA499168FD41D88983606B769A4B@fmsmsx117.amr.corp.intel.com" target="_blank">49158E750348AA499168FD41D88983606B769A4B@fmsmsx117.amr.corp.intel.com</a>><br>
<br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Thanks Alex!<br>
<br>
From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">mailto:nvmewin-bounces@lists.openfabrics.org</a>] On Behalf Of Alex Chang<br>
Sent: Tuesday, September 22, 2015 2:28 PM<br>
To: Thomas Freeman; Iuliu Rus<br>
Cc: <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>;
<a href="mailto:uliur@google.com" target="_blank">uliur@google.com</a><br>
Subject: Re: [nvmewin] FW: NVME fuzz test fixes<br>
<br>
PMC approves the patch.<br>
<br>
Thank you!<br>
Alex<br>
<br>
From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org%3cmailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">
nvmewin-bounces@lists.openfabrics.org<mailto:nvmewin-bounces@lists.openfabrics.org</a>> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">mailto:nvmewin-bounces@lists.openfabrics.org</a>] On Behalf Of Thomas Freeman<br>
Sent: Tuesday, September 22, 2015 1:02 PM<br>
To: Iuliu Rus<br>
Cc: <a href="mailto:nvmewin@lists.openfabrics.org%3cmailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org<mailto:nvmewin@lists.openfabrics.org</a>>; <a href="mailto:uliur@google.com%3cmailto:uliur@google.com" target="_blank">
uliur@google.com<mailto:uliur@google.com</a>><br>
Subject: Re: [nvmewin] FW: NVME fuzz test fixes<br>
<br>
<br>
HGST approves these changes.<br>
<br>
Tom Freeman<br>
Software Engineer, Device Manager and Driver Development<br>
HGST, a Western Digital company<br>
<a href="mailto:thomas.freeman@hgst.com%3cmailto:thomas.freeman@hgst.com" target="_blank">thomas.freeman@hgst.com<mailto:thomas.freeman@hgst.com</a>><br>
<a href="tel:507-322-2311" value="+15073222311" target="_blank">507-322-2311</a><br>
<br>
[HGST_Logo_email]<br>
3605 Hwy 52 N<br>
Rochester, MN 55901<br>
<a href="http://www.hgst.com%3chttps:/hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/" target="_blank">www.hgst.com<https://hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/</a>><br>
<br>
From: Iuliu Rus [<a href="mailto:iuliur@google.com" target="_blank">mailto:iuliur@google.com</a>]<br>
Sent: Tuesday, September 15, 2015 12:08 PM<br>
To: Thomas Freeman <<a href="mailto:thomas.freeman@hgst.com%3cmailto:thomas.freeman@hgst.com" target="_blank">thomas.freeman@hgst.com<mailto:thomas.freeman@hgst.com</a>>><br>
Cc: Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com%3cmailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com<mailto:raymond.c.robles@intel.com</a>>>;
<a href="mailto:nvmewin@lists.openfabrics.org%3cmailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org<mailto:nvmewin@lists.openfabrics.org</a>>; <a href="mailto:uliur@google.com%3cmailto:uliur@google.com" target="_blank">
uliur@google.com<mailto:uliur@google.com</a>><br>
Subject: Re: [nvmewin] FW: NVME fuzz test fixes<br>
<br>
Thanks for the great feedback. Fixed all and attached the new zip (same password). I also reran the tests, but for 3) the Microsoft fuzz test seems to have no coverage. It keeps asking for sense data with aloc length of 0 (like 100 times). I artificially tested
this by modifying the allocLength variable in kernel debugger.<br>
<br>
<br>
<br>
On Mon, Sep 14, 2015 at 1:41 PM, Thomas Freeman <<a href="mailto:thomas.freeman@hgst.com%3cmailto:thomas.freeman@hgst.com" target="_blank">thomas.freeman@hgst.com<mailto:thomas.freeman@hgst.com</a>>> wrote:<br>
Iuliu,<br>
The changes look good.<br>
I have just a few comments.<br>
<br>
1. nvmeSnti.C/Line 1157 ? memset(pResponseBuffer, 0, allocLength); This was added to the comment, but it?s not clear why. I suspect it is an accidental addition. If so, this should be removed.<br>
<br>
2. nvmeSnti.c/Line 1519 ? Since the Lun value is actually written to the second byte of the entry, the comparison should be:<br>
<br>
if (lunIdDataOffset + SINGLE_LVL_LUN_OFFSET >= allocLength)<br>
<br>
<br>
<br>
As an example, test with a buffer size of 0x11. Without this change, the driver will actually write the byte after the allocated buffer.<br>
<br>
3. nvmeSnti.c/Line 2652 & 2669. Your change handles the case where there is no data buffer. But, it does not handle the case where the buffer is smaller than sizeof(DESCRIPTOR_FORMAT_SENSE_DATA). With a small buffer allocation, these writes would access
beyond the allocated buffer<br>
<br>
pSenseData->ErrorCode = FIXED_SENSE_DATA;<br>
<br>
pSenseData->SenseKey = SCSI_SENSE_NO_SENSE;<br>
<br>
pSenseData->AdditionalSenseLength = FIXED_SENSE_DATA_ADD_LENGTH;<br>
<br>
pSenseData->AdditionalSenseCode = SCSI_ADSENSE_NO_SENSE;<br>
<br>
pSenseData->AdditionalSenseCodeQualifier = 0;<br>
<br>
<br>
Regards,<br>
Tom Freeman<br>
Software Engineer, Device Manager and Driver Development<br>
HGST, a Western Digital company<br>
<a href="mailto:thomas.freeman@hgst.com%3cmailto:thomas.freeman@hgst.com" target="_blank">thomas.freeman@hgst.com<mailto:thomas.freeman@hgst.com</a>><br>
<a href="tel:507-322-2311" value="+15073222311" target="_blank">507-322-2311</a><<a href="tel:507-322-2311" target="_blank">tel:507-322-2311</a>><br>
<br>
[HGST_Logo_email]<br>
3605 Hwy 52 N<br>
Rochester, MN 55901<br>
<a href="http://www.hgst.com%3chttps:/hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/" target="_blank">www.hgst.com<https://hgst.jiveon.com/external-link.jspa?url=http://www.hgst.com/</a>><br>
<br>
From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org%3cmailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">
nvmewin-bounces@lists.openfabrics.org<mailto:nvmewin-bounces@lists.openfabrics.org</a>> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org%3cmailto:nvmewin-bounces@lists.openfabrics.org%3e" target="_blank">mailto:nvmewin-bounces@lists.openfabrics.org<mailto:nvmewin-bounces@lists.openfabrics.org></a>]
On Behalf Of Robles, Raymond C<br>
Sent: Friday, September 11, 2015 3:29 PM<br>
To: <a href="mailto:nvmewin@lists.openfabrics.org%3cmailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org<mailto:nvmewin@lists.openfabrics.org</a>><br>
Subject: [nvmewin] FW: NVME fuzz test fixes<br>
<br>
All,<br>
<br>
Here is the original patch from Google (Iuliu) for the WHCK fuzz tests.<br>
<br>
Thanks,<br>
Ray<br>
<br>
From: <a href="mailto:nvmewin-bounces@lists.openfabrics.org%3cmailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">
nvmewin-bounces@lists.openfabrics.org<mailto:nvmewin-bounces@lists.openfabrics.org</a>> [<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">mailto:nvmewin-bounces@lists.openfabrics.org</a>] On Behalf Of Iuliu Rus<br>
Sent: Monday, August 03, 2015 1:37 PM<br>
To: <a href="mailto:nvmewin@lists.openfabrics.org%3cmailto:nvmewin@lists.openfabrics.org" target="_blank">
nvmewin@lists.openfabrics.org<mailto:nvmewin@lists.openfabrics.org</a>><br>
Subject: [nvmewin] NVME fuzz test fixes<br>
<br>
Hello,<br>
I have attached the fixes we (Google) did for the several crashes / corruptions exposed by the Windows HCK fuzztest.exe.<br>
We have tested this on qemu/ Server 2012 R2.<br>
The password on the zip is "nvme" :)<br>
HGST E-mail Confidentiality Notice & Disclaimer:<br>
This e-mail and any files transmitted with it may contain confidential or legally privileged information of HGST and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure,
copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.<br>
<br>
_______________________________________________<br>
nvmewin mailing list<br>
<a href="mailto:nvmewin@lists.openfabrics.org%3cmailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org<mailto:nvmewin@lists.openfabrics.org</a>><br>
<a href="http://lists.openfabrics.org/mailman/listinfo/nvmewin" target="_blank">http://lists.openfabrics.org/mailman/listinfo/nvmewin</a><br>
<br>
HGST E-mail Confidentiality Notice & Disclaimer:<br>
This e-mail and any files transmitted with it may contain confidential or legally privileged information of HGST and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure,
copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150923/fede796b/attachment.html" target="_blank">http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150923/fede796b/attachment.html</a>><br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: image001.png<br>
Type: image/png<br>
Size: 4274 bytes<br>
Desc: image001.png<br>
URL: <<a href="http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150923/fede796b/attachment.png" target="_blank">http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150923/fede796b/attachment.png</a>><br>
<br>
------------------------------<br>
<br>
_______________________________________________<br>
nvmewin mailing list<br>
<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a><br>
<a href="http://lists.openfabrics.org/mailman/listinfo/nvmewin" target="_blank">http://lists.openfabrics.org/mailman/listinfo/nvmewin</a><br>
<br>
<br>
End of nvmewin Digest, Vol 45, Issue 21<br>
***************************************<br>
<p> </p><p> </p><u></u><u></u></p>
<p class="MsoNormal" style="margin:0in;margin-bottom:.0001pt"><img border="0" src="http://ext.samsung.net/mailcheck/SeenTimeChecker?do=36652d682e3669a8058afc1f1dafb9f39cd05f6ab872f9f6313cb48408a29da1bbef98290b9ea6844a835b19b8ec809fc7b41e955949e5c8a728c55b39cc59eacf878f9a26ce15a0"><u></u><u></u></p>
</div></div></div>
</div>
</blockquote></div><br></div>