<div dir="ltr">We can put both solutions in if you want. Synchronization is cheap if the locks are never held.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 9, 2016 at 2:32 PM, Robles, Raymond C <span dir="ltr"><<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Hi Iuliu/Suman,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">I’m of the opinion that any solution provided should be as robust as possible. In the case Suman points out, concurrent channels should still be enabled even
if the number of cores and queues do not match. This is especially true for large core count systems (>128 logical cpu cores) but devices may only support 32 queues or less.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Thank you…<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Ray<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Iuliu Rus [mailto:<a href="mailto:iuliur@google.com" target="_blank">iuliur@google.com</a>]
<br>
<b>Sent:</b> Thursday, June 09, 2016 2:09 PM<br>
<b>To:</b> <a href="mailto:suman.p@samsung.com" target="_blank">suman.p@samsung.com</a><br>
<b>Cc:</b> Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>>; <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> Re: review comments for patch from Google<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Which one do you prefer? Our google driver has the synchronization in place already for a different reason. Or, I can follow your second suggestion.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Jun 9, 2016 at 7:39 AM, SUMAN PRAKASH B <<a href="mailto:suman.p@samsung.com" target="_blank">suman.p@samsung.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Hi Iuliu,</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Please find my review comments below:</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">1. If the number of Cores and Queues supported by device are not same, then setting STOR_PERF_CONCURRENT_CHANNELS will corrupt the submission queue. For example, if device has 4 queues and connected
to target PC which has 8 logical processors, and if STOR_PERF_CONCURRENT_CHANNELS is set, all the 8 logical processors will get startIo calls concurrently. As per OFA driver NUMA design, the IO Queue 1 will be shared by core 0 and core 4. There is possibility
that core 0 and core 4 will get startio() calls concurrently and will access/update the listenty and queue 1 doorbell register at same time, which will lead to listentry and doorbell register corruption.
<br>
This problem can be address by following ways:<br>
a. Protect the listentry and doorbell before access/update.<br>
b. Do not set STOR_PERF_CONCURRENT_CHANNELS when number of cores and queues are not same.</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">2. We can use pRMT->NumActiveCores which is updated in NVMeEnumNumaCores() instead of using KeQueryActiveProcessorCountEx/KeQueryActiveProcessorCount.</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Please let us know your opinion.</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thanks,<br>
Suman</span><u></u><u></u></p>
<p> <u></u><u></u></p>
<p>------- <b>Original Message</b> -------<u></u><u></u></p>
<p><b>Sender</b> : Robles, Raymond C<<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>><u></u><u></u></p>
<p><b>Date</b> : Jun 09, 2016 03:56 (GMT+05:30)<u></u><u></u></p>
<p><b>Title</b> : Re: [nvmewin] Happy New Year... and status update<u></u><u></u></p>
<p> <u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Thank you Iuliu!</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060;background:yellow">Reviewing companies, please try to target the review completion for 2 weeks from
today (6/22/16).</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">
</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Thank you!</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Ray</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Iuliu Rus [mailto:<a href="mailto:iuliur@google.com" target="_blank">iuliur@google.com</a>]
<br>
<b>Sent:</b> Wednesday, June 08, 2016 12:26 PM<br>
<b>To:</b> Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> Re: Happy New Year... and status update</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">I attached our patch. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jun 7, 2016 at 2:37 PM, Iuliu Rus <<a href="mailto:iuliur@google.com" target="_blank">iuliur@google.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Let me see if i can get it done by tomorrow eod...<u></u><u></u></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jun 7, 2016 at 2:31 PM, Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Hi Iuliu,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">That’s great… thank you. Yes, the process is still the same (using SVN patches).</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Please let me know if you have any questions/comments. My only question for you is an ETA for the patch
to be submitted.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Thank you…</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060">Ray</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Iuliu Rus [mailto:<a href="mailto:iuliur@google.com" target="_blank">iuliur@google.com</a>]
<br>
<b>Sent:</b> Tuesday, June 07, 2016 2:28 PM<br>
<b>To:</b> Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a><br>
<b>Subject:</b> Re: Happy New Year... and status update</span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">Yes we can send that to you. Is the process still the same?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Tue, Jun 7, 2016 at 1:25 PM, Robles, Raymond C <<a href="mailto:raymond.c.robles@intel.com" target="_blank">raymond.c.robles@intel.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span style="color:#002060">Hello Iuliu,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060">As the OFA community is closing on its mid-year release, we have only one more patch that was targeted… concurrent channels. Will Google still be submitting
the concurrent channels patch?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060">Thank you…</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060">Ray</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#002060"> </span><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b>
<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a> [mailto:<a href="mailto:nvmewin-bounces@lists.openfabrics.org" target="_blank">nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Robles, Raymond C<br>
<b>Sent:</b> Thursday, January 14, 2016 4:55 PM<br>
<b>To:</b> '<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>' <<a href="mailto:nvmewin@lists.openfabrics.org" target="_blank">nvmewin@lists.openfabrics.org</a>><br>
<b>Subject:</b> [nvmewin] Happy New Year... and status update<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Hello and Happy New Year,</span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">I hope everyone had a great holiday season and is off to a great start to the new year!</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">As communicated last month, the patch from HGST for the SCSI multi-initiator changes has been approved
and pushed. The holidays slowed down much of the progress on the OFA driver and there were several patches that did not get pushed prior to the end of the year. The list of patches remained to be pushed are as follows…</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:Symbol;color:#44546a">·</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Namespace Management (Intel)</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:Symbol;color:#44546a">·</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Perf Opts (Samsung)
</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:Symbol;color:#44546a">·</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Win 8.1 Timers (Samsung)</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:Symbol;color:#44546a">·</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">EOL Read Only (Samsung)</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:Symbol;color:#44546a">·</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Concurrent channels (Google)</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">The namespace management patch will be sent out for review tomorrow (look for the patch email from
Carolyn)… stay tuned!!!</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">However, once this patch is resolved, we as a community will have to make a decision on an official
release strategy. The patch process and cadence was significantly slower in 2015 which leaves us with a few options.
</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">1.</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Release what is in the trunk today (or after the namespace management patch)… and call that the 2015 release (albeit later than expected)</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">2.</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">In lieu of an official 2015 release, we push the remaining patches listed above… and then release in ~Q2 of 2015. Basically skip a 2015 release and go right into the mid-2016
release.</span><u></u><u></u></p>
<p><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">3.</span><span style="font-size:7.0pt;color:#44546a">
</span><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Remove the concept of “official releases” from the OFA Windows NVMe driver and just allow people, companies, and users to pull from the OFA trunk as necessary.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">For #3 above, my thoughts are that because the OFA driver is not a production driver… but a reference
and enabling driver, it should/could be managed as just that… a reference baseline driver that any potential user can go and grab the source, or contribute a patch. Nothing more… nothing less.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a;background:yellow">For the release decision, I’ll be happy to call a meeting… but we can also handle
it via email as well… just let me know. Feedback from all is welcome… but I would request mandatory feedback form the 4 reviewing companies: Samsung, HGST, PMC-Sierra, and Intel. How would you like to proceed?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Thanks,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a">Ray</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#44546a"> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#1f497d"><img border="0" width="54" height="39" src="cid:image001.png@01D1C25B.B96EBDB0" alt="cid:image001.png@01CB3870.4BB88E70"></span></b><u></u><u></u></p>
<p class="MsoNormal"><b><i><span style="font-family:"Intel Clear",sans-serif;color:#1f497d">Raymond C. Robles</span></i></b><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#1f497d">Non-Volatile Memory Solutions Group</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#1f497d">Intel Corporation</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#1f497d">Office:
<a href="tel:480-554-2600" target="_blank">480-554-2600</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Intel Clear",sans-serif;color:#1f497d">Mobile:
<a href="tel:480-399-0645" target="_blank">480-399-0645</a></span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<p> <u></u><u></u></p>
<p> <u></u><u></u></p>
<table border="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt">
<p><img border="0" width="520" height="144" src="cid:image002.gif@01D1C25B.B96EBDB0"><u></u><u></u></p>
</td>
</tr>
</tbody>
</table>
</div>
<p class="MsoNormal"><img border="0" src="http://ext.samsung.net/mailcheck/SeenTimeChecker?do=9226f2572c3ad117df6a46883b3f3dde1d283838fa336dda194352576c69fe9bfdd53f331c9856e34bea3c1765014a1208cece8541bc14eacf878f9a26ce15a0"><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>