<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style>
<!--
@font-face
{font-family:Wingdings}
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif}
a:link, span.MsoHyperlink
{color:#0563C1;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:#954F72;
text-decoration:underline}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:24.0pt;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif}
p.msonormal0, li.msonormal0, div.msonormal0
{margin-right:0in;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
span.EmailStyle19
{font-family:"Calibri",sans-serif;
color:windowtext}
span.EmailStyle20
{font-family:"Calibri",sans-serif;
color:windowtext}
span.EmailStyle21
{font-family:"Calibri",sans-serif;
color:windowtext}
span.EmailStyle22
{font-family:"Calibri",sans-serif;
color:#002060;
font-weight:normal;
font-style:normal;
text-decoration:none none}
span.EmailStyle23
{font-family:"Calibri",sans-serif;
color:windowtext}
span.EmailStyle24
{font-family:"Calibri",sans-serif;
color:#002060;
font-weight:normal;
font-style:normal}
.MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:1.0in 1.25in 1.0in 1.25in}
div.WordSection1
{}
ol
{margin-bottom:0in}
ul
{margin-bottom:0in}
-->
</style>
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="">
<div dir="ltr">Ray, I just discovered this email - it was routed to my junk folder. I'll review early next week</div>
<br>
<br>
<div dir="ltr">Tom Freeman</div>
<div dir="ltr">Software Engineer, Device Manager and Driver Development</div>
<div dir="ltr">Western Digital</div>
<div dir="ltr">Email: Thomas.Freeman@wdc.com</div>
<div dir="ltr">Office:+1-507-322-2311</div>
<br>
<br>
<div dir="ltr">-------- Original Message --------</div>
<div dir="ltr">Subject: Re: [nvmewin] Compatibility issue with 1.5 version nvme driver</div>
<div dir="ltr">From: "Robles, Raymond C" <raymond.c.robles@intel.com></div>
<div dir="ltr">Date: Jun 13, 2017, 3:31 PM</div>
<div dir="ltr">To: Justina Lai <justina_lai@phison.com>,nvmewin@lists.openfabrics.org</div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Hi Justina,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">I’m still waiting for feedback from Samsung and HGST on your patch.
</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt; color:#002060; background:yellow">Tom/Judy/Suman</span></b><span style="font-size:11.0pt; color:#002060; background:yellow">,
</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060; background:yellow"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060; background:yellow">Can you please provide feedback on Phison’s patch for the BSOD fix for grabbing the same lock twice?</span><span style="font-size:11.0pt; color:#002060"></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Thanks…</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Ray</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> Justina Lai [mailto:justina_lai@phison.com]
<br>
<b>Sent:</b> Thursday, May 25, 2017 7:08 PM<br>
<b>To:</b> Robles, Raymond C <raymond.c.robles@intel.com>; nvmewin@lists.openfabrics.org<br>
<b>Cc:</b> Larry Li <larry_li@phison.com>; 'umaparepalli@gmail.com' <umaparepalli@gmail.com><br>
<b>Subject:</b> RE: Compatibility issue with 1.5 version nvme driver</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="">Hi Raymond,</span></a></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Thanks for reply.</span></p>
<p class="MsoNormal"><span style="">Please find attachment.</span></p>
<p class="MsoNormal"><span style="">It’s modified based on 4/8 157 version.</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Thanks!</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<div>
<p class="MsoNormal"><span style="">Best Regards,</span></p>
<p class="MsoNormal"><span style="">Justina Lai</span></p>
<p class="MsoNormal"><span style="">#5707</span></p>
</div>
<p class="MsoNormal"><span style=""> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> Robles, Raymond C [<a href="mailto:raymond.c.robles@intel.com">mailto:raymond.c.robles@intel.com</a>]
<br>
<b>Sent:</b> Friday, May 26, 2017 1:36 AM<br>
<b>To:</b> Justina Lai <<a href="mailto:justina_lai@phison.com">justina_lai@phison.com</a>>;
<a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Cc:</b> Larry Li <<a href="mailto:larry_li@phison.com">larry_li@phison.com</a>>; 'umaparepalli@gmail.com' <<a href="mailto:umaparepalli@gmail.com">umaparepalli@gmail.com</a>><br>
<b>Subject:</b> RE: Compatibility issue with 1.5 version nvme driver</span></p>
</div>
</div>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Hi Justina,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">The issue you mention below is a known issue. I thought there was a patch pushed to fix this, but if not, then my recommendation is to provide a patch that resolves this issue.
</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">The main issue is for commands that require 2 child commands, the lock is acquired a second time for the second time on the completions side of the first child command. It should be a very simple
fix. </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Normally, I request that community members who find the issue submit patches to resolve this issue. This is our model. Could you please provide the patch for the fix?</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt; color:#002060">NOTE: Uma Parepalli is the new OFA chair and will handle this issue moving forward.
</span></b></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060">Thanks…<br>
Ray</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#002060"> </span></p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> nvmewin [<a href="mailto:nvmewin-bounces@lists.openfabrics.org">mailto:nvmewin-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Justina Lai<br>
<b>Sent:</b> Thursday, May 25, 2017 1:03 AM<br>
<b>To:</b> <a href="mailto:nvmewin@lists.openfabrics.org">nvmewin@lists.openfabrics.org</a><br>
<b>Cc:</b> Larry Li <<a href="mailto:larry_li@phison.com">larry_li@phison.com</a>><br>
<b>Subject:</b> Re: [nvmewin] Compatibility issue with 1.5 version nvme driver</span></p>
</div>
</div>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Dear Sir/Madam,</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">We are facing compatibility issue on our PS5007 NVMe device with recent 1.5 version nvme driver.</span></p>
<p class="MsoNormal"><span style="">Please check below issue description.</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Phison PS5007 supports 7 IO queues, and if we use PS5007 with OFA driver on the platform core number>7, ex: 8-core or 12-core PC, we will see PC hang up and cannot enter OS like below:</span></p>
<p class="MsoNormal"><span style=""><img border="0" width="538" height="302" id="_x0000_i1025" src="cid:image001.jpg@01D2E449.53D9E4A0"></span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">After debugging on our side, we found the fail is caused by below flow:</span></p>
<p class="MsoNormal"><span style="">---------------------------------------------------------------------------------------------------------------------------------------------------------------------</span></p>
<p class="MsoNormal"><span style="">……….</span></p>
<p class="MsoNormal" style="margin-left:.25in; text-indent:-.25in"><span style=""><span style="">1.<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="">SntiTranslateModeSense()</span></p>
<p class="MsoListParagraph" style="margin-left:.25in"><span style="">……….</span></p>
<p class="MsoNormal"><span style="">2.IoCompletionRoutine()</span></p>
<p class="MsoNormal"><span style=""> if (pDpc != NULL) {</span></p>
<p class="MsoNormal"><span style=""> ASSERT(pAE->ntldrDump == FALSE);</span></p>
<p class="MsoNormal"><span style=""> if (<span style="color:red">pAE->MultipleCoresToSingleQueueFlag</span>) {</span></p>
<p class="MsoNormal"><span style=""> <span style="color:red">StorPortAcquireSpinLock(pAE, StartIoLock, NULL, &StartLockHandle); --------------------</span></span><span style="font-family:Wingdings; color:red">à</span><span style="color:red"> execute
lock</span></p>
<p class="MsoNormal"><span style=""> } else {</span></p>
<p class="MsoNormal"><span style=""> StorPortAcquireSpinLock(pAE, DpcLock, pDpc, &DpcLockhandle);</span></p>
<p class="MsoNormal"><span style=""> }</span></p>
<p class="MsoNormal"><span style=""> }</span></p>
<p class="MsoNormal"><span style="">………</span></p>
<p class="MsoNormal"><span style="">callStorportNotification = pSrbExtension->pNvmeCompletionRoutine(pAE, (PVOID)pSrbExtension)</span></p>
<p class="MsoNormal"><span style=""> && (pSrbExtension->pSrb != NULL);</span></p>
<p class="MsoNormal"><span style="">…….</span></p>
<p class="MsoNormal"><span style="">3.SntiTranslateModeSenseResponse()</span></p>
<p class="MsoListParagraph" style="margin-left:.25in"><span style="">…….</span></p>
<p class="MsoNormal"><span style="">case MODE_SENSE_RETURN_ALL:</span></p>
<p class="MsoNormal"><span style="">…….</span></p>
<p class="MsoNormal"><span style="">if (supportsVwc == TRUE) {</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style=""> pSrbExt->pNvmeCompletionRoutine = SntiCompletionCallbackRoutine;</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style=""> /* Finally, make sure we issue the GET FEATURES command */</span></p>
<p class="MsoNormal"><span style=""> SntiBuildGetFeaturesCmd(pSrbExt, VOLATILE_WRITE_CACHE);</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style=""> ioStarted =
<span style="color:red">ProcessIo</span>(pSrbExt->pNvmeDevExt,</span></p>
<p class="MsoNormal"><span style=""> pSrbExt,</span></p>
<p class="MsoNormal"><span style=""> NVME_QUEUE_TYPE_ADMIN,</span></p>
<p class="MsoNormal"><span style="">
<span style="color:red">TRUE</span>);</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">4.ProcessIo() </span></p>
<p class="MsoNormal"><span style=""> ……..</span></p>
<p class="MsoNormal"><span style=""> if (<span style="color:red">AcquireLock == TRUE</span>) {</span></p>
<p class="MsoNormal"><span style=""> <span style="color:red">StorPortAcquireSpinLock</span>(pAdapterExtension,</span></p>
<p class="MsoNormal"><span style=""> StartIoLock,</span></p>
<p class="MsoNormal"><span style=""> NULL,</span></p>
<p class="MsoNormal"><span style=""> &hStartIoLock);
<span style="color:red">----------------------</span></span><span style="font-family:Wingdings; color:red">à</span><span style="color:red"> double execute lock and cause (Assertion failure - code c0000420)</span><span style="color:#1F497D"></span></p>
<p class="MsoNormal"><span style="color:red"> </span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style=""> } </span></p>
<p class="MsoNormal"><span style="">---------------------------------------------------------------------------------------------------------------------------------------------------------------------</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Since many users are now using our PS5007 device with 8-core or 12-core PC, they are facing this issue right now. Could you please help to modify driver to solve this problem asap?</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Any unclear point, please kindly let us know.</span></p>
<p class="MsoNormal"><span style="">Thank you very much for the help!</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal"><span style="">Best Regards,</span></p>
<p class="MsoNormal"><span style="">Justina Lai</span></p>
<p class="MsoNormal"><span style="">#5707</span></p>
<p class="MsoNormal"><span style=""> </span></p>
<p class="MsoNormal" style=""><span style="font-family:"Times New Roman",serif"><br>
</span><span style="font-family:"Arial",sans-serif; color:gray"><br>
This message and any attachments are confidential and may be legally privileged. Any unauthorized review, use or distribution by anyone other than the intended recipient is strictly prohibited. If you are not the intended recipient, please immediately notify
the sender, completely delete the message and any attachments, and destroy all copies. Your cooperation will be highly appreciated.</span><span style="font-family:"Times New Roman",serif"></span></p>
<p class="MsoNormal" style=""><span style="font-family:"Times New Roman",serif"><br>
</span><span style="font-family:"Arial",sans-serif; color:gray"><br>
This message and any attachments are confidential and may be legally privileged. Any unauthorized review, use or distribution by anyone other than the intended recipient is strictly prohibited. If you are not the intended recipient, please immediately notify
the sender, completely delete the message and any attachments, and destroy all copies. Your cooperation will be highly appreciated.</span><span style="font-family:"Times New Roman",serif"></span></p>
</div>
</div>
</body>
</html>