<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">git submodules -1<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Having the fabtests in the same git repository would be nice. If there are changes to libfabric that would need corresponding updates to fabtests to get it to
work you could put all that into one git commit.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">One ask: don’t integrate fabtests into the libfabric build. I would prefer to have fabtest in its own directory with its own autogen.sh/configure/libtool build
system, packaging, etc.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> ofiwg [mailto:ofiwg-bounces@lists.openfabrics.org]
<b>On Behalf Of </b>Wesley Bland<br>
<b>Sent:</b> Monday, August 27, 2018 8:25 AM<br>
<b>To:</b> Jeff Squyres <jsquyres@cisco.com><br>
<b>Cc:</b> OFIWG Mailing list <ofiwg@lists.openfabrics.org><br>
<b>Subject:</b> Re: [ofiwg] sharing code between libfabric and fabtests<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I agree. We have both submodules and the tests in the MPICH repository (for separate things obviously) and I can say that while our use of submodules makes sense (we don’t want to include all of libfabric in the MPICH tree), it’s a pain.
Having the tests in the same repo makes sense. I can think of <i>other</i> projects that keep the test bucket separate, but I think it’s usually for license reasons rather than cleanliness. <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Wesley<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Aug 25, 2018, at 7:28 AM, Jeff Squyres (jsquyres) <<a href="mailto:jsquyres@cisco.com">jsquyres@cisco.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">My $0.02: don't use git submodule. It's more complicated than you think.<br>
<br>
Merging the repos would be fine with me.<br>
<br>
<br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">On Aug 25, 2018, at 1:47 AM, Jeff Hammond <<a href="mailto:jeff.science@gmail.com">jeff.science@gmail.com</a>> wrote:<br>
<br>
TL;DR merge the repos.<br>
<br>
I honestly don’t know why any project would separate the test bucket from the implementation except strictly at the git repo level i.e. test bucket repo is assumed to be git submodule in implementation repo.<br>
<br>
Jeff<br>
<br>
On Fri, Aug 24, 2018 at 5:23 PM Hefty, Sean <<a href="mailto:sean.hefty@intel.com">sean.hefty@intel.com</a>> wrote:<br>
Because of the need to support OS and platform portability, there's a small, but growing, amount of code that needs to be shared between fabtests and libfabric. Today the code has been duplicated. (As an example, the definitions for complex data types are
duplicated).<br>
<br>
I know git has a submodule option (and subtree) that's close to what we need. We might also be able to use some sort of build script to pull in the related files. We could even move the shared code into a separate repo used by both, which might make submodules
friendlier, and is probably the 'right' choice...<br>
<br>
Does anyone have ideas as to the best option here?<br>
<br>
- Sean<br>
_______________________________________________<br>
ofiwg mailing list<br>
<a href="mailto:ofiwg@lists.openfabrics.org">ofiwg@lists.openfabrics.org</a><br>
<a href="https://lists.openfabrics.org/mailman/listinfo/ofiwg">https://lists.openfabrics.org/mailman/listinfo/ofiwg</a><br>
-- <br>
Jeff Hammond<br>
<a href="mailto:jeff.science@gmail.com">jeff.science@gmail.com</a><br>
<a href="http://jeffhammond.github.io/">http://jeffhammond.github.io/</a><br>
_______________________________________________<br>
ofiwg mailing list<br>
<a href="mailto:ofiwg@lists.openfabrics.org">ofiwg@lists.openfabrics.org</a><br>
<a href="https://lists.openfabrics.org/mailman/listinfo/ofiwg">https://lists.openfabrics.org/mailman/listinfo/ofiwg</a><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><br>
<br>
-- <br>
Jeff Squyres<br>
<a href="mailto:jsquyres@cisco.com">jsquyres@cisco.com</a><br>
<br>
_______________________________________________<br>
ofiwg mailing list<br>
<a href="mailto:ofiwg@lists.openfabrics.org">ofiwg@lists.openfabrics.org</a><br>
<a href="https://lists.openfabrics.org/mailman/listinfo/ofiwg">https://lists.openfabrics.org/mailman/listinfo/ofiwg</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>