[Openib-windows] RE: company name in OpenIB code
ftillier at silverstorm.com
Tue Nov 1 09:50:50 PST 2005
> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Tuesday, November 01, 2005 9:43 AM
> > From: Fab Tillier [mailto:ftillier at silverstorm.com]
> > Sent: Tuesday, November 01, 2005 7:22 PM
> > Hi Yossi,
> > > From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> > > Sent: Tuesday, November 01, 2005 4:56 AM
> > >
> > > 2.
> > > In the duplicate flow the code create files with eth name
> > > "SilverStorm-PID- Identifier"
> > >
> > > I think we should change it to be OpenIB or get the company
> > >name from
> > > the env vars that the makefile define (which is better)
> > These files are never visible to anyone since they're not
> > true file system files. The name is really irrelevant, and I
> > don't think that there's any value in letting them be
> > configurable via an environment variable. I'm open to
> > changing it to reference OpenIB so feel free to send me a
> > patch, but this is a
> > *really* low priority item to me. There are far more
> > important things that we
> > (collectively) should be spending time on than these
> > insignificant cosmetic issues.
> I agree about the priority. But still need to clean the code , pls putt it in
> your list.
I've added this to the Access Layer TODO list on the OpenIB Windows WIKI. Feel
free to send a patch if this bothers you.
> > Lastly, I am not at all interested in enabling branding of
> > what should be a single-source binary. I'll take patches to
> > reference OpenIB, but will not take any patches that allow
> > individual branding. It just doesn't make any sense -
> > companies should be using the OpenIB binaries, period.
> What about the inf files ? Do you want to remove them from the source tree ?
Why should they be removed? Removing them makes the OpenIB repository much less
useful to the community since any users would have to write their own INF files.
That's just a silly suggestion.
They should be changed to OpenIB branding, unless there are product-specific
entries. For example, there's a generic IB I/O Unit device key in the
ibbus.inf, which should not reference any particular vendor. There are also
entries for SilverStorm VEx and VFx, which have unique and distinguishable
device IDs. We should add any other vendor's device IDs as long as they are
unique. Changing the branding in the INF files is also covered by the TODO
entry in the Access Layer TODO list in the OpenIB Windows Wiki.
Feel free to send me a patch for these changes if they bother you.
More information about the ofw