[ofw] [PATCH] winverbs: convert connect/accept to sync calls

Sean Hefty sean.hefty at intel.com
Thu Aug 27 09:44:35 PDT 2009


>Oh, that's too bad.  Any idea what that does to connection rate?

No idea.

All IRPs against the EP need to be completed before WvEpFree returns, so there
may be other options to fix this.  No fix that keeps the async operation seems
trivial though.  (WorkQueueFlush seems hard, but I think provides the most
generic solution.)

WvEpCompleteDisconnect also queues IRPs to the work queue, and I *think* may
have an issue.  It can leave an IRP outstanding after an application crashes,
which has the potential to touch the WvProvider structure after it's been
deleted.  I say potential because I really can't tell if that's the case or not.

The race in both of these cases is fairly small, but I was able to hit the case
where an asynchronous WvEpAccept call touched the IbCmId after it was freed.

- Sean




More information about the ofw mailing list