<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [patch] resource files</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>>> i've also changed ics_ver.h file to set product version equal to the file</FONT>
<BR><FONT SIZE=2>>> version.</FONT>
</P>
<P><FONT SIZE=2>> I'm not quite sure what you mean here</FONT>
</P>
<P><FONT SIZE=2>Please, look at 'Product Version' of the WINIB binaries: it is 5.2.3790.<build_num></FONT>
<BR><FONT SIZE=2>'File Version', which you define in ics_ver.h, is common for all the binaries and in fact is the product version.</FONT>
<BR><FONT SIZE=2>So i've changed ics_ver.h to set product version equal to the file version.</FONT>
<BR><FONT SIZE=2>Here is the change:</FONT>
</P>
<P><FONT SIZE=2>--------------------------------------------------------------</FONT>
<BR><FONT SIZE=2>Index: S:/svn.wininf/trunk/inc/ics_ver.h</FONT>
<BR><FONT SIZE=2>===================================================================</FONT>
<BR><FONT SIZE=2>--- S:/svn.wininf/trunk/inc/ics_ver.h (revision 165)</FONT>
<BR><FONT SIZE=2>+++ S:/svn.wininf/trunk/inc/ics_ver.h (revision 166)</FONT>
<BR><FONT SIZE=2>@@ -49,6 +49,13 @@</FONT>
<BR><FONT SIZE=2> #define VER_FILEREV 114 </FONT>
<BR><FONT SIZE=2> #endif</FONT>
<BR><FONT SIZE=2> </FONT>
<BR><FONT SIZE=2>+#define VER_PRODUCTMAJORVERSION VER_FILEMAJORVERSION</FONT>
<BR><FONT SIZE=2>+#define VER_PRODUCTMINORVERSION VER_FILEMINORVERSION</FONT>
<BR><FONT SIZE=2>+#define VER_PRODUCTBUILD /* NT */ VER_FILEBUILD</FONT>
<BR><FONT SIZE=2>+#define VER_PRODUCTBUILD_QFE VER_FILEREV</FONT>
<BR><FONT SIZE=2>+</FONT>
<BR><FONT SIZE=2> #if (VER_FILEBUILD < 10)</FONT>
<BR><FONT SIZE=2> #define VER_FILEBPAD "000"</FONT>
<BR><FONT SIZE=2> #elif (VER_FILEBUILD < 100)</FONT>
</P>
<BR>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Fab Tillier [<A HREF="mailto:ftillier@silverstorm.com">mailto:ftillier@silverstorm.com</A>]</FONT>
<BR><FONT SIZE=2>Sent: Wednesday, July 13, 2005 5:00 PM</FONT>
<BR><FONT SIZE=2>To: 'Leonid Keller'; Yossi Leybovich</FONT>
<BR><FONT SIZE=2>Cc: openib-windows@openib.org; Windows Group; Aviram Gutman</FONT>
<BR><FONT SIZE=2>Subject: RE: [patch] resource files</FONT>
</P>
<BR>
<P><FONT SIZE=2>> From: Leonid Keller [<A HREF="mailto:leonid@mellanox.co.il">mailto:leonid@mellanox.co.il</A>]</FONT>
<BR><FONT SIZE=2>> Sent: Wednesday, July 13, 2005 2:15 AM</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> i've also changed ics_ver.h file to set product version equal to the file</FONT>
<BR><FONT SIZE=2>> version.</FONT>
<BR><FONT SIZE=2>> [in fact, it is the file version, that is equal to the product version, but</FONT>
<BR><FONT SIZE=2>> technically it is v.v. so far]</FONT>
</P>
<P><FONT SIZE=2>I'm not quite sure what you mean here - can you send a patch for this?</FONT>
</P>
<P><FONT SIZE=2>> I've also removed the company name from VER_FILEDESCRIPTION_STR of resource</FONT>
<BR><FONT SIZE=2>> files.</FONT>
</P>
<P><FONT SIZE=2>I think the resource files no longer have company names - Yossi's patch did that</FONT>
<BR><FONT SIZE=2>too.</FONT>
</P>
<P><FONT SIZE=2>> So ics_ver.h is the only file that contains company and product names and it</FONT>
<BR><FONT SIZE=2>> is easy to build the package with the desired ones.</FONT>
</P>
<P><FONT SIZE=2>Can you send a patch for this stuff?</FONT>
</P>
<P><FONT SIZE=2>Thanks,</FONT>
</P>
<P><FONT SIZE=2>- Fab</FONT>
</P>
</BODY>
</HTML>