<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML xmlns="http://www.w3.org/TR/REC-html40" xmlns:w =
"urn:schemas-microsoft-com:office:word" xmlns:o =
"urn:schemas-microsoft-com:office:office"><HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=US-ASCII">
<TITLE>Message</TITLE>
<LINK
href="cid:filelist.xml@01C59C2C.8F68C7B0" rel=File-List><!--[if gte mso 9]><xml>
<o:OfficeDocumentSettings>
<o:DoNotRelyOnCSS/>
</o:OfficeDocumentSettings>
</xml><![endif]--><!--[if gte mso 9]><xml>
<w:WordDocument>
<w:SpellingState>Clean</w:SpellingState>
<w:GrammarState>Clean</w:GrammarState>
<w:DocumentKind>DocumentEmail</w:DocumentKind>
<w:EnvelopeVis/>
<w:BrowserLevel>MicrosoftInternetExplorer4</w:BrowserLevel>
</w:WordDocument>
</xml><![endif]-->
<STYLE>@font-face {
font-family: Tahoma;
}
P.MsoNormal {
FONT-FAMILY: "Times New Roman"; FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; mso-style-parent: ""; mso-pagination: widow-orphan; mso-fareast-font-family: "Times New Roman"
}
LI.MsoNormal {
FONT-FAMILY: "Times New Roman"; FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; mso-style-parent: ""; mso-pagination: widow-orphan; mso-fareast-font-family: "Times New Roman"
}
DIV.MsoNormal {
FONT-FAMILY: "Times New Roman"; FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; mso-style-parent: ""; mso-pagination: widow-orphan; mso-fareast-font-family: "Times New Roman"
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; text-underline: single
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; text-underline: single
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; text-underline: single
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; text-underline: single
}
P {
FONT-FAMILY: "Times New Roman"; FONT-SIZE: 12pt; MARGIN-LEFT: 0in; MARGIN-RIGHT: 0in; mso-pagination: widow-orphan; mso-fareast-font-family: "Times New Roman"; mso-margin-top-alt: auto; mso-margin-bottom-alt: auto
}
SPAN.EmailStyle18 {
COLOR: navy; FONT-FAMILY: Arial; mso-style-type: personal-reply; mso-style-noshow: yes; mso-ansi-font-size: 10.0pt; mso-bidi-font-size: 10.0pt; mso-ascii-font-family: Arial; mso-hansi-font-family: Arial; mso-bidi-font-family: Arial
}
SPAN.SpellE {
mso-style-name: ""; mso-spl-e: yes
}
DIV.Section1 {
page: Section1
}
</STYLE>
<!--[if gte mso 10]>
<style>
/* Style Definitions */
table.MsoNormalTable
{mso-style-name:"Table Normal";
mso-tstyle-rowband-size:0;
mso-tstyle-colband-size:0;
mso-style-noshow:yes;
mso-style-parent:"";
mso-padding-alt:0in 5.4pt 0in 5.4pt;
mso-para-margin:0in;
mso-para-margin-bottom:.0001pt;
mso-pagination:widow-orphan;
font-size:10.0pt;
font-family:"Times New Roman";}
</style>
<![endif]-->
<META content="MSHTML 5.00.2314.1000" name=GENERATOR></HEAD>
<BODY lang=EN-US link=blue style="tab-interval: .5in" vLink=purple>
<DIV><FONT color=#0000ff face=Arial size=2><SPAN class=468222011-09082005>i
agree with Yossy.</SPAN></FONT></DIV>
<DIV><FONT color=#0000ff face=Arial size=2><SPAN class=468222011-09082005>To my
mind, errors have to be printed in release version also.</SPAN></FONT></DIV>
<DIV><FONT color=#0000ff face=Arial size=2><SPAN
class=468222011-09082005>A compromise is to make them unprintable by
default, but to give </SPAN></FONT><FONT color=#0000ff face=Arial size=2><SPAN
class=468222011-09082005>some way to turn them on at run
time.</SPAN></FONT></DIV>
<BLOCKQUOTE dir=ltr style="MARGIN-RIGHT: 0px">
<DIV align=left class=OutlookMessageHeader dir=ltr><FONT face=Tahoma
size=2>-----Original Message-----<BR><B>From:</B> Yossi Leybovich
[mailto:sleybo@mellanox.co.il]<BR><B>Sent:</B> Monday, August 08, 2005 3:42
PM<BR><B>To:</B> Tzachi Dar; 'Fab Tillier'<BR><B>Cc:</B>
'openib-windows@openib.org'<BR><B>Subject:</B> RE: [Openib-windows] Debug
prints in free version<BR><BR></DIV></FONT>
<DIV><FONT color=#0000ff face=Arial size=2><SPAN
class=342192212-08082005>CB</SPAN></FONT></DIV>
<BLOCKQUOTE dir=ltr style="MARGIN-RIGHT: 0px">
<DIV></DIV>
<DIV align=left class=OutlookMessageHeader dir=ltr lang=en-us><FONT
face=Tahoma size=2>-----Original Message-----<BR><B>From:</B> Tzachi Dar
<BR><B>Sent:</B> Monday, August 08, 2005 3:15 PM<BR><B>To:</B> Yossi
Leybovich; Fab Tillier<BR><B>Cc:</B>
openib-windows@openib.org<BR><B>Subject:</B> RE: [Openib-windows] Debug
prints in free version<BR><BR></FONT></DIV>
<DIV class=Section1>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Printing (even only
in the case of errors) will hurt performance for the following
reasons:<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Today, these macros
are being removed out at compile time. If they are there in release, the
check that is made if to print or not will still be executed.
<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p><SPAN
class=342192212-08082005><FONT color=#0000ff>[YL] not if you use them just
in case of error (i.e if (status != IB_SUCCESS )
AL_TRACE(AL_DBG_ERROR......) and that the way most\all of the current code
do</FONT></SPAN></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p><SPAN
class=342192212-08082005><FONT color=#0000ff>UI also think that this
the way VAPI\Gen2 behave.</FONT></SPAN></o:p></SPAN></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Having these
functions in our code also means bigger foot print of our functions and
therefore another hit in performance (for example more cache
misses).<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p><SPAN
class=342192212-08082005><FONT color=#0000ff>[YL] That right but I think
that if you check it, it want heart the performance that much but you help
the user a lot to define his mistakes or give us log to debug our
bugs</FONT></SPAN></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Please also note
that your idea is not enough since the IPOIB code is using the macro
IPOIB_TRACE which should also be changed to exist in free also. (There is a
list of macros that should be changed).<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p> <SPAN
class=342192212-08082005><FONT color=#0000ff>[YL] AFAIK all Macros map to
CL_PRINT so you just need to change in one place on all the ULPs behave the
same.</FONT></SPAN></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">We might do a
separate build that is free but still has the prints, but debug messages
should be omitted from the binaries that we give to our
customers.<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p> <SPAN
class=342192212-08082005><FONT color=#0000ff>[YL] I still think that error
massages should free version it want help the customer if will force him to
reinsatll another version of the
driver.</FONT></SPAN></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Thanks<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt">Tzachi<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT color=navy face=Arial size=2><SPAN
style="COLOR: navy; FONT-FAMILY: Arial; FONT-SIZE: 10pt"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal style="MARGIN-LEFT: 0.5in"><FONT face=Tahoma size=2><SPAN
style="FONT-FAMILY: Tahoma; FONT-SIZE: 10pt">-----Original
Message-----<BR><B><SPAN style="FONT-WEIGHT: bold">From:</SPAN></B> Yossi
Leybovich [mailto:sleybo@mellanox.co.il] <BR><B><SPAN
style="FONT-WEIGHT: bold">Sent:</SPAN></B> Monday, August 08, 2005 3:05
PM<BR><B><SPAN style="FONT-WEIGHT: bold">To:</SPAN></B> Fab
Tillier<BR><B><SPAN style="FONT-WEIGHT: bold">Cc:</SPAN></B>
openib-windows@openib.org<BR><B><SPAN
style="FONT-WEIGHT: bold">Subject:</SPAN></B> [Openib-windows] Debug prints
in free version</SPAN></FONT></P>
<P class=MsoNormal style="MARGIN-LEFT: 0.5in"><FONT face="Times New Roman"
size=3><SPAN style="FONT-SIZE: 12pt"><o:p> </o:p></SPAN></FONT></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">Fab</SPAN></FONT>
<o:p></o:p></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">I think it will make it easy to
all of us if the stack will generate printf in case of error.</SPAN></FONT>
<BR><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">In the current defines in order
to debug any kernel level component you need to replace the sys file to the
debug version </SPAN></FONT><o:p></o:p></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">It will be better if
:</SPAN></FONT> <BR><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">CL_PRINT in case of ERROR_DBG
should use cl_msg_out so it will generate print even in free
version</SPAN></FONT> <o:p></o:p></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">It should not heart the data
flow (we print just in case of error)</SPAN></FONT> <o:p></o:p></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">What do you think
?</SPAN></FONT> <o:p></o:p></P>
<P style="MARGIN-LEFT: 0.5in"><FONT face=Arial size=2><SPAN
style="FONT-FAMILY: Arial; FONT-SIZE: 10pt">Yossi
</SPAN></FONT><o:p></o:p></P></DIV></BLOCKQUOTE></BLOCKQUOTE></BODY></HTML>