<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: company name in OpenIB code</TITLE>
</HEAD>
<BODY>
<BR>
<BR>
<P><FONT SIZE=2>> -----Original Message-----</FONT>
<BR><FONT SIZE=2>> From: Fab Tillier [<A HREF="mailto:ftillier@silverstorm.com">mailto:ftillier@silverstorm.com</A>] </FONT>
<BR><FONT SIZE=2>> Sent: Tuesday, November 01, 2005 7:22 PM</FONT>
<BR><FONT SIZE=2>> To: 'Yossi Leybovich'</FONT>
<BR><FONT SIZE=2>> Cc: openib-windows@openib.org</FONT>
<BR><FONT SIZE=2>> Subject: RE: company name in OpenIB code</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Hi Yossi,</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > From: Yossi Leybovich [<A HREF="mailto:sleybo@mellanox.co.il">mailto:sleybo@mellanox.co.il</A>]</FONT>
<BR><FONT SIZE=2>> > Sent: Tuesday, November 01, 2005 4:56 AM</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > We still have 2 issues with embedded company name in the code 1.</FONT>
<BR><FONT SIZE=2>> > the bus port mngr create the IpoIB devices with the name :</FONT>
<BR><FONT SIZE=2>> > #define IPOIB_DESCRIPTION L"InfiniCon IPoIB Adapter"</FONT>
<BR><FONT SIZE=2>> > (I know that the inf change this value but we would like to </FONT>
<BR><FONT SIZE=2>> see it with the</FONT>
<BR><FONT SIZE=2>> > right name from the begging)</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> This should be renamed "IPoIB Adapter", with no company name. </FONT>
<BR><FONT SIZE=2>> I have zero interest in making the company name configurable.</FONT>
</P>
<P><FONT SIZE=2>OK . </FONT>
</P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > 2.</FONT>
<BR><FONT SIZE=2>> > In the duplicate flow the code create files with eth name </FONT>
<BR><FONT SIZE=2>> > "SilverStorm-PID- Identifier"</FONT>
<BR><FONT SIZE=2>> > </FONT>
<BR><FONT SIZE=2>> > I think we should change it to be OpenIB or get the company </FONT>
<BR><FONT SIZE=2>> name from </FONT>
<BR><FONT SIZE=2>> > the env vars that the makefile define (which is better)</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> These files are never visible to anyone since they're not </FONT>
<BR><FONT SIZE=2>> true file system files. The name is really irrelevant, and I </FONT>
<BR><FONT SIZE=2>> don't think that there's any value in letting them be </FONT>
<BR><FONT SIZE=2>> configurable via an environment variable. I'm open to </FONT>
<BR><FONT SIZE=2>> changing it to reference OpenIB so feel free to send me a </FONT>
<BR><FONT SIZE=2>> patch, but this is a</FONT>
<BR><FONT SIZE=2>> *really* low priority item to me. There are far more </FONT>
<BR><FONT SIZE=2>> important things that we</FONT>
<BR><FONT SIZE=2>> (collectively) should be spending time on than these </FONT>
<BR><FONT SIZE=2>> insignificant cosmetic issues.</FONT>
</P>
<P><FONT SIZE=2>I agree about the priority. But still need to clean the code , pls putt it in your list.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Lastly, I am not at all interested in enabling branding of </FONT>
<BR><FONT SIZE=2>> what should be a single-source binary. I'll take patches to </FONT>
<BR><FONT SIZE=2>> reference OpenIB, but will not take any patches that allow </FONT>
<BR><FONT SIZE=2>> individual branding. It just doesn't make any sense - </FONT>
<BR><FONT SIZE=2>> companies should be using the OpenIB binaries, period.</FONT>
<BR><FONT SIZE=2>> </FONT>
</P>
<P><FONT SIZE=2>What about the inf files ? Do you want to remove them from the source tree ?</FONT>
</P>
</BODY>
</HTML>