<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2654.45">
<TITLE>RE: [PATCH] FW version in vstat</TITLE>
</HEAD>
<BODY>
<BR>
<BR>
<P><FONT SIZE=2>> -----Original Message-----</FONT>
<BR><FONT SIZE=2>> From: Fab Tillier [<A HREF="mailto:ftillier@silverstorm.com">mailto:ftillier@silverstorm.com</A>] </FONT>
<BR><FONT SIZE=2>> Sent: Monday, November 07, 2005 9:23 AM</FONT>
<BR><FONT SIZE=2>> To: 'Yossi Leybovich'</FONT>
<BR><FONT SIZE=2>> Cc: openib-windows@openib.org</FONT>
<BR><FONT SIZE=2>> Subject: RE: [PATCH] FW version in vstat</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Hi Yossi,</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Thanks for the explanation - I just didn't understand what </FONT>
<BR><FONT SIZE=2>> you were trying to do in your earlier mail.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > > In the new verb API I started defining the FW version is a 32-bit </FONT>
<BR><FONT SIZE=2>> > > field in the CA attributes. Can you do the same thing here?</FONT>
<BR><FONT SIZE=2>> ></FONT>
<BR><FONT SIZE=2>> > We use 64 bits for FW version (its 3 digits of 16 bits )</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Ok, I've changed the structure in the new API to give the FW </FONT>
<BR><FONT SIZE=2>> version 64-bits. I think it makes sense to have this field </FONT>
<BR><FONT SIZE=2>> in the common structure, similar to the device attributes in </FONT>
<BR><FONT SIZE=2>> the Linux stack.</FONT>
</P>
<P><FONT SIZE=2>I will add it to the current ca_attr API</FONT>
</P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > [in the futur we might want to add cmd_if version to this number]</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> I don't see this being generic enough to warrant putting into </FONT>
<BR><FONT SIZE=2>> the common structure.</FONT>
</P>
<P><FONT SIZE=2>OK . In the future I will add it to the vendor specific data.</FONT>
</P>
<P><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> > So either we can change it to be 64bit or make it vendor specific</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> It's up to you if you would rather have the FW version in the </FONT>
<BR><FONT SIZE=2>> common structure or not - let me know either way. If going </FONT>
<BR><FONT SIZE=2>> on with the vendor specific data, I can apply the patch you </FONT>
<BR><FONT SIZE=2>> sent for the HCA driver changes. However, I'd like to see </FONT>
<BR><FONT SIZE=2>> vstat account for that based on the reported vendor ID of the </FONT>
<BR><FONT SIZE=2>> CA attributes. That is, only extract the FW version from the </FONT>
<BR><FONT SIZE=2>> vendor specific data if the vendor ID is known to encode </FONT>
<BR><FONT SIZE=2>> extra information there.</FONT>
<BR><FONT SIZE=2>> </FONT>
</P>
<P><FONT SIZE=2>I will add it to the ca_attr struct , vendor with no FW version will set this field to 0, and the vstat will ignore it.</FONT>
<BR><FONT SIZE=2>I will send patch later today.</FONT>
</P>
<P><FONT SIZE=2>> > My question was where do you want this header to be place?</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> The header could go either in the hw directory for that </FONT>
<BR><FONT SIZE=2>> driver, or could go into the inc\iba directory, but with a </FONT>
<BR><FONT SIZE=2>> name indicative of its relationship to the specific HW.</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> Thanks,</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> - Fab</FONT>
<BR><FONT SIZE=2>> </FONT>
</P>
</BODY>
</HTML>