<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:D="DAV:" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns="http://www.w3.org/TR/REC-html40"
xmlns:ns0="http://schemas.microsoft.com/exchange/services/2006/messages"
xmlns:ns1="http://schemas.microsoft.com/exchange/services/2006/types"
xmlns:ns2="http://schemas.openxmlformats.org/package/2006/relationships"
xmlns:ns3="http://schemas.microsoft.com/office/2004/12/omml"
xmlns:ns4="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:ns5="http://schemas.microsoft.com/sharepoint/soap/workflow/">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--a:link
{mso-style-priority: 99
;}
span.MSOHYPERLINK
{mso-style-priority: 99
;}
a:visited
{mso-style-priority: 99
;}
span.MSOHYPERLINKFOLLOWED
{mso-style-priority: 99
;}
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:Calibri;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>Just committing is not the right process
to follow. This should not be committed until the issue that Fab pointed out
is addressed. The size is being rounded down, which at least to me looks like
the returned pointers are referencing the wrong memory.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'>From what you say, this fixes a print. Why
is there a rush to commit a patch just for a print?<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=navy face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:navy'><o:p> </o:p></span></font></p>
<div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Leonid Keller<br>
<b><span style='font-weight:bold'>Sent:</span></b> Wednesday, April 09, 2008
11:59 PM<br>
<b><span style='font-weight:bold'>To:</span></b> Fab Tillier; Reuven Amitai;
ofw@lists.openfabrics.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> RE: [ofw] RE: [PATCH]
mthca patch [1/2]</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>Hi Fab,</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>This patch fixes printing of uplink
information in VSTAT and i'm going to commit it now, because it improves the
current state.</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>But really all the implementation of
vendor-specific information in query_ca is bad.</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>We need to define a structure, describing
all that info and to work with names, not calculated offsets.</span></font><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>We'll put it on our todo list.</span></font><o:p></o:p></p>
</div>
<blockquote style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt;
margin-left:3.75pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabIndex=-1>
</span></font></div>
<p class=MsoNormal style='margin-bottom:12.0pt'><b><font size=2 face=Tahoma><span
style='font-size:10.0pt;font-family:Tahoma;font-weight:bold'>From:</span></font></b><font
size=2 face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'>
ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b><span
style='font-weight:bold'>On Behalf Of </span></b>Fab Tillier<br>
<b><span style='font-weight:bold'>Sent:</span></b> Wednesday, April 09, 2008
7:44 PM<br>
<b><span style='font-weight:bold'>To:</span></b> Reuven Amitai;
ofw@lists.openfabrics.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> [ofw] RE: [PATCH] mthca
patch [1/2]</span></font><o:p></o:p></p>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Hi Reuven,<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><o:p> </o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>What is the problem with
the alignment? The board ID is a character string, so shouldn’t
need any special alignment. Also, you are rounding the size down –
is that the right thing to do?<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><o:p> </o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>What is the layout of the
ca_attr buffer, and what are the alignment requirements for the different
structures appended to the end?<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><o:p> </o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Is MTHCA_BRD_ID_LEN going
to cause the uplink info to be aligned?<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><o:p> </o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Thanks,<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>-Fab<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span color:#1F497D? Calibri?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><o:p> </o:p></span></font></p>
</span>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span Tahoma?,?sans-serif??><font size=3
face="Times New Roman"><span style='font-size:12.0pt;font-weight:bold'>From:</span></span></font></b><span
Tahoma?,?sans-serif??> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <b><span style='font-weight:bold'>On
Behalf Of </span></b>Reuven Amitai<br>
<b><span style='font-weight:bold'>Sent:</span></b> Wednesday, April 09, 2008
6:04 AM<br>
<b><span style='font-weight:bold'>To:</span></b> ofw@lists.openfabrics.org<br>
<b><span style='font-weight:bold'>Subject:</span></b> [ofw] [PATCH] mthca patch
[1/2]<o:p></o:p></p>
</div>
</div>
</span>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<div>
<p class=MsoNormal><span color:blue? Arial?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Hi,</span><o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><span color:blue? Arial?,?sans-serif?;><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>The following patch align
the returned address.</span><o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<p class=MsoNormal><em><span color:blue? Arial?,?sans-serif?;><i><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Thanks, Reuven.</span></span></font></i></em><o:p></o:p></p>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
<div>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>Index: inc/mthca/mthca_vc.h<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>===================================================================<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>--- inc/mthca/mthca_vc.h
(revision 1047)<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+++ inc/mthca/mthca_vc.h
(working copy)<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>@@ -78,12 +78,18 @@<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> <o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> inline char* mthca_get_board_id(ib_ca_attr_t
*ca_attr)<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> {<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>- return
(char*)(ca_attr)+(ca_attr->size - MTHCA_BRD_ID_LEN - sizeof(uplink_info_t));<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ int size = (ca_attr->size
- MTHCA_BRD_ID_LEN - sizeof(uplink_info_t));<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ size &= ~(sizeof(void*)
- 1);<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ <o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ return (char*)(ca_attr)+
size;<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> }<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> <o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> inline void* mthca_get_uplink_info(ib_ca_attr_t
*ca_attr)<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> {<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>- return
(char*)(ca_attr)+(ca_attr->size - sizeof(uplink_info_t));<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ int size = (ca_attr->size
- sizeof(uplink_info_t));<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ size &= ~(sizeof(void*)
- 1);<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'>+ return (char*)(ca_attr)+
size;<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> }<o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> <o:p></o:p></span></font></p>
</span>
<p class=MsoNormal><span New?? Courier><font size=3 face="Times New Roman"><span
style='font-size:12.0pt'> #endif<o:p></o:p></span></font></p>
</div>
</span>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'> <o:p></o:p></span></font></p>
</div>
</blockquote>
</div>
</div>
</body>
</html>