<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
p
{mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'>
<div>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>Index: mlx4/kernel/inc/l2w_list.h<br>
===================================================================<br>
--- mlx4/kernel/inc/l2w_list.h (revision 1197)<br>
+++ mlx4/kernel/inc/l2w_list.h (working copy)<br>
@@ -38,14 +38,14 @@<br>
* This is only for internal list manipulation where we know<br>
* the prev/next entries already!<br>
*/<br>
-static inline void __list_add(struct list_head *new,<br>
+static inline void __list_add(struct list_head *new1,<br>
struct list_head *prev,<br>
struct list_head *next)<br>
{<br>
- next->prev = new;<br>
- new->next = next;<br>
- new->prev = prev;<br>
- prev->next = new;<br>
+ next->prev = new1;<br>
+ new1->next = next;<br>
+ new1->prev = prev;<br>
+ prev->next = new1;<br>
}<br>
<br>
/**<br>
@@ -56,9 +56,9 @@<br>
* Insert a new entry after the specified head.<br>
* This is good for implementing stacks.<br>
*/<br>
-static inline void list_add(struct list_head *new, struct list_head *head)<br>
+static inline void list_add(struct list_head *new1, struct list_head *head)<br>
{<br>
- __list_add(new, head, head->next);<br>
+ __list_add(new1, head, head->next);<br>
}<br>
<br>
/**<br>
@@ -69,9 +69,9 @@<br>
* Insert a new entry before the specified head.<br>
* This is useful for implementing queues.<br>
*/<br>
-static inline void list_add_tail(struct list_head *new, struct list_head
*head)<br>
+static inline void list_add_tail(struct list_head *new1, struct list_head
*head)<br>
{<br>
- __list_add(new, head->prev, head);<br>
+ __list_add(new1, head->prev, head);<br>
}<br>
<br>
<font color=navy><span style='color:navy'><o:p></o:p></span></font></span></font></p>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>I don’t understand the need for these
changes. Also, Windows provides list management functions that we should use,
rather than porting the calls from Linux.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 color=blue face=Arial><span style='font-size:
10.0pt;font-family:Arial;color:blue'>- Sean<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
</div>
</div>
</div>
</body>
</html>