<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML xmlns="http://www.w3.org/TR/REC-html40" xmlns:st1 =
"urn:schemas-microsoft-com:office:smarttags" xmlns:w =
"urn:schemas-microsoft-com:office:word" xmlns:o =
"urn:schemas-microsoft-com:office:office" xmlns:v =
"urn:schemas-microsoft-com:vml"><HEAD><!--[if !mso]>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<STYLE>v\:* {
BEHAVIOR: url(#default#VML)
}
o\:* {
BEHAVIOR: url(#default#VML)
}
w\:* {
BEHAVIOR: url(#default#VML)
}
.shape {
BEHAVIOR: url(#default#VML)
}
</STYLE>
<![endif]--><o:SmartTagType name="PersonName"
namespaceuri="urn:schemas-microsoft-com:office:smarttags"></o:SmartTagType><!--[if !mso]>
<STYLE>st1\:* {
BEHAVIOR: url(#default#ieooui)
}
</STYLE>
<![endif]-->
<STYLE>@font-face {
font-family: Tahoma;
}
@page Section1 {size: 8.5in 11.0in; margin: 1.0in 1.25in 1.0in 1.25in; }
P.MsoNormal {
FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Times New Roman"
}
LI.MsoNormal {
FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Times New Roman"
}
DIV.MsoNormal {
FONT-SIZE: 12pt; MARGIN: 0in 0in 0pt; FONT-FAMILY: "Times New Roman"
}
A:link {
COLOR: blue; TEXT-DECORATION: underline
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline
}
P {
FONT-SIZE: 12pt; MARGIN-LEFT: 0in; MARGIN-RIGHT: 0in; FONT-FAMILY: "Times New Roman"; mso-margin-top-alt: auto; mso-margin-bottom-alt: auto
}
SPAN.EmailStyle18 {
COLOR: navy; FONT-FAMILY: Arial; mso-style-type: personal
}
SPAN.EmailStyle19 {
COLOR: navy; FONT-FAMILY: Arial; mso-style-type: personal
}
SPAN.EmailStyle20 {
COLOR: navy; FONT-FAMILY: Arial; mso-style-type: personal
}
SPAN.EmailStyle21 {
COLOR: navy; FONT-FAMILY: Arial; mso-style-type: personal-reply
}
DIV.Section1 {
page: Section1
}
</STYLE>
<META content="MSHTML 6.00.6000.16640" name=GENERATOR></HEAD>
<BODY lang=EN-US vLink=purple link=blue>
<DIV>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Tzachi Dar [mailto:tzachid@mellanox.co.il]
<BR><B>Sent:</B> Saturday, May 24, 2008 10:58 AM<BR><B>To:</B> Smith, Stan;
Hefty, Sean<BR><B>Cc:</B> ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: [ofw]
patch: [mlx4] Add minor function (is_power_of_2)andfixcompilation issues on
C++.<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff size=2>Hi
Smith,</FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial size=2><SPAN
class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT size=2><SPAN
class=626075919-25052008>Hello Tzachi. You can call me
Stan.</SPAN></FONT></FONT></FONT></SPAN></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT color=#0000ff><FONT
size=2>I'm not sure why you address me in this mail, I didn't add these
files.<SPAN
class=626075919-25052008> </SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT color=#0000ff><FONT
size=2><SPAN
class=626075919-25052008></SPAN></FONT></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN class=626075919-25052008>You happened to respond to Sean's email
and are recognized as a senior developer in the Mellanox windows
effort. T</SPAN></FONT></FONT></FONT></SPAN><SPAN
class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT size=2><SPAN
class=626075919-25052008>herefore, you should be aware of the GPL src code rules
and the implications of GPL code being contributed to an open source
project.</SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN
class=626075919-25052008></SPAN></FONT></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN class=626075919-25052008>Next week I will be running a commercial
GPL code recognition tool over the entire openib-windows src base which will
identify offending files. Since you mentioned knowledge of existing GPL'ed files
please proceed with their replacement.</SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN class=626075919-25052008>Developers must 'always' be aware of the
src code they contribute to an open source
project.</SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN
class=626075919-25052008></SPAN></FONT></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN
class=626075919-25052008>stan.</SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial><FONT size=+0><FONT
size=2><SPAN
class=626075919-25052008></SPAN></FONT></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff size=2>In any
case, the offending code must be removed and that is agreed.</FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff size=2>If you
(and Sean) can let us know which are the offending files, they will be
removed.</FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff
size=2>Thanks</FONT></SPAN></DIV>
<DIV><SPAN class=163575517-24052008><FONT face=Arial color=#0000ff
size=2>Tzachi</FONT></SPAN></DIV><BR>
<BLOCKQUOTE dir=ltr
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Smith, Stan
[mailto:stan.smith@intel.com] <BR><B>Sent:</B> Friday, May 23, 2008 7:39
PM<BR><B>To:</B> Hefty, Sean; Tzachi Dar<BR><B>Cc:</B>
ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: [ofw] patch: [mlx4] Add minor
function (is_power_of_2)andfixcompilation issues on C++.<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2>Tzachi,</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2> There is not much to discuss. </FONT></SPAN><SPAN
class=313144515-23052008><FONT face=Arial color=#0000ff size=2>The offending
code must be removed as soon as possible.</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff size=2>The
presence of 'any' identifiable sections of Linux kernel header files infects
the entire WinOF module such that it can not exist under
a BSD license. The entire module code base becomes GPL'ed
(infected) due to the identifiable presence of Linux kernel code (parts of
Linux header files). Once the module is GPL'ed, those who help us the
most will be forbidden to examine the module source and likely the entire
WinOF stack; don't bite the hand that feeds you.</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff size=2>This
is a serious situation, given the changing OFA Windows contributor
agreement.</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2>Please correct this situation immediately.</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff size=2>I
would suggest using BSD code or get creative with the C pre-processor and use
Windows functions wrapped in macros.</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2>thank you,</FONT></SPAN></DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=313144515-23052008><FONT face=Arial color=#0000ff
size=2>stan.</FONT></SPAN></DIV><BR>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Sean
Hefty<BR><B>Sent:</B> Wednesday, May 21, 2008 4:49 PM<BR><B>To:</B> Hefty,
Sean; 'Tzachi Dar'; ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: [ofw]
patch: [mlx4] Add minor function (is_power_of_2)andfixcompilation issues on
C++.<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV class=Section1>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial">Actually there are
several header files that have been ported from Linux… This should
probably be discussed in one of the working group meetings to determine what
needs to be done.<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<DIV
style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; PADDING-LEFT: 4pt; PADDING-BOTTOM: 0in; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 0in; BORDER-BOTTOM: medium none">
<DIV>
<DIV class=MsoNormal style="TEXT-ALIGN: center" align=center><FONT
face="Times New Roman" size=3><SPAN style="FONT-SIZE: 12pt">
<HR tabIndex=-1 align=center width="100%" SIZE=2>
</SPAN></FONT></DIV>
<P class=MsoNormal><B><FONT face=Tahoma size=2><SPAN
style="FONT-WEIGHT: bold; FONT-SIZE: 10pt; FONT-FAMILY: Tahoma">From:</SPAN></FONT></B><FONT
face=Tahoma size=2><SPAN style="FONT-SIZE: 10pt; FONT-FAMILY: Tahoma">
<st1:PersonName w:st="on">Hefty, Sean</st1:PersonName> <BR><B><SPAN
style="FONT-WEIGHT: bold">Sent:</SPAN></B> Wednesday, May 21, 2008 4:36
PM<BR><B><SPAN style="FONT-WEIGHT: bold">To:</SPAN></B> <st1:PersonName
w:st="on">Hefty, Sean</st1:PersonName>; 'Tzachi Dar';
ofw@lists.openfabrics.org<BR><B><SPAN
style="FONT-WEIGHT: bold">Subject:</SPAN></B> RE: [ofw] patch: [mlx4] Add
minor function (is_power_of_2) andfixcompilation issues on
C++.</SPAN></FONT><o:p></o:p></P></DIV>
<P class=MsoNormal><FONT face="Times New Roman" size=3><SPAN
style="FONT-SIZE: 12pt"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial size=2><SPAN
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial">Someone mentioned to me that the
list implementations were pulled directly from the linux/list.h header file,
and after checking that is the case. I believe that code is GPLv2 and
needs to be removed from the SVN tree.<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<DIV
style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; PADDING-LEFT: 4pt; PADDING-BOTTOM: 0in; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 0in; BORDER-BOTTOM: medium none">
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial">Converting to windows
lists can be a separate patch, but should be straightforward. Maybe we
can combine that with removing it from complib as
well.<o:p></o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<P class=MsoNormal><FONT face=Arial color=navy size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: navy; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P>
<DIV
style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; PADDING-LEFT: 4pt; PADDING-BOTTOM: 0in; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 0in; BORDER-BOTTOM: medium none">
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">The main reason for
this changes is to allow including this files from
C++.</SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face="Times New Roman" size=3><SPAN
style="FONT-SIZE: 12pt"> <o:p></o:p></SPAN></FONT></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">Since new is a
keyword in C++ things simply don't
compile.</SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face="Times New Roman" size=3><SPAN
style="FONT-SIZE: 12pt"> <o:p></o:p></SPAN></FONT></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">As for the option to
remove this lists all together:</SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">In an ideal world you
are probably right. Given the limited time that we had, we have found that
using the </SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">Linux code without
changes saves us a lot of time.</SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face="Times New Roman" size=3><SPAN
style="FONT-SIZE: 12pt"> <o:p></o:p></SPAN></FONT></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">Thanks</SPAN></FONT><o:p></o:p></P></DIV>
<DIV>
<P class=MsoNormal><FONT face=Arial color=blue size=2><SPAN
style="FONT-SIZE: 10pt; COLOR: blue; FONT-FAMILY: Arial">Tzachi</SPAN></FONT><o:p></o:p></P></DIV>
<BLOCKQUOTE
style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; PADDING-LEFT: 3pt; PADDING-BOTTOM: 0in; MARGIN: 5pt 0in 5pt 3.4pt; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 0in; BORDER-BOTTOM: medium none">
<DIV
style="BORDER-RIGHT: medium none; PADDING-RIGHT: 0in; BORDER-TOP: medium none; PADDING-LEFT: 4pt; PADDING-BOTTOM: 0in; BORDER-LEFT: blue 1.5pt solid; PADDING-TOP: 0in; BORDER-BOTTOM: medium none">
<DIV>
<P class=MsoNormal><FONT face=Arial size=2><SPAN
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial"><o:p> </o:p></SPAN></FONT></P></DIV></DIV></BLOCKQUOTE></DIV></DIV></DIV></DIV></BLOCKQUOTE></BODY></HTML>