<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18812"></HEAD>
<BODY>
<DIV dir=ltr align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> Tzachi Dar [mailto:tzachid@mellanox.co.il]
<BR><B>Sent:</B> Wednesday, August 12, 2009 1:56 PM<BR><B>To:</B> Smith, Stan;
ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: patch: Fix a BSOD on
ipoib<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV><SPAN class=086492020-12082009><FONT color=#0000ff size=2 face=Arial>This
should go to the trunk and to the release branch.</FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT color=#0000ff><FONT
size=2>The two ptches look exactly the same to me.<SPAN
class=439173021-12082009> </SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT color=#0000ff><FONT
size=2><SPAN
class=439173021-12082009></SPAN></FONT></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT size=2><SPAN
class=439173021-12082009>Hello,</SPAN></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT size=2><SPAN
class=439173021-12082009> Thank you for confirming my hand patch; will
commit both locations.</SPAN></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT size=2><SPAN
class=439173021-12082009></SPAN></FONT></FONT></SPAN> </DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT size=2><SPAN
class=439173021-12082009>stan.</SPAN></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT face=Arial><FONT color=#0000ff><FONT
size=2><SPAN
class=439173021-12082009> </SPAN></FONT></FONT></FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=086492020-12082009><FONT color=#0000ff size=2
face=Arial>Thanks</FONT></SPAN></DIV>
<DIV><SPAN class=086492020-12082009><FONT color=#0000ff size=2
face=Arial>Tzachi</FONT></SPAN></DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> Smith, Stan [mailto:stan.smith@intel.com]
<BR><B>Sent:</B> Wednesday, August 12, 2009 8:57 PM<BR><B>To:</B> Tzachi Dar;
ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: patch: Fix a BSOD on
ipoib<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT size=2
face=Arial>Hello,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT color=#0000ff
size=2 face=Arial><FONT color=#000000> To which svn branch is this patch
targeted at? It does not apply to the trunk</FONT>\<FONT
color=#000000>ulp/ipoib/kernel/ipoib_port.c ?</FONT></FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT size=2
face=Arial></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT size=2
face=Arial>Hand patching produces the following; is this what you had
intended?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT size=2
face=Arial></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=617044117-12082009><FONT size=2
face=Arial>diff U3
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c.orig
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c<BR>---
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c.orig Mon
Jul 13 09:47:18 2009<BR>+++
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c Wed Aug 12
10:54:25 2009<BR>@@ -4598,8 +4598,11
@@<BR> &p_port->p_local_endpt->gid_item
);<BR> cl_qmap_remove_item(
&p_port->endpt_mgr.mac_endpts,<BR> &p_port->p_local_endpt->mac_item
);<BR>- cl_qmap_remove_item(
&p_port->endpt_mgr.lid_endpts,<BR>- &p_port->p_local_endpt->lid_item
);<BR>+ if( p_port->p_local_endpt->dlid )
{<BR>+ cl_qmap_remove_item(
&p_port->endpt_mgr.lid_endpts,<BR>+ &p_port->p_local_endpt->lid_item
);<BR>+ p_port->p_local_endpt->dlid =
0;<BR>+ }<BR> <BR> cl_qlist_insert_head(<BR> &mc_list,
&p_port->p_local_endpt->mac_item.pool_item.list_item );<BR>@@ -5155,6
+5158,7
@@<BR> {<BR> cl_qmap_remove_item(<BR> &p_port->endpt_mgr.lid_endpts,
&p_endpt->lid_item );<BR>+ p_endpt->dlid =
0;<BR> }<BR> <BR> cl_obj_unlock(
&p_port->obj );<BR></FONT></SPAN></DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Tzachi
Dar<BR><B>Sent:</B> Wednesday, August 12, 2009 1:44 AM<BR><B>To:</B>
ofw@lists.openfabrics.org<BR><B>Subject:</B> [ofw] patch: Fix a BSOD on
ipoib<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV><FONT size=2 face=Arial><SPAN class=344194208-12082009>The patch bellow
fixes a BSOD that happens when restarting the opensm more than once (if the
local endpoint was not in the lid_endpts list).</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN
class=344194208-12082009></SPAN></FONT> </DIV>
<DIV><FONT size=2 face=Arial><SPAN
class=344194208-12082009>Thanks</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN
class=344194208-12082009>Tzachi</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Index:
Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c<BR>===================================================================<BR>---
Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c (revision
4634)<BR>+++
Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c (revision
4635)<BR>@@ -4596,8 +4596,12
@@<BR> &p_port->p_local_endpt->gid_item
);<BR> cl_qmap_remove_item(
&p_port->endpt_mgr.mac_endpts,<BR> &p_port->p_local_endpt->mac_item
);<BR>- cl_qmap_remove_item(
&p_port->endpt_mgr.lid_endpts,<BR>- &p_port->p_local_endpt->lid_item
);<BR>+ if( p_port->p_local_endpt->dlid )
{<BR>+ cl_qmap_remove_item(
&p_port->endpt_mgr.lid_endpts,<BR>+ &p_port->p_local_endpt->lid_item
);<BR>+ p_port->p_local_endpt->dlid =
0;<BR>+
}<BR>+<BR> <BR> cl_qlist_insert_head(<BR> &mc_list,
&p_port->p_local_endpt->mac_item.pool_item.list_item );<BR>@@ -5153,6
+5157,8
@@<BR> {<BR> cl_qmap_remove_item(<BR> &p_port->endpt_mgr.lid_endpts,
&p_endpt->lid_item );<BR>+ p_endpt->dlid =
0;<BR>+<BR> }<BR> <BR> cl_obj_unlock(
&p_port->obj );<BR></DIV></FONT></BODY></HTML>