<br><br>
<div><span class="gmail_quote">On 8/12/09, <b class="gmail_sendername">Sean Hefty</b> <<a href="mailto:sean.hefty@intel.com">sean.hefty@intel.com</a>> wrote:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Return the active width in the port attributes reported by the HCA.<br>Because the kernel and user space share the same source files, to avoid<br>
breaking the API, return the active width in the link_width_supported<br>field, which is currently left uninitialized.<br><br>This fix allows reporting the correct values through the libibverbs<br>port and ibv_devinfo example utility.<br>
<br>Signed-off-by: Sean Hefty <<a href="mailto:sean.hefty@intel.com">sean.hefty@intel.com</a>><br>---<br>I can commit this with similar changes to winverbs to pick this value<br>up. This is not critical, so would not be added to the 2.1 release.<br>
<br>diff -up -r -X \mshefty\scm\winof\trunk\docs\dontdiff.txt -I '\$Id:' trunk\hw/mlx4/kernel/hca/data.c<br>branches\winverbs\hw/mlx4/kernel/hca/data.c<br>--- trunk\hw/mlx4/kernel/hca/data.c 2009-06-11 10:33:38.377375000 -0700<br>
+++ branches\winverbs\hw/mlx4/kernel/hca/data.c 2009-08-12 14:57:04.367506600 -0700<br>@@ -347,6 +347,7 @@ from_hca_cap(<br> ibal_port_p->max_msg_size = mthca_port_p->max_msg_sz;<br> ibal_port_p->mtu = (uint8_t)mthca_port_p->max_mtu;<br>
ibal_port_p->active_speed = mthca_port_p->active_speed;<br>+ ibal_port_p->link_width_supported = mthca_port_p->active_width;</blockquote>
<div> </div>
<div>Shouldn't this be active width rather than supported width ?</div>
<div> </div>
<div>-- Hal</div>
<div> </div><br>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid"> ibal_port_p->phys_state = mthca_port_p->phys_state;<br><br> ibal_port_p->subnet_timeout = mthca_port_p->subnet_timeout;<br>
diff -up -r -X \mshefty\scm\winof\trunk\docs\dontdiff.txt -I '\$Id:' trunk\hw/mthca/kernel/hca_data.c<br>branches\winverbs\hw/mthca/kernel/hca_data.c<br>--- trunk\hw/mthca/kernel/hca_data.c 2009-06-11 10:33:47.846125000 -0700<br>
+++ branches\winverbs\hw/mthca/kernel/hca_data.c 2009-08-12 14:57:05.555029400 -0700<br>@@ -323,6 +323,7 @@ mlnx_conv_hca_cap(<br> ibal_port_p->max_msg_size = mthca_port_p->max_msg_sz;<br> ibal_port_p->mtu = (uint8_t)mthca_port_p->max_mtu;<br>
ibal_port_p->active_speed = mthca_port_p->active_speed;<br>+ ibal_port_p->link_width_supported = mthca_port_p->active_width;<br> ibal_port_p->phys_state = mthca_port_p->phys_state;<br>
<br> ibal_port_p->subnet_timeout = mthca_port_p->subnet_timeout;<br><br><br>_______________________________________________<br>ofw mailing list<br><a href="mailto:ofw@lists.openfabrics.org">ofw@lists.openfabrics.org</a><br>
<a href="http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw">http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw</a><br></blockquote></div><br>