<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.5512" name=GENERATOR></HEAD>
<BODY dir=ltr>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>I was reported a
crash upon running <FONT face="Times New Roman" size=3>“System Common
Scenario”</FONT> WHQL test with our stack.</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>The crash: C4
(0xd7), which means Driver Verifier revealed a re-initializing of Remove
Lock.</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>fffff880`01fa73a8
fffff800`0191b3dc : nt!KeBugCheckEx<BR>fffff880`01fa73b0 fffff800`0192d2e6 :
nt!NtShutdownSystem+0x7f0c<BR>fffff880`01fa73f0 fffff880`02a06974 :
nt!NtShutdownSystem+0x19e16<BR><STRONG>fffff880`01fa7450 fffff800`01937c16 :
ibbus!cl_pnp+0x1d8
[f:\ribel\mlnx_winof_2.0.5\4335\branches\mlnx_winof_2-0\core\complib\kernel\cl_pnp_po.c
@ 211]<BR></STRONG>fffff880`01fa74b0 fffff800`0193a52a :
nt!NtShutdownSystem+0x24746<BR>fffff880`01fa7510 fffff800`01937c16 :
nt!NtShutdownSystem+0x2705a<BR></DIV>
<DIV></FONT></SPAN><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>It happens on win2k8
R2.</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>One can see that
IBAL PnP code, written in 2002 (?) contains in fact re-initialization of
stop Remove Lock.</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>Maybe sometimes it
was possible and was not checked by Driver Verifier or we just haven't come
accross it...</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>Here is a patch that
fixes the problem by eliminating re-initialization of the stop
lock.</FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial size=2>Index:
core/bus/kernel/bus_pnp.c<BR>===================================================================<BR>---
core/bus/kernel/bus_pnp.c (revision 4659)<BR>+++
core/bus/kernel/bus_pnp.c (working copy)<BR>@@ -216,7 +216,6
@@<BR> RtlZeroMemory(p_ext, sizeof
*p_ext);<BR> cl_init_pnp_po_ext( g_ControlDeviceObject,
NULL, <BR> NULL,
bus_globals.dbg_lvl, NULL, NULL );<BR>- IoInitializeRemoveLock(
&p_ext->cl_ext.stop_lock, 'dtci', 0, 1000
);<BR> <BR> /* enable user-mode access to IB stack
*/<BR> BUS_PRINT( BUS_DBG_PNP, ("Remove-n-reCreate
dos_name symlink\n") );<BR>Index:
core/complib/kernel/cl_pnp_po.c<BR>===================================================================<BR>---
core/complib/kernel/cl_pnp_po.c (revision 4659)<BR>+++
core/complib/kernel/cl_pnp_po.c (working copy)<BR>@@ -137,7 +137,8
@@<BR> /* Store the pointer to our own device.
*/<BR> p_ext->p_self_do =
p_dev_obj;<BR> IoInitializeRemoveLock( &p_ext->remove_lock,
'bilc', 15, 1000 );<BR>-<BR>+ IoInitializeRemoveLock(
&p_ext->stop_lock, 'dtci', 0, 1000 );<BR>+ <BR> /*
Initialize the PnP states. */<BR> p_ext->pnp_state =
NotStarted;<BR> p_ext->last_pnp_state = NotStarted;<BR>@@ -428,15
+429,6 @@<BR> if( NT_SUCCESS( status )
)<BR> cl_set_pnp_state( p_ext, Started
);<BR> <BR>- /*<BR>- * If we get the start request when we're
already started, don't <BR>- * re-initialize the stop lock.<BR>-
*/<BR>- if( p_ext->last_pnp_state != Started )
{<BR>- CL_TRACE( CL_DBG_PNP, p_ext->dbg_lvl,
("IoInitializeRemoveLock: stop_lock %p[\n",
&p_ext->stop_lock));<BR>- IoInitializeRemoveLock(
&p_ext->stop_lock, 'dtci', 0, 1000
);<BR>- }<BR>-<BR> CL_EXIT( CL_DBG_PNP, p_ext->dbg_lvl
);<BR> return status;<BR> }<BR>@@ -557,12 +549,6
@@<BR> <BR> if( p_ext->last_pnp_state == Started
)<BR> {<BR>- /*<BR>- * Re-initialize the stop
lock before rolling back the PnP<BR>- * state so that there's no
contention while it's uninitialized.<BR>-
*/<BR>- CL_TRACE( CL_DBG_PNP, p_ext->dbg_lvl,
("IoInitializeRemoveLock: stop_lock %p[\n",
&p_ext->stop_lock));<BR>- IoInitializeRemoveLock(
&p_ext->stop_lock, 'dtci', 0, 1000 );<BR> #if
0 <BR> // leo: it seems like a bug, because it can
never get released<BR> {<BR></FONT></SPAN></DIV>
<DIV><SPAN class=232323116-16082009></SPAN> </DIV>
<DIV><SPAN class=232323116-16082009><FONT face=Arial
size=2></FONT></SPAN> </DIV></BODY></HTML>