<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE></TITLE>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6000.16640" name=GENERATOR></HEAD>
<BODY><!-- Converted from text/plain format -->
<P><FONT size=2><FONT size=3><FONT
color=#ff0000>SB<BR><BR>Thanks<BR>Tzachi</FONT><BR></FONT><BR>-----Original
Message-----<BR>From: Sean Hefty [<A
href="mailto:sean.hefty@intel.com">mailto:sean.hefty@intel.com</A>]<BR>Sent:
Wednesday, September 23, 2009 9:03 PM<BR>To: Tzachi Dar;
ofw@lists.openfabrics.org<BR>Subject: RE: patch: Support APM on IBAL
code<BR><BR>Is there any way to generate the patches, so we can see the function
name that the changes belong to?<BR><FONT color=#ff0000 size=3>I guess there is,
but if someone can tell me how to do it, I'll be happy to do it next
time.</FONT><BR><BR>>2) when sending LAP, there are two parameters for the
path record: one<BR>>is the src port that is based on the av that I'm now
loading. The<BR>>second is the dest_lid which is based on the value that we
have on our<BR>>p_cep->av[p_cep-<BR>>>idx_primary]. I'm not sure if
this is the design, or is this just a<BR>>>bug and<BR>>the dest_lid
should also be taken from the av that is currently being supplied.<BR><BR>I'm
not familiar enough with the code to follow this closely. When sending a
LAP, I would expect the current primary path to be used.<BR><FONT size=3><FONT
color=#ff0000>This is probably what happens. The path used is the alternate path
that was loaded one time before. There have been a migration so this is now the
primary
path.</FONT><BR></FONT>><BR>>+<BR>>+//????????????<BR><BR>please
remove<BR><BR>>@@ -4731,6 +4731,12 @@<BR>>
break;<BR>> }<BR>><BR>>+
if(p_cm_req->h_qp->type == IB_QPT_RELIABLE_CONN)
{<BR>>+ ((al_conn_qp_t *)(p_cm_req->h_qp))->cid =
cid; }<BR><BR>Why limit setting this to RC QPs, versus all
QPs?<BR><BR>>@@ -5424,7 +5430,7 @@<BR>><BR>> __format_mad_hdr(
p_mad->p_mad_buf, p_cep, CM_LAP_ATTR_ID );<BR>><BR>>- __format_mad_av(
p_mad, &p_cep->av[p_cep->idx_primary] );<BR>>+ __format_mad_av(
p_mad, &p_cep->av[((p_cep->idx_primary + 1) & 0x1)]<BR>>+
);<BR><BR>Does this end up sending the LAP on the primary path, or the new
alternate path?<BR><FONT color=#ff0000 size=3>I'll double check this, Very
likely that now the new path is used. I'll look at making sure that the current
primary path is indeed used.</FONT><BR><BR></FONT></P></BODY></HTML>