<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE></TITLE>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18702"></HEAD>
<BODY>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2 face=Arial>It
seems that one change in my code is causing build break, and I have there for
reverted this part on 2467.</FONT></SPAN></DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2 face=Arial>It
seems that the function al_cep_pre_req is now replaced with kal_cep_pre_req
witch doesn't have the IB QP, as part of it.</FONT></SPAN></DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2 face=Arial>In
order to allow me to return this code, it seems that the best solution is to add
a new member to the struct iba_cm_req: iq_qp_hqndle_t h_qp.</FONT></SPAN></DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2 face=Arial>Are
there any objections to this? (In other words, am I breaking some kind of
abstraction here?)</FONT></SPAN></DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial>Thanks</FONT></SPAN></DIV>
<DIV><SPAN class=879472613-24092009><FONT color=#0000ff size=2
face=Arial>Tzachi</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="BORDER-LEFT: #0000ff 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> Tzachi Dar <BR><B>Sent:</B> Thursday,
September 24, 2009 1:39 PM<BR><B>To:</B> Tzachi Dar; Sean Hefty;
ofw@lists.openfabrics.org<BR><B>Subject:</B> RE: [ofw] RE: patch: Support APM
on IBAL code<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2 face=Arial>I
have applied the patch with Sean changes (2466), but one:</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2 face=Arial>The
AV that is used to send the lap message is not the primary one, but the new
loaded alternate path.</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2 face=Arial>I
still need to understand how to use the primary path in this
scenario.</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial>Since I'm working on a urgent project I don't have the time to
do that right now.</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial>Since the old code didn't work at all, I have continued with this
approach that works for WSD, and opened bugzila:</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2 face=Arial><A
href="https://bugs.openfabrics.org/show_bug.cgi?id=1751">https://bugs.openfabrics.org/show_bug.cgi?id=1751</A></FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial></FONT></SPAN> </DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial>Thanks</FONT></SPAN></DIV>
<DIV><SPAN class=294152409-24092009><FONT color=#0000ff size=2
face=Arial>Tzachi</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="BORDER-LEFT: #0000ff 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Tzachi
Dar<BR><B>Sent:</B> Wednesday, September 23, 2009 11:23 PM<BR><B>To:</B>
Sean Hefty; ofw@lists.openfabrics.org<BR><B>Subject:</B> [ofw] RE: patch:
Support APM on IBAL code<BR></FONT><BR></DIV>
<DIV></DIV><!-- Converted from text/plain format -->
<P><FONT size=2><FONT size=3><FONT
color=#ff0000>SB<BR><BR>Thanks<BR>Tzachi</FONT><BR></FONT><BR>-----Original
Message-----<BR>From: Sean Hefty [<A
href="mailto:sean.hefty@intel.com">mailto:sean.hefty@intel.com</A>]<BR>Sent:
Wednesday, September 23, 2009 9:03 PM<BR>To: Tzachi Dar;
ofw@lists.openfabrics.org<BR>Subject: RE: patch: Support APM on IBAL
code<BR><BR>Is there any way to generate the patches, so we can see the
function name that the changes belong to?<BR><FONT color=#ff0000 size=3>I
guess there is, but if someone can tell me how to do it, I'll be happy to do
it next time.</FONT><BR><BR>>2) when sending LAP, there are two
parameters for the path record: one<BR>>is the src port that is based on
the av that I'm now loading. The<BR>>second is the dest_lid which is
based on the value that we have on
our<BR>>p_cep->av[p_cep-<BR>>>idx_primary]. I'm not sure if this
is the design, or is this just a<BR>>>bug and<BR>>the dest_lid
should also be taken from the av that is currently being
supplied.<BR><BR>I'm not familiar enough with the code to follow this
closely. When sending a LAP, I would expect the current primary path
to be used.<BR><FONT size=3><FONT color=#ff0000>This is probably what
happens. The path used is the alternate path that was loaded one time
before. There have been a migration so this is now the primary
path.</FONT><BR></FONT>><BR>>+<BR>>+//????????????<BR><BR>please
remove<BR><BR>>@@ -4731,6 +4731,12 @@<BR>>
break;<BR>> }<BR>><BR>>+
if(p_cm_req->h_qp->type == IB_QPT_RELIABLE_CONN)
{<BR>>+ ((al_conn_qp_t *)(p_cm_req->h_qp))->cid =
cid; }<BR><BR>Why limit setting this to RC QPs, versus all
QPs?<BR><BR>>@@ -5424,7 +5430,7 @@<BR>><BR>>
__format_mad_hdr( p_mad->p_mad_buf, p_cep, CM_LAP_ATTR_ID
);<BR>><BR>>- __format_mad_av( p_mad,
&p_cep->av[p_cep->idx_primary] );<BR>>+ __format_mad_av( p_mad,
&p_cep->av[((p_cep->idx_primary + 1) & 0x1)]<BR>>+
);<BR><BR>Does this end up sending the LAP on the primary path, or the new
alternate path?<BR><FONT color=#ff0000 size=3>I'll double check this, Very
likely that now the new path is used. I'll look at making sure that the
current primary path is indeed
used.</FONT><BR><BR></FONT></P></BLOCKQUOTE></BLOCKQUOTE></BODY></HTML>