<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Ahh, ok. Ignoring the addresses if there are more than one
seems like the right thing to do then, at least for the time being.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>-Fab<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Alex Naslednikov
[mailto:xalex@mellanox.co.il] <br>
<b>Sent:</b> Tuesday, August 31, 2010 12:05 AM<br>
<b>To:</b> Fab Tillier; Tzachi Dar; Hefty, Sean; ofw@lists.openfabrics.org<br>
<b>Subject:</b> RE: [ofw] [Patch][ipoib][ipoib_NDIS6_CM] Fixing a bug when
OID_GEN_NETWORK_LAYER_ADDRESSES contains bad data<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p><span style='font-size:10.0pt'>The original patch did this, but put
attention that it looks like the second NETWORK_ADDRESS structure overrides the
first one, i.e. ALL the data are corrupted</span><o:p></o:p></p>
<p><span style='font-size:10.0pt'>See the data marked in red: 10 00 02 00 looks
like the the start of the second structure, and even the first address has gone
there.</span><o:p></o:p></p>
<p><span style='font-size:10.0pt'>I saw the same issue with 5 network
addresses, it looked like</span><o:p></o:p></p>
<p><span style='font-size:10.0pt'>10 00 02 00 XX 10 00 02 00 XX 10 00 02
00 XX 10 00 02 00 XX 10 00 02 00 XX </span><o:p></o:p></p>
<p><span style='font-size:10.0pt'>Instead of:</span><o:p></o:p></p>
<p><span style='font-size:10.0pt'>10 00 02 00 { IP address of 16 bytes} 10 00
02 00 { IP address of 16 bytes} 10 00 02 00 { IP address of 16 bytes} 10
00 02 00 { IP address of 16 bytes} </span><o:p></o:p></p>
<p> <o:p></o:p></p>
<p><span style='font-size:10.0pt'>4: kd> db 0xfffffa80`0c39f240<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f240 02
00 00 00 02 00 <span style='background:yellow;mso-highlight:yellow'>10 00-02 00
00 00 <span style='color:red'>10 00 02 00</span> ................<o:p></o:p></span></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt;background:yellow;
mso-highlight:yellow'>fffffa80`<span style='color:red'>0c39f250 0c 7f 00
00 10 04 0c 7f-00 00</span></span><span style='font-size:10.0pt'> 00 00 00 00
00 00 ................<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f260 00
00 00 00 00 00 00 00-00 00 00 00 00 00 70 9f ..............p.<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f270 04
00 08 02 45 76 65 ee-b4 05 00 00 b8 0b 00 00 ....Eve.........<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f280 00
00 00 00 70 00 00 00-00 00 00 00 00 00 00 00 ....p...........<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f290 00
00 00 00 00 00 00 00-00 00 00 00 00 00 00 00 ................<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f2a0 01
00 00 00 00 00 00 00-01 00 00 00 00 00 00 00 ................<o:p></o:p></span></p>
<p class=MsoPlainText><span style='font-size:10.0pt'>fffffa80`0c39f2b0 00
00 00 00 00 00 00 00-0c 00 08 00 00 00 00 00 ................<br>
<br>
<br>
-----Original Message-----<br>
From: Fab Tillier [<a href="mailto:ftillier@microsoft.com">mailto:ftillier@microsoft.com</a>]<br>
Sent: Monday, August 30, 2010 9:56 PM<br>
To: Tzachi Dar; Alex Naslednikov; Hefty, Sean; ofw@lists.openfabrics.org<br>
Subject: RE: [ofw] [Patch][ipoib][ipoib_NDIS6_CM] Fixing a bug when
OID_GEN_NETWORK_LAYER_ADDRESSES contains bad data<br>
<br>
Thanks for sending this Tzachi, we're looking into it.<br>
<br>
Tzachi Dar wrote on Mon, 30 Aug 2010 at 01:31:22<br>
<br>
> On a more practical approach (assuming there is no fix in the short<br>
> term) I suggest that on windows 2008 R2 we will not try to parse this<br>
> structure if it contains more than one element. Please note that this<br>
> means that ND will not work on such machines (with more than one ip<br>
> address per interface).<br>
<br>
Why not just only parse the first address only?<br>
<br>
-Fab<o:p></o:p></span></p>
</div>
</body>
</html>