<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928"></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=292501416-01092010><FONT color=#0000ff
size=2 face=Arial>The first patch you supplied has this removal, the 2nd patch
did not. When I checked the patch in I removed the
ASSERT(FALSE).</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=292501416-01092010><FONT color=#0000ff
size=2 face=Arial>Please note the line number in your patch is 4607, the same
line is @ 4671.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=292501416-01092010><FONT color=#0000ff
size=2 face=Arial>Why is there such a skew?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=292501416-01092010><FONT color=#0000ff
size=2 face=Arial>Is there a problem sending me your version of
ipoib_port.cpp?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=292501416-01092010><FONT color=#0000ff
size=2 face=Arial></FONT></SPAN> </DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Alex
Naslednikov<BR><B>Sent:</B> Wednesday, September 01, 2010 7:15 AM<BR><B>To:</B>
ofw@lists.openfabrics.org<BR><B>Subject:</B> [ofw] [Patch] [IPoIB_NDIS6_CM]
Remove wrong ASSERT<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV>
<P><FONT face=Arial><FONT size=2>The ASSERT assume that we never get a DHCP
DISCOVERY msg with local MAC<SPAN class=370061314-01092010>, while the original
meaning was</SPAN></FONT></FONT></P>
<P><FONT face=Arial><FONT size=2><SPAN class=370061314-01092010>not to get
DHCP_INFORM message with non-local MAD.</SPAN></FONT></FONT></P>
<P><FONT face=Arial><FONT size=2><SPAN class=370061314-01092010>Signed-Off by:
Uri Habusha (urih at mellanox.co.il)</SPAN></FONT></FONT></P>
<P><FONT size=2 face=Arial>Index:
B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp<BR>===================================================================<BR>---
B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (revision
6300)<BR>+++
B:/users/xalex/MLNX_WinOF-2_1_2/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (revision
6301)<BR>@@ -4607,7 +4607,6 @@<BR> if( p_cid[1] ==
HW_ADDR_LEN+1 && !cl_memcmp(
&p_cid[3],<BR> &s_buf->p_port->p_adapter->params.conf_mac.addr,
HW_ADDR_LEN ) )<BR> {<BR>- ASSERT(
FALSE );<BR> /* Make sure there's room to extend
it. 22 is the size of<BR> * the CID option
for IPoIB. (20 is the length, one byte for type and the second for lenght
field)<BR> */</FONT></P></DIV></BODY></HTML>