<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML xmlns="http://www.w3.org/TR/REC-html40" xmlns:v =
"urn:schemas-microsoft-com:vml" xmlns:o =
"urn:schemas-microsoft-com:office:office" xmlns:w =
"urn:schemas-microsoft-com:office:word" xmlns:x =
"urn:schemas-microsoft-com:office:excel" xmlns:p =
"urn:schemas-microsoft-com:office:powerpoint" xmlns:a =
"urn:schemas-microsoft-com:office:access" xmlns:dt =
"uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s =
"uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs =
"urn:schemas-microsoft-com:rowset" xmlns:z = "#RowsetSchema" xmlns:b =
"urn:schemas-microsoft-com:office:publisher" xmlns:ss =
"urn:schemas-microsoft-com:office:spreadsheet" xmlns:c =
"urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc =
"urn:schemas-microsoft-com:office:odc" xmlns:oa =
"urn:schemas-microsoft-com:office:activation" xmlns:html =
"http://www.w3.org/TR/REC-html40" xmlns:q =
"http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc =
"http://microsoft.com/officenet/conferencing" XMLNS:D = "DAV:" XMLNS:Repl =
"http://schemas.microsoft.com/repl/" xmlns:mt =
"http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2 =
"http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda =
"http://www.passport.com/NameSpace.xsd" xmlns:ois =
"http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir =
"http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds =
"http://www.w3.org/2000/09/xmldsig#" xmlns:dsp =
"http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc =
"http://schemas.microsoft.com/data/udc" xmlns:xsd =
"http://www.w3.org/2001/XMLSchema" xmlns:sub =
"http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec =
"http://www.w3.org/2001/04/xmlenc#" xmlns:sp =
"http://schemas.microsoft.com/sharepoint/" xmlns:sps =
"http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi =
"http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs =
"http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf =
"http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p =
"http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf =
"http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss =
"http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi =
"http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi =
"http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver =
"http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m =
"http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels =
"http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp =
"http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t =
"http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m =
"http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl =
"http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl =
"http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService"
XMLNS:Z = "urn:schemas-microsoft-com:" xmlns:st = ""><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE>@font-face {
font-family: Calibri;
}
@page Section1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.EmailStyle17 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; mso-style-type: personal-compose
}
.MsoChpDefault {
mso-style-type: export-only
}
DIV.Section1 {
page: Section1
}
</STYLE>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></HEAD>
<BODY lang=EN-US link=blue vLink=purple>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>Hi Leo,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial> The patch looks reasonable.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>One question, why is it that when creating a QP, both a send
and recv CQs are required? Otherwise the create QP call
fails.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>Why is not possible to have a send-only QP or a receive only
QP?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>How do you suggest to program around this QP creation
limitation?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>thanks,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=633442515-15102010><FONT color=#0000ff
size=2 face=Arial>stan.</FONT></SPAN></DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Leonid
Keller<BR><B>Sent:</B> Wednesday, October 13, 2010 11:56 AM<BR><B>To:</B>
'ofw@lists.openfabrics.org'<BR><B>Subject:</B> [ofw] [patch][IBAL] move sanity
checks to the beginning of the function to prevent crash.<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV class=Section1>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">create_qp() first creates
some basic QP, then adds QP_type specific functionality.<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">But before that it makes
some sanity checks.<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">If
one of CQ handles is incorrect create_qp() exits from switch and performs
destroy QP which crashes for RC QP<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">in
destroy_cep because the latter presumes that QP as al_object is attached to
AL.<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">But al_attach is called
from raw_qp() which is called from specific actions which was never
called.<o:p></o:p></SPAN></P>
<P class=MsoNormal><o:p> </o:p></P>
<P class=MsoNormal><o:p> </o:p></P>
<P class=MsoNormal><o:p> </o:p></P>
<P class=MsoNormal>Index: core/al/al_qp.c<o:p></o:p></P>
<P
class=MsoNormal>===================================================================<o:p></o:p></P>
<P class=MsoNormal>---
core/al/al_qp.c
(revision 2969)<o:p></o:p></P>
<P class=MsoNormal>+++ core/al/al_qp.c
(working copy)<o:p></o:p></P>
<P class=MsoNormal>@@ -302,6 +302,45 @@<o:p></o:p></P>
<P
class=MsoNormal>
AL_PRINT_EXIT( TRACE_LEVEL_ERROR, AL_DBG_ERROR, ("IB_INVALID_SRQ_HANDLE\n")
);<o:p></o:p></P>
<P
class=MsoNormal>
return IB_INVALID_SRQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>
}<o:p></o:p></P>
<P class=MsoNormal>+<o:p></o:p></P>
<P
class=MsoNormal>+
switch( p_qp_create->qp_type )<o:p></o:p></P>
<P
class=MsoNormal>+
{<o:p></o:p></P>
<P
class=MsoNormal>+
case IB_QPT_RELIABLE_CONN:<o:p></o:p></P>
<P
class=MsoNormal>+
case IB_QPT_UNRELIABLE_CONN:<o:p></o:p></P>
<P
class=MsoNormal>+
if( AL_OBJ_INVALID_HANDLE( p_qp_create->h_sq_cq, AL_OBJ_TYPE_H_CQ ) ||<SPAN
class=633442515-15102010><FONT color=#0000ff size=2
face=Arial> <========
requires both Tx & Rx CQs? </FONT></SPAN><o:p></o:p></P>
<P
class=MsoNormal>+
AL_OBJ_INVALID_HANDLE( p_qp_create->h_rq_cq, AL_OBJ_TYPE_H_CQ )
)<o:p></o:p></P>
<P
class=MsoNormal>+
{<o:p></o:p></P>
<P
class=MsoNormal>+
AL_PRINT_EXIT( TRACE_LEVEL_ERROR, AL_DBG_ERROR, ("IB_INVALID_CQ_HANDLE\n")
);<o:p></o:p></P>
<P
class=MsoNormal>+
return IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>+
}<o:p></o:p></P>
<P
class=MsoNormal>+
break;<o:p></o:p></P>
<P class=MsoNormal>+<o:p></o:p></P>
<P
class=MsoNormal>+
case IB_QPT_UNRELIABLE_DGRM:<o:p></o:p></P>
<P
class=MsoNormal>+
if( AL_OBJ_INVALID_HANDLE( p_qp_create->h_sq_cq, AL_OBJ_TYPE_H_CQ )
||<o:p></o:p></P>
<P
class=MsoNormal>+
AL_OBJ_INVALID_HANDLE( p_qp_create->h_rq_cq, AL_OBJ_TYPE_H_CQ )
)<o:p></o:p></P>
<P
class=MsoNormal>+
{<o:p></o:p></P>
<P
class=MsoNormal>+
AL_PRINT_EXIT( TRACE_LEVEL_ERROR, AL_DBG_ERROR, ("IB_INVALID_CQ_HANDLE\n")
);<o:p></o:p></P>
<P
class=MsoNormal>+
return IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>+
}<o:p></o:p></P>
<P
class=MsoNormal>+
break;<o:p></o:p></P>
<P class=MsoNormal>+<o:p></o:p></P>
<P
class=MsoNormal>+
case IB_QPT_MAD:<o:p></o:p></P>
<P
class=MsoNormal>+
if( p_qp_create->h_sq_cq || p_qp_create->h_rq_cq )<o:p></o:p></P>
<P
class=MsoNormal>+
{<o:p></o:p></P>
<P
class=MsoNormal>+
AL_PRINT_EXIT( TRACE_LEVEL_ERROR, AL_DBG_ERROR, ("IB_INVALID_CQ_HANDLE\n")
);<o:p></o:p></P>
<P
class=MsoNormal>+
return IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>+
}<o:p></o:p></P>
<P
class=MsoNormal>+
break;<o:p></o:p></P>
<P class=MsoNormal>+<o:p></o:p></P>
<P
class=MsoNormal>+
default:<o:p></o:p></P>
<P
class=MsoNormal>+
CL_ASSERT( p_qp_create->qp_type == IB_QPT_RELIABLE_CONN ||<o:p></o:p></P>
<P
class=MsoNormal>+
p_qp_create->qp_type == IB_QPT_UNRELIABLE_CONN ||<o:p></o:p></P>
<P
class=MsoNormal>+
p_qp_create->qp_type == IB_QPT_UNRELIABLE_DGRM ||<o:p></o:p></P>
<P
class=MsoNormal>+
p_qp_create->qp_type == IB_QPT_MAD );<o:p></o:p></P>
<P
class=MsoNormal>+
AL_PRINT_EXIT( TRACE_LEVEL_ERROR, AL_DBG_ERROR, ("IB_INVALID_SETTING\n")
);<o:p></o:p></P>
<P
class=MsoNormal>+
return IB_INVALID_SETTING;<o:p></o:p></P>
<P
class=MsoNormal>+
}<o:p></o:p></P>
<P class=MsoNormal>+<o:p></o:p></P>
<P
class=MsoNormal>
<o:p></o:p></P>
<P
class=MsoNormal>
/* Allocate a QP. */<o:p></o:p></P>
<P
class=MsoNormal>
status = alloc_qp( p_qp_create->qp_type, &h_qp );<o:p></o:p></P>
<P class=MsoNormal>@@ -320,42 +359,17 @@<o:p></o:p></P>
<P
class=MsoNormal>
{<o:p></o:p></P>
<P
class=MsoNormal>
case IB_QPT_RELIABLE_CONN:<o:p></o:p></P>
<P
class=MsoNormal>
case IB_QPT_UNRELIABLE_CONN:<o:p></o:p></P>
<P
class=MsoNormal>-
if( AL_OBJ_INVALID_HANDLE( p_qp_create->h_sq_cq, AL_OBJ_TYPE_H_CQ )
||<o:p></o:p></P>
<P
class=MsoNormal>-
AL_OBJ_INVALID_HANDLE( p_qp_create->h_rq_cq, AL_OBJ_TYPE_H_CQ )
)<o:p></o:p></P>
<P
class=MsoNormal>-
{<o:p></o:p></P>
<P
class=MsoNormal>-
status = IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>-
break;<o:p></o:p></P>
<P
class=MsoNormal>-
}<o:p></o:p></P>
<P
class=MsoNormal>
status = init_conn_qp( (al_conn_qp_t*)h_qp, h_pd, p_qp_create, p_umv_buf
);<o:p></o:p></P>
<P
class=MsoNormal>
break;<o:p></o:p></P>
<P class=MsoNormal> <o:p></o:p></P>
<P
class=MsoNormal>
case IB_QPT_UNRELIABLE_DGRM:<o:p></o:p></P>
<P
class=MsoNormal>-
if( AL_OBJ_INVALID_HANDLE( p_qp_create->h_sq_cq, AL_OBJ_TYPE_H_CQ )
||<o:p></o:p></P>
<P
class=MsoNormal>-
AL_OBJ_INVALID_HANDLE( p_qp_create->h_rq_cq, AL_OBJ_TYPE_H_CQ )
)<o:p></o:p></P>
<P
class=MsoNormal>-
{<o:p></o:p></P>
<P
class=MsoNormal>-
status = IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>-
break;<o:p></o:p></P>
<P
class=MsoNormal>-
}<o:p></o:p></P>
<P
class=MsoNormal>
status = init_dgrm_qp( (al_dgrm_qp_t*)h_qp, h_pd, p_qp_create, p_umv_buf
);<o:p></o:p></P>
<P
class=MsoNormal>
break;<o:p></o:p></P>
<P class=MsoNormal> <o:p></o:p></P>
<P
class=MsoNormal>
case IB_QPT_MAD:<o:p></o:p></P>
<P
class=MsoNormal>-
if( p_qp_create->h_sq_cq || p_qp_create->h_rq_cq )<o:p></o:p></P>
<P
class=MsoNormal>-
{<o:p></o:p></P>
<P
class=MsoNormal>-
status = IB_INVALID_CQ_HANDLE;<o:p></o:p></P>
<P
class=MsoNormal>-
break;<o:p></o:p></P>
<P
class=MsoNormal>-
}<o:p></o:p></P>
<P
class=MsoNormal>
status = init_mad_qp( (al_mad_qp_t*)h_qp, h_pd, p_qp_create,<o:p></o:p></P>
<P
class=MsoNormal>
pfn_qp_event_cb );<o:p></o:p></P>
<P
class=MsoNormal>
break;<o:p></o:p></P>
<P class=MsoNormal>-<o:p></o:p></P>
<P
class=MsoNormal>-
default:<o:p></o:p></P>
<P
class=MsoNormal>-
CL_ASSERT( h_qp->type == IB_QPT_RELIABLE_CONN ||<o:p></o:p></P>
<P
class=MsoNormal>-
h_qp->type == IB_QPT_UNRELIABLE_CONN ||<o:p></o:p></P>
<P
class=MsoNormal>-
h_qp->type == IB_QPT_UNRELIABLE_DGRM ||<o:p></o:p></P>
<P
class=MsoNormal>-
h_qp->type == IB_QPT_MAD );<o:p></o:p></P>
<P
class=MsoNormal>-
status = IB_INVALID_SETTING;<o:p></o:p></P>
<P
class=MsoNormal>-
break;<o:p></o:p></P>
<P
class=MsoNormal>
}<o:p></o:p></P>
<P class=MsoNormal> <o:p></o:p></P>
<P
class=MsoNormal>
if( status != IB_SUCCESS )<o:p></o:p></P></DIV></BODY></HTML>