<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal><span style='color:#1F497D'>Seems like you included the
wrong patch?<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>
ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b>On
Behalf Of </b>Alex Naslednikov<br>
<b>Sent:</b> Wednesday, November 10, 2010 7:11 AM<br>
<b>To:</b> ofw@lists.openfabrics.org<br>
<b>Subject:</b> [ofw] [Patch][IPoIB_NDIS6_CM] Recv shutter fix when init
process fails<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>This patch fix the situation when init process fails (say,
__ib_mgr_init fails) and then ipoib_restart is called.<o:p></o:p></p>
<p class=MsoNormal>Shutter is shut first time at the end of the init
process. Thus, if init will fail, shutter will be never shut,<o:p></o:p></p>
<p class=MsoNormal>while ipoib_restart will try to alive such shutter.<o:p></o:p></p>
<p class=MsoNormal>Signed-off by: Alexander Naslednikov (xalex at
mellanox.co.il)<o:p></o:p></p>
<p class=MsoNormal>Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp<o:p></o:p></p>
<p class=MsoNormal>===================================================================<o:p></o:p></p>
<p class=MsoNormal>--- ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
(revision 2986)<o:p></o:p></p>
<p class=MsoNormal>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
(working copy)<o:p></o:p></p>
<p class=MsoNormal>@@ -1110,10 +1110,23 @@<o:p></o:p></p>
<p class=MsoNormal>
qp_create.rq_sge = 2; /* To support buffers spanning pages. */<o:p></o:p></p>
<p class=MsoNormal>
qp_create.h_rq_cq = p_port->ib_mgr.h_recv_cq;<o:p></o:p></p>
<p class=MsoNormal>
qp_create.sq_depth = p_port->p_adapter->params.sq_depth;<o:p></o:p></p>
<p class=MsoNormal>-<o:p></o:p></p>
<p class=MsoNormal>+
<o:p></o:p></p>
<p class=MsoNormal>+
// p_ca_attrs->max_sges contains the maximum number of SG elements <o:p></o:p></p>
<p class=MsoNormal>+
// available by HW. 3 of the them are reserved for an internal use<o:p></o:p></p>
<p class=MsoNormal>+
// Thus, the maximum of SGE for UD QP is limited by (p_ca_attrs->max_sges -
3)<o:p></o:p></p>
<p class=MsoNormal> #define UD_QP_USED_SGE 3<o:p></o:p></p>
<p class=MsoNormal>-
qp_create.sq_sge = MAX_SEND_SGE < p_port->p_ca_attrs->max_sges ? <o:p></o:p></p>
<p class=MsoNormal>-
MAX_SEND_SGE : ( p_port->p_ca_attrs->max_sges - UD_QP_USED_SGE );<o:p></o:p></p>
<p class=MsoNormal>+
if ( p_port->p_ca_attrs->max_sges > MAX_SEND_SGE )<o:p></o:p></p>
<p class=MsoNormal>+
{<o:p></o:p></p>
<p class=MsoNormal>+
p_port->max_sq_sge_supported = MAX_SEND_SGE - UD_QP_USED_SGE;<o:p></o:p></p>
<p class=MsoNormal>+
}<o:p></o:p></p>
<p class=MsoNormal>+
else <o:p></o:p></p>
<p class=MsoNormal>+
{<o:p></o:p></p>
<p class=MsoNormal>+
p_port->max_sq_sge_supported = p_port->p_ca_attrs->max_sges -
UD_QP_USED_SGE;<o:p></o:p></p>
<p class=MsoNormal>+
}<o:p></o:p></p>
<p class=MsoNormal>+
<o:p></o:p></p>
<p class=MsoNormal>+
p_port->p_ca_attrs->max_sges -= UD_QP_USED_SGE;<o:p></o:p></p>
<p class=MsoNormal>+
qp_create.sq_sge = p_port->max_sq_sge_supported;<o:p></o:p></p>
<p class=MsoNormal>+
<o:p></o:p></p>
<p class=MsoNormal>
if ( !p_port->p_ca_attrs->ipoib_csum ) <o:p></o:p></p>
<p class=MsoNormal>
{ <o:p></o:p></p>
<p class=MsoNormal>
/* checksum is not supported by device<o:p></o:p></p>
<p class=MsoNormal>@@ -1162,6 +1175,11 @@<o:p></o:p></p>
<p class=MsoNormal>
p_port->p_adapter->p_ifc->get_err_str( status )) );<o:p></o:p></p>
<p class=MsoNormal>
return status;<o:p></o:p></p>
<p class=MsoNormal>
}<o:p></o:p></p>
<p class=MsoNormal>+
if ( qp_attr.sq_sge < qp_create.sq_sge) <o:p></o:p></p>
<p class=MsoNormal>+
{<o:p></o:p></p>
<p class=MsoNormal>+
ASSERT ( FALSE );<o:p></o:p></p>
<p class=MsoNormal>+
p_port->max_sq_sge_supported = qp_attr.sq_sge;<o:p></o:p></p>
<p class=MsoNormal>+
}<o:p></o:p></p>
<p class=MsoNormal>
p_port->ib_mgr.qpn = qp_attr.num;<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>
/* Register all of physical memory */<o:p></o:p></p>
<p class=MsoNormal>@@ -3799,7 +3817,7 @@<o:p></o:p></p>
<p class=MsoNormal>
}<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>
/* Remember that one of the DS entries is reserved for the IPoIB header. */<o:p></o:p></p>
<p class=MsoNormal>-
if( num_pages >= MAX_SEND_SGE )<o:p></o:p></p>
<p class=MsoNormal>+
if( num_pages >= p_port->max_sq_sge_supported )<o:p></o:p></p>
<p class=MsoNormal>
{<o:p></o:p></p>
<p class=MsoNormal>
IPOIB_PRINT(TRACE_LEVEL_INFORMATION, IPOIB_DBG_SEND,<o:p></o:p></p>
<p class=MsoNormal>
("Too many buffers to fit in WR ds_array. Copying data.\n") );<o:p></o:p></p>
<p class=MsoNormal>@@ -4270,13 +4288,14 @@<o:p></o:p></p>
<p class=MsoNormal>
Copy only N+1-MAX_SEND_SGE, where N is a lenght of SG List<o:p></o:p></p>
<p class=MsoNormal>
Remember that one of the DS entries is reserved for the IPoIB
header.<o:p></o:p></p>
<p class=MsoNormal>
*/<o:p></o:p></p>
<p class=MsoNormal>-
if( ( p_sgl->NumberOfElements >= MAX_SEND_SGE ||<o:p></o:p></p>
<p class=MsoNormal>+
if( ( p_sgl->NumberOfElements >= s_buf->p_port->max_sq_sge_supported
||<o:p></o:p></p>
<p class=MsoNormal>
p_sgl->Elements[0].Length < sizeof(eth_hdr_t)) )<o:p></o:p></p>
<p class=MsoNormal>
{<o:p></o:p></p>
<p class=MsoNormal>
IPOIB_PRINT( TRACE_LEVEL_WARNING, IPOIB_DBG_SEND,<o:p></o:p></p>
<p class=MsoNormal>
("Too many buffers %d to fit in WR ds_array[%d] \<o:p></o:p></p>
<p class=MsoNormal>
Or buffer[0] length %d < Eth header. Copying data.\n",<o:p></o:p></p>
<p class=MsoNormal>-
p_sgl->NumberOfElements, MAX_SEND_SGE, p_sgl->Elements[0].Length ) );<o:p></o:p></p>
<p class=MsoNormal>+
p_sgl->NumberOfElements, s_buf->p_port->max_sq_sge_supported , <o:p></o:p></p>
<p class=MsoNormal>+
p_sgl->Elements[0].Length ) );<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>
if( !s_buf->p_port->p_adapter->params.cm_enabled )<o:p></o:p></p>
<p class=MsoNormal>
{<o:p></o:p></p>
<p class=MsoNormal>Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_port.h<o:p></o:p></p>
<p class=MsoNormal>===================================================================<o:p></o:p></p>
<p class=MsoNormal>---
ulp/ipoib_NDIS6_CM/kernel/ipoib_port.h (revision 2982)<o:p></o:p></p>
<p class=MsoNormal>+++ ulp/ipoib_NDIS6_CM/kernel/ipoib_port.h (working
copy)<o:p></o:p></p>
<p class=MsoNormal>@@ -590,6 +590,7 @@<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>
struct _ipoib_adapter *p_adapter;<o:p></o:p></p>
<p class=MsoNormal>
uint8_t
port_num;<o:p></o:p></p>
<p class=MsoNormal>+
uint32_t
max_sq_sge_supported; <o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>
KEVENT
sa_event;<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal>@@ -653,6 +654,9 @@<o:p></o:p></p>
<p class=MsoNormal> *
port_num<o:p></o:p></p>
<p class=MsoNormal> *
Port number of this adapter.<o:p></o:p></p>
<p class=MsoNormal> *<o:p></o:p></p>
<p class=MsoNormal>+*
max_sq_sge_supported<o:p></o:p></p>
<p class=MsoNormal>+*
Maximum number of send QP SG elements supported by HW<o:p></o:p></p>
<p class=MsoNormal>+*<o:p></o:p></p>
<p class=MsoNormal> *
ib_mgr<o:p></o:p></p>
<p class=MsoNormal> *
IB resource manager.<o:p></o:p></p>
<p class=MsoNormal> *<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p>
<p class=MsoNormal><b>SW Networking Team<o:p></o:p></b></p>
<p class=MsoNormal><b>Mellanox Technologies<o:p></o:p></b></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>