<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='color:#1F497D'>Thank you.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>I applied this patch at 2987 with
small change at __ipoib_init() function:<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>It can be called also from
ipoib_pnp_cb() during reset process.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Thus, instead of <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><b><i><span style='color:#1F497D'>
ASSERT( p_adapter->ipoib_state == IPOIB_UNINIT );<o:p></o:p></span></i></b></p>
<p class=MsoNormal><b><i><span style='color:#1F497D'>
p_adapter->ipoib_state = IPOIB_INIT;<o:p></o:p></span></i></b></p>
<p class=MsoNormal><b><i><span style='color:#1F497D'>
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_SHUTTER,<o:p></o:p></span></i></b></p>
<p class=MsoNormal><b><i><span style='color:#1F497D'>
("Shutter shut, state = %d\n", p_adapter->ipoib_state));<o:p></o:p></span></i></b></p>
<p class=MsoNormal><b><i><span style='color:#1F497D'>
shutter_shut ( &p_adapter->recv_shutter );<o:p></o:p></span></i></b></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>The following code should be:<o:p></o:p></span></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>if
( p_adapter->ipoib_state == IPOIB_UNINIT ) <o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>{<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> p_adapter->ipoib_state
= IPOIB_INIT;<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> IPOIB_PRINT(
TRACE_LEVEL_INFORMATION, IPOIB_DBG_SHUTTER,<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> ("Shutter
shut, state = %d\n", p_adapter->ipoib_state));<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> shutter_shut
( &p_adapter->recv_shutter );<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>}
<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>else
<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>{<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> IPOIB_PRINT(
TRACE_LEVEL_INFORMATION, IPOIB_DBG_SHUTTER,<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'> ("Shutter
wasn't shut, state = %d\n", p_adapter->ipoib_state));<o:p></o:p></span></i></b></p>
<p class=MsoNormal style='margin-left:.5in'><b><i><span style='color:#1F497D'>}<o:p></o:p></span></i></b></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Smith, Stan
[mailto:stan.smith@intel.com] <br>
<b>Sent:</b> Thursday, November 11, 2010 9:20 PM<br>
<b>To:</b> Alex Naslednikov; Fab Tillier; ofw@lists.openfabrics.org<br>
<b>Subject:</b> RE: [ofw] [Patch][IPoIB_NDIS6_CM] Recv shutter fix when init
process fails<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:blue'>Hello,</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:blue'> Patch applies OK.</span><span style='font-size:12.0pt;
font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:blue'>No observed problems in regression testing: dapl, ftp,
disable/enable, shutdown, uninstall.</span><span style='font-size:12.0pt;
font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:blue'>Thumbs-up!</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'> <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:blue'>stan.</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p> </o:p></span></p>
<div class=MsoNormal align=center style='text-align:center'><span
style='font-size:12.0pt;font-family:"Times New Roman","serif"'>
<hr size=2 width="100%" align=center>
</span></div>
<p class=MsoNormal style='margin-bottom:12.0pt'><b><span style='font-size:10.0pt;
font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;
font-family:"Tahoma","sans-serif"'> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <b>On Behalf Of </b>Alex Naslednikov<br>
<b>Sent:</b> Thursday, November 11, 2010 5:18 AM<br>
<b>To:</b> Fab Tillier; ofw@lists.openfabrics.org<br>
<b>Subject:</b> Re: [ofw] [Patch][IPoIB_NDIS6_CM] Recv shutter fix when init
process fails</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>You are right.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Please, find attached the
correct patch<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Index:
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>--- ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp
(revision 2986)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp
(working copy)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>@@ -429,7 +429,8 @@<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
p_adapter->p_ifc->get_err_str( status )) );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
return status;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
p_adapter->ipoib_state = IPOIB_UNINIT;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_INIT,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
("Shutter Init, state = %d\n", p_adapter->ipoib_state) );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_RECV,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Index:
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.h<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>---
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.h
(revision 2986)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.h
(working copy)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>@@ -71,6 +71,7 @@<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> } csum_flag_t;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> typedef
uint32_t ipoib_state_t;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+#define
IPOIB_UNINIT
0<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> #define
IPOIB_INIT
1<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> #define
IPOIB_PAUSED
2<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> #define
IPOIB_PAUSING
4<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>---
ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp
(revision 2986)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp
(working copy)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>@@ -1880,9 +1880,6 @@<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
("ipoib_create_adapter returned status %d.\n", ib_status ) );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
return NDIS_STATUS_FAILURE;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
p_adapter->ipoib_state = IPOIB_INIT;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_SHUTTER,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
("ipoib_state changed to IPOIB_INIT\n") );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
status = SetAttributes(p_adapter, h_adapter);<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
if (status != NDIS_STATUS_SUCCESS) {<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Index:
ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>--- ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
(revision 2986)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp
(working copy)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>@@ -849,15 +849,12 @@<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
V. NDIS calls
to ipoib_restart that calls to shutter_alive. Shutter counter is 0 and we can
start working<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
*/<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
if ( p_adapter->ipoib_state == IPOIB_INIT) {<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_RECV,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
ASSERT( p_adapter->ipoib_state == IPOIB_UNINIT );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
p_adapter->ipoib_state = IPOIB_INIT;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
IPOIB_PRINT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_SHUTTER,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
("Shutter shut, state = %d\n", p_adapter->ipoib_state));<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
shutter_shut ( &p_adapter->recv_shutter );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
else {<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
IPOIB_PRINT( TRACE_LEVEL_WARNING, IPOIB_DBG_RECV,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
("*****Shutter wasn't shut, state = %d*****\n", p_adapter->ipoib_state));<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>-
}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
shutter_shut ( &p_adapter->recv_shutter );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
IPOIB_EXIT( IPOIB_DBG_INIT );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
return IB_SUCCESS;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> }<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Fab Tillier
[mailto:ftillier@microsoft.com] <br>
<b>Sent:</b> Wednesday, November 10, 2010 7:21 PM<br>
<b>To:</b> Alex Naslednikov; ofw@lists.openfabrics.org<br>
<b>Subject:</b> RE: [ofw] [Patch][IPoIB_NDIS6_CM] Recv shutter fix when init
process fails<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span style='color:#1F497D'>Seems like you included the
wrong patch?<o:p></o:p></span></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p>
<p class=MsoNormal><b>SW Networking Team<o:p></o:p></b></p>
<p class=MsoNormal><b>Mellanox Technologies<o:p></o:p></b></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>