<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>The purpose of __ipoib_complete_reset() is to send
to NDIS async compete on reset process accomplishment and set
“p_adapter->reset = FALSE”;<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>But __ipoib_complete_reset() can be called
independently from several async threads (i.e. running in parallel), where the
main of them are:<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>1. __ipoib_adapter_reset()<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>2. Ipoib_pnp_cb()<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>It seems like bug, but:<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>1. We check for adapter state within
__ipoib_complete_reset() . This is to sync between NDIS and IBAL async PNP
events !<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>2. According to the status, we have 2
possibilites:<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:.5in;text-autospace:none'><span
style='font-size:8.5pt;font-family:"Courier New"'>a. State == IB_PNP_PORT_REMOVE
- than complete the reset now (and ASSERT(p_adapter->reset == TRUE) should
be true there))<o:p></o:p></span></p>
<p class=MsoNormal style='text-indent:.5in;text-autospace:none'><span
style='font-size:8.5pt;font-family:"Courier New"'>b. Otherwise
(IB_PNP_PORT_ADD), register back to pnp events<o:p></o:p></span></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:.5in;text-autospace:
none'><span style='font-size:8.5pt;font-family:"Courier New"'>i. If
succeed, do not complete reset here - reset process will be completed by
ipoib_pnp_cb() thread.<o:p></o:p></span></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:.5in;text-autospace:
none'><span style='font-size:8.5pt;font-family:"Courier New"'>ii. If not,
reset process will be completed now (ASSERT(p_adapter->reset == TRUE) should
be true there)<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>How it can happen ?<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:8.5pt;
font-family:"Courier New"'>NDIS detected checked_for_hung while IPoIB get
PORT_DOWN/UP pnp events<o:p></o:p></span></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Signed-off by: Alexander Naslednikov (xalex at
mellanox.co.il)<o:p></o:p></p>
<p class=MsoNormal>Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp<o:p></o:p></p>
<p class=MsoNormal>===================================================================<o:p></o:p></p>
<p class=MsoNormal>--- ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (revision
2987)<o:p></o:p></p>
<p class=MsoNormal>+++ ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (working
copy)<o:p></o:p></p>
<p class=MsoNormal>@@ -1138,12 +1138,13 @@<o:p></o:p></p>
<p class=MsoNormal> <o:p></o:p></p>
<p class=MsoNormal> if( p_port )<o:p></o:p></p>
<p class=MsoNormal> ipoib_port_destroy( p_port
);<o:p></o:p></p>
<p class=MsoNormal>- ASSERT(p_adapter->reset == TRUE);<o:p></o:p></p>
<p class=MsoNormal>+ <o:p></o:p></p>
<p class=MsoNormal> if( state != IB_PNP_PORT_REMOVE )<o:p></o:p></p>
<p class=MsoNormal> {<o:p></o:p></p>
<p class=MsoNormal> status = __ipoib_pnp_reg(
p_adapter, IB_PNP_FLAG_REG_COMPLETE );<o:p></o:p></p>
<p class=MsoNormal> if( status != IB_SUCCESS )<o:p></o:p></p>
<p class=MsoNormal> {<o:p></o:p></p>
<p class=MsoNormal>+ ASSERT(p_adapter->reset
== TRUE);<o:p></o:p></p>
<p class=MsoNormal> IPOIB_PRINT(
TRACE_LEVEL_ERROR, IPOIB_DBG_ERROR,<o:p></o:p></p>
<p class=MsoNormal> ("__ipoib_pnp_reg
returned %s\n",<o:p></o:p></p>
<p class=MsoNormal> p_adapter->p_ifc->get_err_str(
status )) );<o:p></o:p></p>
<p class=MsoNormal>@@ -1152,6 +1153,7 @@<o:p></o:p></p>
<p class=MsoNormal> }<o:p></o:p></p>
<p class=MsoNormal> else<o:p></o:p></p>
<p class=MsoNormal> {<o:p></o:p></p>
<p class=MsoNormal>+ ASSERT(p_adapter->reset ==
TRUE);<o:p></o:p></p>
<p class=MsoNormal> __ipoib_complete_reset(
p_adapter, NDIS_STATUS_SUCCESS );<o:p></o:p></p>
<p class=MsoNormal> status = IB_SUCCESS;<o:p></o:p></p>
<p class=MsoNormal> }<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p>
<p class=MsoNormal><b>SW Networking Team<o:p></o:p></b></p>
<p class=MsoNormal><b>Mellanox Technologies<o:p></o:p></b></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>