<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML xmlns="http://www.w3.org/TR/REC-html40" xmlns:v =
"urn:schemas-microsoft-com:vml" xmlns:o =
"urn:schemas-microsoft-com:office:office" xmlns:w =
"urn:schemas-microsoft-com:office:word" xmlns:m =
"http://schemas.microsoft.com/office/2004/12/omml"><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE>@font-face {
font-family: Calibri;
}
@page Section1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.EmailStyle17 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; mso-style-type: personal-compose
}
.MsoChpDefault {
mso-style-type: export-only
}
DIV.Section1 {
page: Section1
}
</STYLE>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></HEAD>
<BODY lang=EN-US link=blue vLink=purple>
<DIV dir=ltr align=left><SPAN class=647195617-18112010><FONT color=#0000ff
size=2 face=Arial>Looks reasonable.</FONT></SPAN></DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ofw-bounces@lists.openfabrics.org
[mailto:ofw-bounces@lists.openfabrics.org] <B>On Behalf Of </B>Alex
Naslednikov<BR><B>Sent:</B> Wednesday, November 17, 2010 5:57 AM<BR><B>To:</B>
ofw@lists.openfabrics.org<BR><B>Subject:</B> [ofw] [Patch][IPoIB_NDIS6_CM] Reset
flow wrong assertion<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV class=Section1>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">The purpose of
__ipoib_complete_reset() is to send to NDIS async compete on reset process
accomplishment and set “p_adapter->reset = FALSE”;<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">But
__ipoib_complete_reset() can be called independently from several async
threads (i.e. running in parallel), where the main of them
are:<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">1.
__ipoib_adapter_reset()<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">2.
Ipoib_pnp_cb()<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">It
seems like bug, but:<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">1.
We check for adapter state within __ipoib_complete_reset() . This is to
sync between NDIS and IBAL async PNP events !<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">2.
According to the status, we have 2 possibilites:<o:p></o:p></SPAN></P>
<P style="TEXT-INDENT: 0.5in" class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">a.
State == IB_PNP_PORT_REMOVE - than complete the reset now (and
ASSERT(p_adapter->reset == TRUE) should be true there))<o:p></o:p></SPAN></P>
<P style="TEXT-INDENT: 0.5in" class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">b.
Otherwise (IB_PNP_PORT_ADD), register back to pnp events<o:p></o:p></SPAN></P>
<P style="TEXT-INDENT: 0.5in; MARGIN-LEFT: 0.5in" class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">i.
If succeed, do not complete reset here - reset process will be completed by
ipoib_pnp_cb() thread.<o:p></o:p></SPAN></P>
<P style="TEXT-INDENT: 0.5in; MARGIN-LEFT: 0.5in" class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">ii. If
not, reset process will be completed now (ASSERT(p_adapter->reset == TRUE)
should be true there)<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt"><o:p> </o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">How it can happen
?<o:p></o:p></SPAN></P>
<P class=MsoNormal><SPAN
style="FONT-FAMILY: 'Courier New'; FONT-SIZE: 8.5pt">NDIS detected
checked_for_hung while IPoIB get PORT_DOWN/UP pnp events<o:p></o:p></SPAN></P>
<P class=MsoNormal><o:p> </o:p></P>
<P class=MsoNormal>Signed-off by: Alexander Naslednikov (xalex at
mellanox.co.il)<o:p></o:p></P>
<P class=MsoNormal>Index:
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp<o:p></o:p></P>
<P
class=MsoNormal>===================================================================<o:p></o:p></P>
<P class=MsoNormal>---
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp
(revision 2987)<o:p></o:p></P>
<P class=MsoNormal>+++
ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp
(working copy)<o:p></o:p></P>
<P class=MsoNormal>@@ -1138,12 +1138,13 @@<o:p></o:p></P>
<P class=MsoNormal> <o:p></o:p></P>
<P
class=MsoNormal>
if( p_port )<o:p></o:p></P>
<P
class=MsoNormal>
ipoib_port_destroy( p_port );<o:p></o:p></P>
<P
class=MsoNormal>-
ASSERT(p_adapter->reset == TRUE);<o:p></o:p></P>
<P
class=MsoNormal>+
<o:p></o:p></P>
<P
class=MsoNormal>
if( state != IB_PNP_PORT_REMOVE )<o:p></o:p></P>
<P
class=MsoNormal>
{<o:p></o:p></P>
<P
class=MsoNormal>
status = __ipoib_pnp_reg( p_adapter, IB_PNP_FLAG_REG_COMPLETE );<o:p></o:p></P>
<P
class=MsoNormal>
if( status != IB_SUCCESS )<o:p></o:p></P>
<P
class=MsoNormal>
{<o:p></o:p></P>
<P
class=MsoNormal>+
ASSERT(p_adapter->reset == TRUE);<o:p></o:p></P>
<P
class=MsoNormal>
IPOIB_PRINT( TRACE_LEVEL_ERROR, IPOIB_DBG_ERROR,<o:p></o:p></P>
<P
class=MsoNormal>
("__ipoib_pnp_reg returned %s\n",<o:p></o:p></P>
<P
class=MsoNormal>
p_adapter->p_ifc->get_err_str( status )) );<o:p></o:p></P>
<P class=MsoNormal>@@ -1152,6 +1153,7 @@<o:p></o:p></P>
<P
class=MsoNormal>
}<o:p></o:p></P>
<P
class=MsoNormal>
else<o:p></o:p></P>
<P
class=MsoNormal>
{<o:p></o:p></P>
<P
class=MsoNormal>+
ASSERT(p_adapter->reset == TRUE);<o:p></o:p></P>
<P
class=MsoNormal>
__ipoib_complete_reset( p_adapter, NDIS_STATUS_SUCCESS );<o:p></o:p></P>
<P
class=MsoNormal>
status = IB_SUCCESS;<o:p></o:p></P>
<P
class=MsoNormal>
}<o:p></o:p></P>
<P class=MsoNormal><o:p> </o:p></P>
<P class=MsoNormal><B>Alexander (XaleX) Naslednikov<o:p></o:p></B></P>
<P class=MsoNormal><B>SW Networking Team<o:p></o:p></B></P>
<P class=MsoNormal><B>Mellanox Technologies<o:p></o:p></B></P>
<P class=MsoNormal><o:p> </o:p></P></DIV></BODY></HTML>