<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Stan,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thank you for the comments.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>We did it this way for the all IPoIB counters to enable debug at ‘fre’ version. See, for example, definitions of<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_ack = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SW = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SG = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SW_in_loop = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SG_pending = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SG_real = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_SG_failed = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>ULONG g_ipoib_send_reset = 0;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>The ASSERT is for the checked version only. We don’t want to stop here when running fre version of the driver.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>But I would like to check this counters if I got some other errors during free run.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>But on the other hand, we decided to unite all these counters into the struct on PORT object, to make this mechanism more robust and correct<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>And more important, I forgot to include to the patch the following lines. Without it, the ASSERT will be always true, I apologize for it.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Index: B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>--- B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp (revision 6779)<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>+++ B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_driver.cpp (revision 6780)<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>@@ -3013,7 +3013,8 @@<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> CL_ASSERT( p_addr_reset );<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> CL_ASSERT( adapter_context );<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> p_adapter = (ipoib_adapter_t*)adapter_context;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>-<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>+ ++g_reset;<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>+ <o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> switch( ipoib_reset_adapter( p_adapter ) )<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> {<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> case IB_NOT_DONE:<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Smith, Stan [mailto:stan.smith@intel.com] <br><b>Sent:</b> Thursday, November 25, 2010 6:04 AM<br><b>To:</b> Alex Naslednikov; ofw@lists.openfabrics.org<br><b>Subject:</b> RE: [ofw] [Patch] Adding instrumental code for reset flow<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'>Hello,</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'> Since this patch is basically long term debug support, why not put all of it under '#if DBG' ?</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'>Incrementing g_reset, for the free build the ASSERT() is gone hence no check, makes questionable sense?</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'>Full on or full off.</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'>Good catch on the typo.</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'> <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Arial","sans-serif";color:blue'>stan.</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p> </o:p></span></p><div class=MsoNormal align=center style='text-align:center'><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><hr size=2 width="100%" align=center></span></div><p class=MsoNormal style='margin-bottom:12.0pt'><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b>On Behalf Of </b>Alex Naslednikov<br><b>Sent:</b> Tuesday, November 23, 2010 12:16 AM<br><b>To:</b> ofw@lists.openfabrics.org<br><b>Subject:</b> [ofw] [Patch] Adding instrumental code for reset flow</span><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p></o:p></span></p><p class=MsoNormal>New counters added; no functionality changes<o:p></o:p></p><p class=MsoNormal>Signed-off by: Alexander Naslednikov (xalex at mellanox.co.il)<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Index: ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp<o:p></o:p></p><p class=MsoNormal>===================================================================<o:p></o:p></p><p class=MsoNormal>--- ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (revision 3000)<o:p></o:p></p><p class=MsoNormal>+++ ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (working copy)<o:p></o:p></p><p class=MsoNormal>@@ -51,7 +51,10 @@<o:p></o:p></p><p class=MsoNormal> #define FOUR_X_IN_100BPS 100000000<o:p></o:p></p><p class=MsoNormal> #define TWELVE_X_IN_100BPS 300000000<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>+extern ULONG g_reset;<o:p></o:p></p><p class=MsoNormal>+extern ULONG g_reset_complete;<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>+<o:p></o:p></p><p class=MsoNormal> /* Declarations */<o:p></o:p></p><p class=MsoNormal> static void<o:p></o:p></p><p class=MsoNormal> adapter_construct(<o:p></o:p></p><p class=MsoNormal>@@ -139,6 +142,9 @@<o:p></o:p></p><p class=MsoNormal> ("ipoib_state remained IPOIB_PAUSED and will be changed at ipoib_restart()\n") );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> KeReleaseInStackQueuedSpinLock( &hdl );<o:p></o:p></p><p class=MsoNormal>+<o:p></o:p></p><p class=MsoNormal>+ ++g_reset_complete;<o:p></o:p></p><p class=MsoNormal>+ ASSERT( g_reset == g_reset_complete );<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> p_adapter->reset = FALSE;<o:p></o:p></p><p class=MsoNormal> NdisMResetComplete(<o:p></o:p></p><p class=MsoNormal>@@ -1067,7 +1073,7 @@<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> else <o:p></o:p></p><p class=MsoNormal> {<o:p></o:p></p><p class=MsoNormal>- // This sittuation happened in real life: <o:p></o:p></p><p class=MsoNormal>+ // This situation happened in real life: <o:p></o:p></p><p class=MsoNormal> // NDIS called to reset and right after to pause, before the reset was completed<o:p></o:p></p><p class=MsoNormal> // Thus, when ipoib will try to complete reset, state may be already changed to IPOIB_PAUSE<o:p></o:p></p><p class=MsoNormal> ASSERT( p_adapter->ipoib_state == IPOIB_PAUSED );<o:p></o:p></p><p class=MsoNormal>@@ -1075,6 +1081,8 @@<o:p></o:p></p><p class=MsoNormal> ("ipoib_state remained IPOIB_PAUSED and will be changed at ipoib_restart()\n") );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> KeReleaseInStackQueuedSpinLock( &hdl );<o:p></o:p></p><p class=MsoNormal>+ ++g_reset_complete;<o:p></o:p></p><p class=MsoNormal>+ ASSERT( g_reset == g_reset_complete );<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> IPOIB_EXIT( IPOIB_DBG_INIT );<o:p></o:p></p><p class=MsoNormal>@@ -1762,4 +1770,4 @@<o:p></o:p></p><p class=MsoNormal> cl_spinlock_release( &p_adapter->send_stat_lock );<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> IPOIB_EXIT( IPOIB_DBG_STAT );<o:p></o:p></p><p class=MsoNormal>-}<o:p></o:p></p><p class=MsoNormal>+}<o:p></o:p></p><p class=MsoNormal>\ No newline at end of file<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p><p class=MsoNormal><b>SW Networking Team<o:p></o:p></b></p><p class=MsoNormal><b>Mellanox Technologies<o:p></o:p></b></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>