<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal><span style='color:#1F497D'>Below is the formal patch to the
place where the code seems to be very confusing (no functionality change).<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Index:
B:/users/tzachid/projinf6/trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>===================================================================<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>---
B:/users/tzachid/projinf6/trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (revision
7084)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+++
B:/users/tzachid/projinf6/trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_port.cpp (working
copy)<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>@@ -4596,16 +4596,15 @@<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> status
= __send_mgr_filter_udp( p_ip_hdr, p_mdl,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
(buf_len - hdr_size), p_eth_hdr->type, s_buf );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> cl_perf_stop(
&p_port->p_adapter->perf, FilterUdp );<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- if(
status == NDIS_STATUS_PENDING )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- {
/* not DHCP packet, keep going */<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- if(
ETH_IS_MULTICAST( p_eth_hdr->dst.addr ) )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- p_desc->send_dir
= SEND_UD_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- else<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- p_desc->send_dir
= SEND_RC_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- break;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ if(
status != NDIS_STATUS_PENDING ) {<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ return
status;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> }<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- return
status;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+
/* not DHCP packet, keep going */<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ if(
ETH_IS_MULTICAST( p_eth_hdr->dst.addr ) )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ p_desc->send_dir
= SEND_UD_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ else<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ p_desc->send_dir
= SEND_RC_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>+ break;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> case
IP_PROT_TCP:<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> p_desc->send_dir
= SEND_RC_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'> break;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Alex Naslednikov <br>
<b>Sent:</b> Sunday, December 26, 2010 9:20 AM<br>
<b>To:</b> Tzachi Dar; Galina Tcharny; Uri Habusha<br>
<b>Cc:</b> Gilad Margalit<br>
<b>Subject:</b> RE: It seems that there are several places where the function
__send_mgr_filter_udp is returning pending<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span style='color:#1F497D'>I agree.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Can you send it to the
community, please ?<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Tzachi Dar <br>
<b>Sent:</b> Thursday, December 23, 2010 12:38 PM<br>
<b>To:</b> Tzachi Dar; Alex Naslednikov; Galina Tcharny; Uri Habusha<br>
<b>Cc:</b> Gilad Margalit<br>
<b>Subject:</b> RE: It seems that there are several places where the function
__send_mgr_filter_udp is returning pending<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span style='color:#1F497D'>OK, my mistake.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>The following code got me
confused.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
if( status == NDIS_STATUS_PENDING )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
{ /* not DHCP packet, keep going */<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
if( ETH_IS_MULTICAST( p_eth_hdr->dst.addr ) )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
p_desc->send_dir = SEND_UD_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
else<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
p_desc->send_dir = SEND_RC_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
break;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
<span style='background:yellow;mso-highlight:yellow'>return status</span>;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Please note that it is not clear
that the function will return. <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>I’ll change it with <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
if( status != NDIS_STATUS_PENDING ) <o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
{<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
Return status;<o:p></o:p></span></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:.5in'><span
style='color:#1F497D'>}<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
/* not DHCP packet, keep going */<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
if( ETH_IS_MULTICAST( p_eth_hdr->dst.addr ) )<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
p_desc->send_dir = SEND_UD_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
else<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
p_desc->send_dir = SEND_RC_QP;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
<span style='background:yellow;mso-highlight:yellow'>break</span>;<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>
<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div style='border:none;border-right:solid blue 1.5pt;padding:0in 0in 0in 0in'>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Tzachi Dar <br>
<b>Sent:</b> Thursday, December 23, 2010 10:39 AM<br>
<b>To:</b> Alex Naslednikov; Galina Tcharny; Uri Habusha<br>
<b>Cc:</b> Tzachi Dar<br>
<b>Subject:</b> It seems that there are several places where the function
__send_mgr_filter_udp is returning pending<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>If I understand correctly this will cause the packets not to
be sent.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Is this by design? Is this something that I don’t
understand?<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Thanks<o:p></o:p></p>
<p class=MsoNormal>Tzachi<o:p></o:p></p>
</div>
</div>
</body>
</html>