<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>You shouldn’t need the lock here – think of the ‘free’ routines as destructors. Any concurrent accesses to this object are highly unsafe. Holding a lock on the list doesn’t really help, as something is trying to touch an object that’s about to be freed…<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>What is the scenario under which this is needed?<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>-Fab<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b>On Behalf Of </b>Irena Gannon<br><b>Sent:</b> Thursday, February 17, 2011 5:28 AM<br><b>To:</b> 'ofw@lists.openfabrics.org'<br><b>Subject:</b> [ofw] [patch][core][al] Acquire the mad_lock before accessing the mad_list in __free_mads<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Signed-off-by: Irena Gannon (<a href="mailto:irena@mellanox.co.il">irena@mellanox.co.il</a>) <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Acquire the mad_lock before accessing the mad_list in __free_mads<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Index: B:/users/irena/proj1/trunk/core/al/al.c<o:p></o:p></p><p class=MsoNormal>===================================================================<o:p></o:p></p><p class=MsoNormal>--- B:/users/irena/proj1/trunk/core/al/al.c (revision 6997)<o:p></o:p></p><p class=MsoNormal>+++ B:/users/irena/proj1/trunk/core/al/al.c (revision 6998)<o:p></o:p></p><p class=MsoNormal>@@ -132,6 +132,7 @@<o:p></o:p></p><p class=MsoNormal> ib_api_status_t status;<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> /* Return all outstanding MADs to their MAD pools. */<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_acquire( &h_al->mad_lock);<o:p></o:p></p><p class=MsoNormal> for( p_list_item = cl_qlist_head( &h_al->mad_list );<o:p></o:p></p><p class=MsoNormal> p_list_item != cl_qlist_end( &h_al->mad_list );<o:p></o:p></p><p class=MsoNormal> p_list_item = cl_qlist_head( &h_al->mad_list ) )<o:p></o:p></p><p class=MsoNormal>@@ -147,6 +148,7 @@<o:p></o:p></p><p class=MsoNormal> ib_get_err_str(status)) );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_release( &h_al->mad_lock);<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p></div></div></body></html>