<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
/* List Definitions */
@list l0
{mso-list-id:1450776900;
mso-list-type:hybrid;
mso-list-template-ids:-1835504534 979654310 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-start-at:328;
mso-level-number-format:bullet;
mso-level-text:\F06E;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
-->
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="Section1">
<p class="MsoNormal"><span style="color:#0D0D0D">Hello Sean,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">We have the following code commented out at
</span><span style="color:#0D0D0D">umad_receiver_stop:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D"> /* XXX hangs current thread - suspect umad_recv() ignoring wakeup.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D"> cl_thread_destroy(&p_ur->tid);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D"> */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">How can one ensure that </span><span style="color:#0D0D0D">umad_receiver thread will not run after osm_vendor_delete was called ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">Please, the e-mails below for more details<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">XaleX</span><span style="color:#0D0D0D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Hal Rosenstock
<br>
<b>Sent:</b> Wednesday, April 27, 2011 4:10 PM<br>
<b>To:</b> Alex Naslednikov; OpenSM; Gilad Margalit; Uri Habusha<br>
<b>Subject:</b> RE: Opensm bug<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">PSB </span><span style="color:#7030A0">[HNR]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Alex Naslednikov
<br>
<b>Sent:</b> Wednesday, April 27, 2011 9:08 AM<br>
<b>To:</b> Hal Rosenstock; OpenSM; Gilad Margalit; Uri Habusha<br>
<b>Subject:</b> RE: Opensm bug<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#0D0D0D">Hal,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">Thank you for the fast response<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">I see that the code of umad_receiver_stop is the same for 2.3.0 (trunk), so cl_thread_destroy will be called.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#0D0D0D">Can you please explain while umad_receiver_thread can continue running in this case ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">[HNR] Huh ? Isn’t that code commented out ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Hal Rosenstock
<br>
<b>Sent:</b> Wednesday, April 27, 2011 3:56 PM<br>
<b>To:</b> Alex Naslednikov; OpenSM; Gilad Margalit; Uri Habusha<br>
<b>Subject:</b> RE: Opensm bug<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">PSB </span><span style="color:#7030A0">[HNR]<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Alex Naslednikov
<br>
<b>Sent:</b> Wednesday, April 27, 2011 8:10 AM<br>
<b>To:</b> OpenSM; Gilad Margalit; Uri Habusha<br>
<b>Subject:</b> Opensm bug<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal">Recently we got the following assert:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">ASSERT happened: &p_log->lock is not initialized<o:p></o:p></p>
<p class="MsoNormal">complibd!cl_spinlock_acquire+0x39 [s:\builds\7789\trunk\inc\user\complib\cl_spinlock_osd.h @ 107]<o:p></o:p></p>
<p class="MsoNormal">opensm!osm_log+0x1b8 [s:\builds\7789\trunk\ulp\opensm\user\opensm\osm_log.c @ 171]<o:p></o:p></p>
<p class="MsoNormal">opensm!osm_vendor_get+0x174 [s:\builds\7789\trunk\ulp\opensm\user\libvendor\osm_vendor_ibumad.c @ 1007]<o:p></o:p></p>
<p class="MsoNormal">opensm!osm_mad_pool_get+0xbb [s:\builds\7789\trunk\ulp\opensm\user\opensm\osm_mad_pool.c @ 95]<o:p></o:p></p>
<p class="MsoNormal">opensm!umad_receiver+0x3b4 [s:\builds\7789\trunk\ulp\opensm\user\libvendor\osm_vendor_ibumad.c @ 314]<o:p></o:p></p>
<p class="MsoNormal">complibd!cl_thread_callback+0x1a [s:\builds\7789\trunk\core\complib\user\cl_thread.c @ 49]<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal">Did somebody see this problem before ?<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#7030A0">[HNR] FWIW I haven’t.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal">Can it happen that umad_receiver tries to access opensm when destroy process was already started ?<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#7030A0">[HNR] osm_vendor_delete is called prior to destroying the log (in osm_opensm_destory) so I wouldn’t think that should be the case. However, looking at some perhaps older version of osm_vendor_ibumad.c for Windows
(MLNX OFED 2.1.3), I see:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">static void umad_receiver_stop(umad_receiver_t * p_ur)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">{<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">#ifdef HAVE_LIBPTHREADS<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> pthread_cancel(p_ur->tid);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> pthread_join(p_ur->tid, NULL);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> p_ur->tid = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">#else<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> /* XXX hangs current thread - suspect umad_recv() ignoring wakeup.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> cl_thread_destroy(&p_ur->tid);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"> */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">#endif<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">I don’t know if that’s still the case but that looks to me like it could result in umad_receiver thread still running after the log is destroyed
</span><span style="font-family:Wingdings;
color:#7030A0">L</span><span style="color:#7030A0"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0">There are other unrelated problems in the Windows implementation of that file too (e.g. osm_vendor_set_sm is unimplemented which is problematic to multi SM operation).<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="font-family:Wingdings;color:#7030A0"><span style="mso-list:Ignore">n<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span dir="LTR"></span><span style="color:#7030A0">Hal<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p>
<p class="MsoNormal"><b>SW Networking Team<o:p></o:p></b></p>
<p class="MsoNormal"><b>Mellanox Technologies<o:p></o:p></b></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>