<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss="http://schemas.microsoft.com/office/2006/digsig-setup" xmlns:dssi="http://schemas.microsoft.com/office/2006/digsig" xmlns:mdssi="http://schemas.openxmlformats.org/package/2006/digital-signature" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:spwp="http://microsoft.com/sharepoint/webpartpages" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:pptsl="http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" xmlns:spsl="http://microsoft.com/webservices/SharePointPortalServer/PublishedLinksService" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Patch tests OK; no negative impact on UD or CM flows.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Looks good to me.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>stan.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Alex Naslednikov [mailto:xalex@mellanox.co.il] <br><b>Sent:</b> Thursday, May 19, 2011 8:39 AM<br><b>To:</b> Smith, Stan; ofw@lists.openfabrics.org<br><b>Subject:</b> RE: [ofw] [patch][IPoIB_NDIS6_CM] Take a send lock when join_mcast_group is not called directly from a send path<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hello Stan,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Yes, this patch is different and running regression since April, 28.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>CM flow wasn’t tested separately <o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Smith, Stan [mailto:stan.smith@intel.com] <br><b>Sent:</b> Tuesday, May 17, 2011 12:01 AM<br><b>To:</b> Alex Naslednikov; ofw@lists.openfabrics.org<br><b>Subject:</b> RE: [ofw] [patch][IPoIB_NDIS6_CM] Take a send lock when join_mcast_group is not called directly from a send path<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hello,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> This locking patch reminds me of an earlier version which dead locked due to the routine being called from two different locations :<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>One call site required locking send_lock, while the other call site already held the send_lock, hence the dead lock….<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Is this patch different?<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>How much IPoIB_CM testing has been accomplished with this patch installed?<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>stan.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> ofw-bounces@lists.openfabrics.org [mailto:ofw-bounces@lists.openfabrics.org] <b>On Behalf Of </b>Alex Naslednikov<br><b>Sent:</b> Thursday, April 28, 2011 2:44 AM<br><b>To:</b> ofw@lists.openfabrics.org<br><b>Subject:</b> [ofw] [patch][IPoIB_NDIS6_CM] Take a send lock when join_mcast_group is not called directly from a send path<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#0D0D0D'>Function ipoib_endpt_queue requires send lock to be held.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#0D0D0D'>ipoib_port_join_mcast calls to __endpt_mgr_ref that calls to ipoib_endpt_queue , but ipoib_port_join_mcast isn’t always send lock protected.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#0D0D0D'>Signed off by: Alexander Naslednikov (xalex at mellanox.co.il)<o:p></o:p></span></p><p class=MsoNormal><span style='color:#0D0D0D'><o:p> </o:p></span></p><p class=MsoNormal>Index: B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp<o:p></o:p></p><p class=MsoNormal>===================================================================<o:p></o:p></p><p class=MsoNormal>--- B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (revision 7799)<o:p></o:p></p><p class=MsoNormal>+++ B:/users/xalex/MLNX_VPI_trunk/ulp/ipoib_NDIS6_CM/kernel/ipoib_adapter.cpp (revision 7800)<o:p></o:p></p><p class=MsoNormal>@@ -987,6 +987,8 @@<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> /* Add new entries */<o:p></o:p></p><p class=MsoNormal>+ /* The lock is important here cause ipoib_endpt_queue will be called later and it requires lock to be held */<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_acquire( &p_port->send_lock );<o:p></o:p></p><p class=MsoNormal> for( i = 0; i < num_macs; i++ )<o:p></o:p></p><p class=MsoNormal> {<o:p></o:p></p><p class=MsoNormal> for( j = 0; j < p_adapter->mcast_array_size; j++ )<o:p></o:p></p><p class=MsoNormal>@@ -1009,6 +1011,7 @@<o:p></o:p></p><p class=MsoNormal> ipoib_port_join_mcast( p_port, p_mac_array[i], IB_MC_REC_STATE_FULL_MEMBER );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_release( &p_port->send_lock );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> /* Copy the MAC array. */<o:p></o:p></p><p class=MsoNormal>@@ -1316,6 +1319,8 @@<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal> /* Join all programmed multicast groups. */<o:p></o:p></p><p class=MsoNormal>+ /* The lock is important here cause ipoib_endpt_queue will be called later and it requires lock to be held */<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_acquire( &p_adapter->p_port->send_lock );<o:p></o:p></p><p class=MsoNormal> for( i = 0; i < p_adapter->mcast_array_size; i++ )<o:p></o:p></p><p class=MsoNormal> {<o:p></o:p></p><p class=MsoNormal> IPOIB_PRINT_EXIT( TRACE_LEVEL_INFORMATION, IPOIB_DBG_MCAST,<o:p></o:p></p><p class=MsoNormal>@@ -1324,7 +1329,8 @@<o:p></o:p></p><p class=MsoNormal> p_adapter->mcast_array[i],<o:p></o:p></p><p class=MsoNormal> IB_MC_REC_STATE_FULL_MEMBER );<o:p></o:p></p><p class=MsoNormal> }<o:p></o:p></p><p class=MsoNormal>-<o:p></o:p></p><p class=MsoNormal>+ cl_spinlock_release( &p_adapter->p_port->send_lock );<o:p></o:p></p><p class=MsoNormal>+ <o:p></o:p></p><p class=MsoNormal> /* Register all existing addresses. */<o:p></o:p></p><p class=MsoNormal> ipoib_reg_addrs( p_adapter );<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><b>Alexander (XaleX) Naslednikov<o:p></o:p></b></p><p class=MsoNormal><b>SW Networking Team<o:p></o:p></b></p><p class=MsoNormal><b>Mellanox Technologies<o:p></o:p></b></p><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>