<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Bookman Old Style";
panose-1:2 5 6 4 5 5 5 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:356085576;
mso-list-type:hybrid;
mso-list-template-ids:-1690426394 67698705 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Thanks Leo; a quick clarification.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Uri claimed he disabled the mlx4_bus driver and you stated<o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">[Leonid Keller] It was upon power-down IRP. The below code was called ultimately from __device_power_down_workItem():<span lang="AR-SA" dir="RTL"><o:p></o:p></span></span></i></b></p>
<p class="MsoNormal"><span dir="LTR"></span><span style="color:#1F497D"><span dir="LTR"></span>__device_power_down_workItem<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> __deregister_ca<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Is that to say the sequence of events was:<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo1"><![if !supportLists]><span style="color:#1F497D"><span style="mso-list:Ignore">1)<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="color:#1F497D">Disable mlx_bus driver<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo1"><![if !supportLists]><span style="color:#1F497D"><span style="mso-list:Ignore">2)<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="color:#1F497D">Start system shutdown?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Or was the device power down workItem invoked due to the mlx4_bus disable?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please clarify.<br>
<br>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">The CL_ASSERT() has been in the source base for over two years.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">My point being I strongly suspect the CL_ASSERT() would have fired prior to commit 3122, given the circumstances (Svr2008 R2, check ibbus driver, ioc_poll_interval=0).<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">We all understand there are existing race conditions in the IB stack w.r.t. power-down and/or device disable.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">None the less, I will look into the situation.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stan.</span><b><span style="color:#1F497D"><o:p></o:p></span></b></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Leonid Keller [mailto:leonid@mellanox.co.il]
<br>
<b>Sent:</b> Sunday, July 24, 2011 5:36 AM<br>
<b>To:</b> Uri Habusha; Smith, Stan<br>
<b>Cc:</b> ofw@lists.openfabrics.org; Tzachi Dar; Gilad Margalit; Benyahu Mizrahi<br>
<b>Subject:</b> RE: issue with checkin# 3122<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">SB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Smith, Stan [mailto:stan.smith@intel.com]
<br>
<b>Sent:</b> Friday, July 22, 2011 1:23 AM<br>
<b>To:</b> Uri Habusha<br>
<b>Cc:</b> ofw@lists.openfabrics.org; Leonid Keller; Tzachi Dar; Gilad Margalit; Benyahu Mizrahi<br>
<b>Subject:</b> RE: issue with checkin# 3122<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for the note, I’ll look into ASAP.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Some questions:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">When you mention low-level driver you are speaking of the HCA driver?</span><span style="font-family:"Times New Roman","serif";color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">[Leonid Keller] It was upon power-down IRP. The below code was called ultimately from __device_power_down_workItem():<span lang="AR-SA" dir="RTL"><o:p></o:p></span></span></i></b></p>
<p class="MsoNormal"><span dir="LTR"></span><span style="color:#1F497D"><span dir="LTR"></span>__device_power_down_workItem<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> __deregister_ca<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Does the CL_ASSERT() fire if the registry entry ioc_poll_interval == 30000?<o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">[Leonid Keller] Dunno. We have
</span></i><span style="color:#1F497D">ioc_poll_interval = 0</span></b><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Is the system which CL_ASSERT()’ed attached to a fabric which has an IB target device (IOC/IOU)?<o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">[Leonid Keller] No</span></i></b><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">What user-level events occurred before the HCA was disabled? Anything interesting? Perhaps a ‘devcon rescan’?<o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">[Leonid Keller] Nothing. The driver was installed and then, I believe, the machine was restarted.<o:p></o:p></span></i></b></p>
<p class="MsoNormal"><b><i><span style="color:#1F497D">Maybe you can reproduce it by using pwrtest.exe from WDK.</span></i></b><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">If p_ctx is NULL then the port object has been destroyed. The issue, I’m guessing at this point, might be a race between PNP and port_destroy()?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">A missing lock call perhaps?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Will let you know.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stan.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Uri Habusha [mailto:urih@mellanox.co.il]
<br>
<b>Sent:</b> Thursday, July 21, 2011 4:49 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> ofw@lists.openfabrics.org; Leonid Keller; Tzachi Dar; Gilad Margalit; Benyahu Mizrahi<br>
<b>Subject:</b> issue with checkin# 3122<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">Hi Stan,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">I adopted your checkin# 3122 - IOC poll on demand.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">When disabling the drive an ASSERT is popup. The ASSERT is in following code in port_mgr_pnp_cb function</span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> CL_ASSERT( p_ctx ); <span style="font-family:Wingdings">
ç</span> The problematic assert<o:p></o:p></p>
<p class="MsoNormal"> if (p_ctx)<o:p></o:p></p>
<p class="MsoNormal"> {<o:p></o:p></p>
<p class="MsoNormal"> p_bfi = p_ctx->p_bus_filter;<o:p></o:p></p>
<p class="MsoNormal"> CL_ASSERT( p_bfi );<o:p></o:p></p>
<p class="MsoNormal"> if (p_bfi->p_port_mgr->active_ports > 0)<o:p></o:p></p>
<p class="MsoNormal"> cl_atomic_dec( &p_bfi->p_port_mgr->active_ports );<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"> port_mgr_port_remove( (ib_pnp_port_rec_t*)p_pnp_rec );<o:p></o:p></p>
<p class="MsoNormal"> break;<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">I noticed that in the port_mgr_port_remove there is a check if the ctx is valid or not. So I guess it’s a known issue that can happen. For now I removed the assert in our code.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">Please take a look in the code and see if it’s valid fix (if so please change ofw code accordingly) or debug the issue. It happens when disable \enable the low level driver.</span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Uri<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Bookman Old Style","serif";color:#1F497D">Uri Habusha</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Bookman Old Style","serif";color:#1F497D">Windows SW Development Lead</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Bookman Old Style","serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">Mellanox Technologies<br>
</span></b><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">P.OBox 586, Yokneam 20692</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D">Israel</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Bookman Old Style","serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Bookman Old Style","serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>