<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Hal Rosenstock [mailto:hal.rosenstock@gmail.com]
<br>
<b>Sent:</b> Friday, September 30, 2011 4:09 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> Alex Netes; Hal Rosenstock; ofw@lists.openfabrics.org<br>
<b>Subject:</b> Re: [ofw] Opensm 3.3.11 (Debug) + 'osmtest -f m -M1' ASSERT() fires?<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Stan,<o:p></o:p></p>
<div>
<p class="MsoNormal">On Thu, Sep 29, 2011 at 1:17 PM, Smith, Stan <<a href="mailto:stan.smith@intel.com">stan.smith@intel.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Hello again,<br>
I forgot about another issue that was side-stepped via '#if 0' in order to make forward progress in the porting of OpenSM 3.3.11 to Windows.<br>
<br>
opensm/osm_helper.c<br>
<br>
int ib_path_compare_rates(IN const int rate1, IN const int rate2)<br>
{<br>
int orate1 = 0, orate2 = 0;<br>
<br>
CL_ASSERT(rate1 >= IB_MIN_RATE && rate1 <= IB_MAX_RATE);<br>
CL_ASSERT(rate2 >= IB_MIN_RATE && rate2 <= IB_MAX_RATE);<br>
<br>
When running a DEBUG version of opensm with 'osmtest -f m -M1', part of the test is to set invalid rates (rate1, rate2 == 1).<br>
When the rate1 or rate2 == 1 the CL_ASSERT() fires as IB_MIN_RATE == 2.<br>
I think the fix is to explicitly allow rate1 or rate2 == 1 for osmtest?<br>
<br>
/* rate1 | rate2 == 1 comes from 'osmtest -f m -M1' (expected invalid rate) */<br>
CL_ASSERT((rate1 >= IB_MIN_RATE || rate1 == 1) && rate1 <= IB_MAX_RATE);<br>
CL_ASSERT((rate2 >= IB_MIN_RATE || rate2 == 1) && rate2 <= IB_MAX_RATE);<br>
<br>
Thoughts?<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">That's a workaround rather than a fix.<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:#0070C0">Agreed, which is why I did not submit this as a patch.</span><span style="font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">There are 2 problems here:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">1. Those particular tests in osmtest are not testing what they intended on testing and they need to be redesigned. The tests are using reserved values for rates. See
<a href="http://www.mail-archive.com/linux-rdma@vger.kernel.org/msg08391.html">http://www.mail-archive.com/linux-rdma@vger.kernel.org/msg08391.html</a> email thread.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">2. Rather than change this assert which is correct, the rate value should be validated and rejected by the SA if invalid. I'll work on a patch for this shortly.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">-- Hal<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:#0070C0">Sounds reasonable; standing by.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Thanks,<br>
<br>
Stan.<br>
<br>
<br>
_______________________________________________<br>
ofw mailing list<br>
<a href="mailto:ofw@lists.openfabrics.org">ofw@lists.openfabrics.org</a><br>
<a href="http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw" target="_blank">http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw</a><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>