<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Leo,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> Some preliminary results for the branches\mlx4\ code base.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">After carefully merging the Head of the SVN tree (aka trunk\) with mlx4\, I was able to build x64 installers and test; going well at this time.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">A quick code review while merging, I found ‘roce_get_mtu()’ function defined in ib_pack.h?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Seems like an unlikely place to define roce_get_mtu(), perhaps a more ROCE typed file could be found?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">When building for IA64, I ran into the usage of ‘_AMD64_’ conditionals. I would suggest replacing with standard MS predefined macros; we still support IA64.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">--- C:/Users/scsmith/AppData/Local/Temp/eq.c-revBASE.svn000.tmp.c Wed Oct 05 16:44:11 2011<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">+++ C:/Users/scsmith/Documents/openIB-windows/OFA_SVN/ofw/gen1/branches/mlx4/hw/mlx4/kernel/bus/net/eq.c Wed Oct 05 16:17:03 2011<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">@@ -1252,7 +1252,7 @@<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> return -EINVAL;<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> }<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> <o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">-#ifndef AMD64<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">+#if _M_IX86<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> _BitScanForward(&cpu_number_in_group, *affinity);<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#else<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> _BitScanForward64(&cpu_number_in_group, *affinity);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">--- C:/Users/scsmith/AppData/Local/Temp/fw.c-revBASE.svn000.tmp.c Wed Oct 05 16:44:46 2011<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">+++ C:/Users/scsmith/Documents/openIB-windows/OFA_SVN/ofw/gen1/branches/mlx4/hw/mlx4/kernel/bus/net/fw.c Wed Oct 05 16:25:08 2011<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">@@ -1273,7 +1273,7 @@<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> memset(inbox, 0, INIT_HCA_IN_SIZE);<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> *((u8 *) mailbox->buf + INIT_HCA_VERSION_OFFSET) = INIT_HCA_VERSION;<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">-#if defined(_AMD64_)<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">+#ifndef _M_IX86<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""> *((u8 *) mailbox->buf + INIT_HCA_CACHELINE_SZ_OFFSET) = INIT_HCA_X86_64_BYTE_CACHELINE_SZ;<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#endif<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">That’s all for now; more to follow.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stan.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Leonid Keller [mailto:leonid@mellanox.co.il]
<br>
<b>Sent:</b> Wednesday, October 05, 2011 9:42 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> ofw_list<br>
<b>Subject:</b> RE: New bus driver<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’ve made three more commits with missed files.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Now you are to be able to build it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Smith, Stan [mailto:stan.smith@intel.com]
<br>
<b>Sent:</b> Wednesday, October 05, 2011 6:31 PM<br>
<b>To:</b> Leonid Keller<br>
<b>Cc:</b> ofw_list<br>
<b>Subject:</b> RE: New bus driver<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thank you Leo, will investigate immediately.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stan.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Leonid Keller [mailto:leonid@mellanox.co.il]
<br>
<b>Sent:</b> Wednesday, October 05, 2011 7:21 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> ofw_list<br>
<b>Subject:</b> New bus driver<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Stan,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I started commits related to new bus driver.<o:p></o:p></p>
<p class="MsoNormal">I created a new branch – mlx4 – on base of trunk:3283 and replaced \HW directory.<o:p></o:p></p>
<p class="MsoNormal">I also changed several files in order to build it.<o:p></o:p></p>
<p class="MsoNormal">I built it with <o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">OFED\Bld1.bat win7 x64 all<o:p></o:p></p>
<p class="MsoNormal">And we are checking it now.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Patch 3287 contains a long comment describing main changes in the bus drivers.<o:p></o:p></p>
<p class="MsoNormal">You (and all) are invited to review the patch.<o:p></o:p></p>
<p class="MsoNormal">Don’t hesitate to ask questions.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’ll continue to add more patches, related to other components.<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>