<br><br><div class="gmail_quote">On Mon, Oct 17, 2011 at 2:39 PM, Smith, Stan <span dir="ltr"><<a href="mailto:stan.smith@intel.com">stan.smith@intel.com</a>></span> wrote:<br><blockquote style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;" class="gmail_quote">
<div lang="EN-US" vlink="purple" link="blue">
<div>
<p>Done.</p><p> </p></div></div></blockquote><div> </div><div>Is this using 1024 or BUFSIZ ?</div><div> </div><div>-- Hal </div><blockquote style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;" class="gmail_quote">
<div lang="EN-US" vlink="purple" link="blue"><div><p> </p>
<p><u></u> <u></u></p>
<p>Thanks.<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>Revision: 3309<u></u><u></u></p>
<p>Author: <a href="mailto:stan.smith@intel.com" target="_blank">stan.smith@intel.com</a><u></u><u></u></p>
<p>Date: 11:33:08 AM, Monday, October 17, 2011<u></u><u></u></p>
<p>Message:<u></u><u></u></p>
<p>[OPENSM] side-step win8 assert; use agreed upon BUFSIZ value.<u></u><u></u></p>
<p>----<u></u><u></u></p>
<p>Modified : /gen1/<span style="color: red;">branches/mlx4</span>/ulp/opensm/user/opensm/main.c<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>Revision: 3310<u></u><u></u></p>
<p>Author: <a href="mailto:stan.smith@intel.com" target="_blank">stan.smith@intel.com</a><u></u><u></u></p>
<p>Date: 11:34:48 AM, Monday, October 17, 2011<u></u><u></u></p>
<p>Message:<u></u><u></u></p>
<p>[OPENSM] side-step win8 assert; use agreed upon BUFSIZ value.<u></u><u></u></p>
<p>----<u></u><u></u></p>
<p>Modified : /gen1/<span style="color: red;">trunk</span>/ulp/opensm/user/opensm/main.c<u></u><u></u></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<div style="border-width: medium medium medium 1.5pt; border-style: none none none solid; border-color: currentColor currentColor currentColor blue; padding: 0in 0in 0in 4pt;">
<div>
<div style="border-width: 1pt medium medium; border-style: solid none none; border-color: rgb(181, 196, 223) currentColor currentColor; padding: 3pt 0in 0in;">
<p class="MsoNormal"><b><span style="font-size: 10pt;">From:</span></b><span style="font-size: 10pt;"> <a href="mailto:ofw-bounces@lists.openfabrics.org" target="_blank">ofw-bounces@lists.openfabrics.org</a> [mailto:<a href="mailto:ofw-bounces@lists.openfabrics.org" target="_blank">ofw-bounces@lists.openfabrics.org</a>]
<b>On Behalf Of </b>Smith, Stan<br>
<b>Sent:</b> Monday, October 17, 2011 9:10 AM<br>
<b>To:</b> Leonid Keller<br>
<b>Cc:</b> ofw_list<br>
<b>Subject:</b> Re: [ofw] [bug] Assert in opensm 3.3.11<u></u><u></u></span></p>
</div>
</div><div><div></div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);">Hello,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"> I too noticed this change, no assert() fire on win7; not surprising. Seems the discussion Alex, Hal and others had w.r.t. Windows setvbuf(BUFSIZ) did not make it into the mainline.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);">I’d prefer BUFSIZ as it’s a well-recognized system wide entity, although 1024 would work equally well.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);">I’ll update, thanks for pointing out the omission.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);">Stan.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);"><u></u> <u></u></span></p>
<div style="border-width: medium medium medium 1.5pt; border-style: none none none solid; border-color: currentColor currentColor currentColor blue; padding: 0in 0in 0in 4pt;">
<div>
<div style="border-width: 1pt medium medium; border-style: solid none none; border-color: rgb(181, 196, 223) currentColor currentColor; padding: 3pt 0in 0in;">
<p class="MsoNormal"><b><span style="font-size: 10pt;">From:</span></b><span style="font-size: 10pt;"> Leonid Keller [mailto:<a href="mailto:leonid@mellanox.co.il" target="_blank">leonid@mellanox.co.il</a>]
<br>
<b>Sent:</b> Saturday, October 15, 2011 11:23 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> ofw_list<br>
<b>Subject:</b> [ofw][bug] Assert in opensm 3.3.11<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Hi Stan,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I got an assert in Win8 on setvbuf (see below).<u></u><u></u></p>
<p class="MsoNormal">It states that <i>size</i> should be at least 2.<u></u><u></u></p>
<p class="MsoNormal">Also MSDN agrees with that:<u></u><u></u></p>
<p class="MsoNormal"><i><span style="color: rgb(0, 32, 96); font-family: "Times New Roman","serif"; font-size: 12pt;">size
<u></u><u></u></span></i></p>
<p style="margin-left: 0.5in;" class="MsoNormal">
<span style="color: rgb(0, 32, 96); font-family: "Times New Roman","serif"; font-size: 12pt;">Buffer size in bytes. Allowable range: 2 <= size <= INT_MAX <a href="tel:%282147483647" target="_blank" value="+12147483647">(2147483647</a>)<u></u><u></u></span></p>
<p class="MsoNormal">Here is the suggested patch.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Index: main.c<u></u><u></u></p>
<p class="MsoNormal">===================================================================<u></u><u></u></p>
<p class="MsoNormal">--- main.c (revision 8962)<u></u><u></u></p>
<p class="MsoNormal">+++ main.c (revision 8963)<u></u><u></u></p>
<p class="MsoNormal">@@ -732,7 +732,7 @@<u></u><u></u></p>
<p class="MsoNormal"> };<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> /* force stdout to be line-buffered */<u></u><u></u></p>
<p class="MsoNormal">- setvbuf(stdout, NULL, _IOLBF<span style="background: yellow;">, 0</span>);<u></u><u></u></p>
<p class="MsoNormal">+ setvbuf(stdout, NULL, _IOLBF, 1024);<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> /* Make sure that the opensm and complib were compiled using<u></u><u></u></p>
<p class="MsoNormal"> same modes (debug/free) */<u></u><u></u></p>
</div>
</div></div></div>
</div>
</div>
<br>_______________________________________________<br>
ofw mailing list<br>
<a href="mailto:ofw@lists.openfabrics.org">ofw@lists.openfabrics.org</a><br>
<a href="http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw" target="_blank">http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw</a><br></blockquote></div><br>