<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Schmitt, Hubert [mailto:Hubert.Schmitt@oce.com]
<br>
<b>Sent:</b> Wednesday, February 06, 2013 12:21 AM<br>
<b>To:</b> Smith, Stan<br>
<b>Cc:</b> ofw@lists.openfabrics.org<br>
<b>Subject:</b> AW: rsocket.c & gtod.c duplicate include error.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:blue">Hi Stan,</span><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:blue">Can it be that you were still using the "original" gtod.c? Because in my recent rsocket patch there was also contained an updated gtod.c with (among other things)
gettimeofday() changed to static.</span><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:blue">However, non-static gettimeofday() is just as well for me. But I recommend to at least adopt my real modification of gtod.c, in order to fix a potential division-by-zero
issue when calling gettimeofday() from a multi-threaded process (see also ofw Digest, Vol 68, Issue 2 from Dec 17, 2012).</span><span style="font-size:10.0pt;font-family:"Arial","sans-serif""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">All your divide-by-zero mods are included.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">The ‘static’ qualifier is IMHO is the incorrect attribute to be using; how many copies of gettimeofday() does an application need?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Not to mention the ‘static’ inhibits the detection of duplicate gtod.c includes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">It’s truly sad that gettimeofday() is a ‘#include <etc/gtod.c>’ and not in a library somewhere.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’m convinced that for now, the ‘static’ qualifier should be removed and will do so.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stan.<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:blue">Thanks,</span><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:blue">Hubert</span><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div class="MsoNormal" align="center" style="text-align:center"><span lang="DE" style="font-size:12.0pt;font-family:"Times New Roman","serif"">
<hr size="2" width="100%" align="center">
</span></div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span lang="DE" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Von:</span></b><span lang="DE" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Smith, Stan [<a href="mailto:stan.smith@intel.com">mailto:stan.smith@intel.com</a>]
<br>
<b>Gesendet:</b> Dienstag, 5. Februar 2013 22:43<br>
<b>An:</b> Schmitt, Hubert<br>
<b>Cc:</b> <a href="mailto:ofw@lists.openfabrics.org">ofw@lists.openfabrics.org</a><br>
<b>Betreff:</b> rsocket.c & gtod.c duplicate include error.</span><span lang="DE" style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p></o:p></span></p>
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal"> When building winOFED from trunk\ svn.3425 I find duplicate definitions of gettimeofday() link errors when building ulp\librdmacm?<o:p></o:p></p>
<p class="MsoNormal">Duplication is resultant from <o:p></o:p></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">ulp\librdmacm\src\cma_main.cpp:#include "../../../etc/user/gtod.c"<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">ulp\librdmacm\src\rsocket.cpp:#include "../../../etc/user/gtod.c"<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">Fixed by removing gtod.c include from rsocket.cpp<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">Signed-off by stan smith (<a href="mailto:stan.smith@intel.com">stan.smith@intel.com</a>)<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">--- C:/Users/scsmith/AppData/Local/Temp/rsocket.cpp-revBASE.svn000.tmp.cpp Thu Jan 24 15:02:56 2013<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">+++ C:/Users/scsmith/Documents/openIB-windows/ofw/gen1/trunk/ulp/librdmacm/src/rsocket.cpp Tue Feb 05 13:28:32 2013<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">@@ -60,8 +60,6 @@<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#include <rdma/rsocket.h><o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#include "cma.h"<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#include "indexer.h"<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">-#include "../../../etc/user/gtod.c"<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">-<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#define RS_OLAP_START_SIZE 2048<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#define RS_MAX_TRANSFER 65536<o:p></o:p></span></p>
<p class="MsoPlainText"><span style="font-family:"Courier New"">#define RS_MAX_BACKLOG 256<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><br clear="all">
This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law. If you are not the intended recipient or agent thereof responsible
for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately
by telephone and with a 'reply' message. Thank you for your co-operation. <o:p></o:p></span></p>
</div>
</div>
</body>
</html>