<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML xmlns="http://www.w3.org/TR/REC-html40" xmlns:v =
"urn:schemas-microsoft-com:vml" xmlns:o =
"urn:schemas-microsoft-com:office:office" xmlns:w =
"urn:schemas-microsoft-com:office:word" xmlns:m =
"http://schemas.microsoft.com/office/2004/12/omml"><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.7601.18021">
<STYLE>@font-face {
font-family: Calibri;
}
@font-face {
font-family: Consolas;
}
@page WordSection1 {size: 8.5in 11.0in; margin: 1.0in 1.0in 1.0in 1.0in; }
P.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
LI.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
DIV.MsoNormal {
MARGIN: 0in 0in 0pt; FONT-FAMILY: "Calibri","sans-serif"; FONT-SIZE: 11pt
}
A:link {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlink {
COLOR: blue; TEXT-DECORATION: underline; mso-style-priority: 99
}
A:visited {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
SPAN.MsoHyperlinkFollowed {
COLOR: purple; TEXT-DECORATION: underline; mso-style-priority: 99
}
P.MsoPlainText {
MARGIN: 0in 0in 0pt; FONT-FAMILY: Consolas; FONT-SIZE: 10.5pt; mso-style-priority: 99; mso-style-link: "Plain Text Char"
}
LI.MsoPlainText {
MARGIN: 0in 0in 0pt; FONT-FAMILY: Consolas; FONT-SIZE: 10.5pt; mso-style-priority: 99; mso-style-link: "Plain Text Char"
}
DIV.MsoPlainText {
MARGIN: 0in 0in 0pt; FONT-FAMILY: Consolas; FONT-SIZE: 10.5pt; mso-style-priority: 99; mso-style-link: "Plain Text Char"
}
SPAN.EmailStyle17 {
FONT-FAMILY: "Calibri","sans-serif"; COLOR: windowtext; mso-style-type: personal-compose
}
SPAN.PlainTextChar {
FONT-FAMILY: Consolas; mso-style-priority: 99; mso-style-link: "Plain Text"; mso-style-name: "Plain Text Char"
}
.MsoChpDefault {
FONT-FAMILY: "Calibri","sans-serif"; mso-style-type: export-only
}
DIV.WordSection1 {
page: WordSection1
}
</STYLE>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></HEAD>
<BODY lang=EN-US link=blue vLink=purple>
<DIV dir=ltr align=left><SPAN class=805135707-06022013><FONT color=#0000ff
size=2 face=Arial>Hi Stan,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=805135707-06022013><FONT color=#0000ff
size=2 face=Arial></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=805135707-06022013><FONT color=#0000ff
size=2 face=Arial>Can it be that you were still using the "original" gtod.c?
Because in my recent rsocket patch there was also contained an updated gtod.c
with (among other things) gettimeofday() changed to
static.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=805135707-06022013><FONT color=#0000ff
size=2 face=Arial>However, non-static gettimeofday() is just as well for
me. But I recommend to at least adopt my real modification of gtod.c, in order
to fix a potential division-by-zero issue when calling gettimeofday() from a
multi-threaded process (see also ofw Digest, Vol 68, Issue 2 from Dec 17,
2012).</FONT></SPAN></DIV>
<DIV><FONT color=#0000ff size=2 face=Arial></FONT> </DIV>
<DIV><SPAN class=805135707-06022013></SPAN><FONT face=Arial><FONT
color=#0000ff><FONT size=2>T<SPAN
class=805135707-06022013>hanks,</SPAN></FONT></FONT></FONT></DIV>
<DIV><SPAN class=805135707-06022013></SPAN><SPAN
class=805135707-06022013></SPAN><FONT face=Arial><FONT color=#0000ff><FONT
size=2>H<SPAN
class=805135707-06022013>ubert</SPAN></FONT></FONT></FONT><BR></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #0000ff 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=de class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>Von:</B> Smith, Stan [mailto:stan.smith@intel.com]
<BR><B>Gesendet:</B> Dienstag, 5. Februar 2013 22:43<BR><B>An:</B> Schmitt,
Hubert<BR><B>Cc:</B> ofw@lists.openfabrics.org<BR><B>Betreff:</B> rsocket.c
& gtod.c duplicate include error.<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV class=WordSection1>
<P class=MsoNormal>Hello,<o:p></o:p></P>
<P class=MsoNormal> When building winOFED from trunk\ svn.3425 I find
duplicate definitions of gettimeofday() link errors when building
ulp\librdmacm?<o:p></o:p></P>
<P class=MsoNormal>Duplication is resultant from <o:p></o:p></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'"><o:p> </o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'">ulp\librdmacm\src\cma_main.cpp:#include
"../../../etc/user/gtod.c"<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'">ulp\librdmacm\src\rsocket.cpp:#include
"../../../etc/user/gtod.c"<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'"><o:p> </o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">Fixed by
removing gtod.c include from rsocket.cpp<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'"><o:p> </o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">Signed-off by
stan smith (<A
href="mailto:stan.smith@intel.com">stan.smith@intel.com</A>)<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'"><o:p> </o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'"><o:p> </o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">---
C:/Users/scsmith/AppData/Local/Temp/rsocket.cpp-revBASE.svn000.tmp.cpp
Thu Jan 24 15:02:56 2013<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">+++
C:/Users/scsmith/Documents/openIB-windows/ofw/gen1/trunk/ulp/librdmacm/src/rsocket.cpp
Tue Feb 05 13:28:32 2013<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">@@ -60,8 +60,6
@@<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#include
<rdma/rsocket.h><o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#include
"cma.h"<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#include
"indexer.h"<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">-#include
"../../../etc/user/gtod.c"<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN
style="FONT-FAMILY: 'Courier New'">-<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#define
RS_OLAP_START_SIZE 2048<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#define
RS_MAX_TRANSFER 65536<o:p></o:p></SPAN></P>
<P class=MsoPlainText><SPAN style="FONT-FAMILY: 'Courier New'">#define
RS_MAX_BACKLOG 256<o:p></o:p></SPAN></P>
<P class=MsoNormal><o:p> </o:p></P></DIV></BLOCKQUOTE><br clear=all> This message and attachment(s) are intended solely for use by the addressee and may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable law.
If you are not the intended recipient or agent thereof responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited.
If you have received this communication in error, please notify the sender immediately by telephone and with a 'reply' message.
Thank you for your co-operation.
</BODY></HTML>