[openfabrics-ewg] Rollup patch for ipath and OFED

[Michael S. Tsirkin]

Guys, I just looked at ipath-fixes.patch in ofed.  With 36 files changed, 4623
insertions, 4774 deletions, it's quite a biggie with no description what it does
whatsoever.  Can't this be split to smaller chunks doing one thing at a time,
please?  You'll have to do this for upstream inclusion anyway, so why not for
OFED?

Oh well. However, this baby also does for example:

diff -r d2661c9eff49 -r 198ed6310295 drivers/infiniband/hw/ipath/Makefile
--- a/drivers/infiniband/hw/ipath/Makefile	Thu Aug 10 16:19:45 2006 -0700
+++ b/drivers/infiniband/hw/ipath/Makefile	Wed Aug 16 11:01:29 2006 -0700
@@ -1,36 +1,34 @@ EXTRA_CFLAGS += -DIPATH_IDSTR='"QLogic k
 EXTRA_CFLAGS += -DIPATH_IDSTR='"QLogic kernel.org driver"' \
 	-DIPATH_KERN_TYPE=0
 
-obj-$(CONFIG_IPATH_CORE) += ipath_core.o
 obj-$(CONFIG_INFINIBAND_IPATH) += ib_ipath.o
 
-ipath_core-y := \
+ib_ipath-y := \
+	ipath_cq.o \
 	ipath_diag.o \
 	ipath_driver.o \
 	ipath_eeprom.o \
 	ipath_file_ops.o \
 	ipath_fs.o \
-	ipath_ht400.o \
+	ipath_iba6110.o \
+	ipath_iba6120.o \
 	ipath_init_chip.o \
 	ipath_intr.o \
+	ipath_keys.o \
 	ipath_layer.o \
-	ipath_pe800.o \
-	ipath_stats.o \
-	ipath_sysfs.o \
-	ipath_user_pages.o
-
-ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o
-
-ib_ipath-y := \
-	ipath_cq.o \
-	ipath_keys.o \
 	ipath_mad.o \
 	ipath_mr.o \
 	ipath_qp.o \
 	ipath_rc.o \
 	ipath_ruc.o \
 	ipath_srq.o \
+	ipath_stats.o \
+	ipath_sysfs.o \
 	ipath_uc.o \
 	ipath_ud.o \
-	ipath_verbs.o \
-	ipath_verbs_mcast.o
+	ipath_user_pages.o \
+	ipath_verbs_mcast.o \
+	ipath_verbs.o
+
+ib_ipath-$(CONFIG_X86_64) += ipath_wc_x86_64.o
+ib_ipath-$(CONFIG_PPC64) += ipath_wc_ppc64.o

So this seems to be ripping out chunks of upstream code (ipath_ht400)
replacing them with something else (ipath_iba6110, ipath_iba6120.o)

This might be a good change for all I know. But I'd like to ask
 What exactly does this fixes patch, fix?
 Can there be a list of things it provides at the top?
 How about a Signed-off-by line?
 Was this posted on openib-general even once?

There's a single unmerged ipath patch posted on openib-general:
 mmap()ed userspace work queues for ipath.

So where does the rest come from?
Googling for ipath_iba6110 gets no hits.

Thanks,

-- 
MST