[openfabrics-ewg] [openib-general] librdmacm ABI issues with OFED 1.1

[Woodruff, Robert J]

Here is a patch that I used in my backport to 2.6.9 for RedHat EL4 - U3 
svn 8841 openib fixups patch. It also applies to svn9006 and will
likely work fine on the OFED 1.1 code if you replace the current patch
that removes the creation of the abi_version with this one that 
creates it under /sys/class/infiniband_uma

and modify the library to check either place (Ira's patch below), it
should work.

woody
 

-----Original Message-----
From: openfabrics-ewg-bounces at openib.org
[mailto:openfabrics-ewg-bounces at openib.org] On Behalf Of Ira Weiny
Sent: Thursday, August 24, 2006 9:58 AM
To: Sean Hefty
Cc: mst at mellanox.co.il; openfabrics-ewg at openib.org;
openib-general at openib.org
Subject: Re: [openfabrics-ewg] [openib-general] librdmacm ABI issues
with OFED 1.1

On Thu, 24 Aug 2006 09:18:50 -0700
"Sean Hefty" <mshefty at ichips.intel.com> wrote:

> Michael S. Tsirkin wrote:
> > Maybe the librdmacm part should be merged to svn?
> > So librdmacm could try to read from misc, then from
> > /sys/class/infiniband/rdma_cm, and then assume latest.
> > It's good to have userspace code portable across distros ...
> 
> I can go with that.
> 
> - Sean
> 

Something like this?

Ira


Index: openib/src/userspace/librdmacm/src/cma.c
===================================================================
--- openib/src/userspace/librdmacm/src/cma.c    (revision 213)
+++ openib/src/userspace/librdmacm/src/cma.c    (revision 220)
@@ -141,9 +141,13 @@
 {
        char value[8];
 
-       if (ibv_read_sysfs_file(ibv_get_sysfs_path(),
+       if ((ibv_read_sysfs_file(ibv_get_sysfs_path(),
                                "class/misc/rdma_cm/abi_version",
-                               value, sizeof value) < 0) {
+                               value, sizeof value) < 0)
+               &&
+               (ibv_read_sysfs_file(ibv_get_sysfs_path(),
+                               "class/infiniband_ucma/abi_version",
+                               value, sizeof value) < 0)) {
                /*
                 * Older version of Linux do not have class/misc.  To
support
                 * backports, assume the most recent version of the ABI.
If


_______________________________________________
openfabrics-ewg mailing list
openfabrics-ewg at openib.org
http://openib.org/mailman/listinfo/openfabrics-ewg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ucma_abi_version_backport_to_2.6.9.patch
Type: application/octet-stream
Size: 5876 bytes
Desc: ucma_abi_version_backport_to_2.6.9.patch
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20060824/2a7c038a/attachment.obj>