[openfabrics-ewg] [openib-general]  OFED Status
    Robert Walsh 
    rjwalsh at pathscale.com
       
    Tue Oct  3 14:36:09 PDT 2006
    
    
  
> This seems dangerous, especially now that we have PCI_MULTITHREAD_PROBE:
> nothing prevents ipath_cdev_init() from being called twice.  Better to
> use something like test_and_set_bit() to make sure this is done
> exactly once.
Well, it needs to be refcounted, as we need to create it on first
add_one and remove it on the last remove_one.  If I put a spinlock
around it, would that suffice?
Regards,
 Robert.
    
    
More information about the ewg
mailing list