[openfabrics-ewg] RHEL5 and OFED ...

[Doug Ledford]

On Thu, 2006-10-19 at 07:09 +0200, Michael S. Tsirkin wrote:
> Quoting r. Doug Ledford <dledford at redhat.com>:
> > Subject: Re: [openfabrics-ewg] RHEL5 and OFED ...
> > 
> > On Wed, 2006-10-18 at 09:29 +0200, Michael S. Tsirkin wrote:
> > > Quoting r. Doug Ledford <dledford at redhat.com>:
> > > > > >From our dicussion, it seems we should be able to just push the
> > > > > small number of missing bits into RHEL5 directly. That would be
> > > > > nicer of course.
> > > > 
> > > > It depends.  If there's lots of individual changes, it might be easier
> > > > to push the OFED 1.1 change.  But, that depends on when the final OFED
> > > > 1.1 comes out and how much it varies from the existing RPMs.
> > > 
> > > OFED is in deep freeze, so you can already look at it to estimate the amount of
> > > changes against 2.6.18.
> > > Could you look at the diff please so that I know whether it's worth it
> > > to invest in building the minimal patch set for pushing into RHEL5,
> > > or whether you'll push OFED 1.1 into RHEL kernel as is?
> > 
> > Yeah, I'll look over the diff today.
> 
> How does it look?

Didn't get around to it.  Instead, I was fixing a buffer overflow
problem in openmpi (reuse of the len variable without resetting it to
the correct value after the bottom of the loop does len = strlen(desc);
causes the snprintf() in the loop to trigger as a buffer overflow when
compiled with FORTIFY_SOURCE, patch attached) and reviewing arpingib
(which I'm going to remove from the ipoibtools and fix the native arping
in RHEL5 to work properly over IB without needing a new flag, the -A or
-U flags should be sufficient assuming those modes worked at all over IB
which they don't in either the native arping or the patched arpingib in
ipoibtools).  I should get to it today though.

-- 
Doug Ledford <dledford at redhat.com>
              GPG KeyID: CFBFF194
              http://people.redhat.com/dledford

Infiniband specific RPMs available at
              http://people.redhat.com/dledford/Infiniband
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openmpi-1.1.1-overflow.patch
Type: text/x-patch
Size: 1012 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20061019/ed922064/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20061019/ed922064/attachment.sig>