[openfabrics-ewg] Any one tried OFED 1.1 or OFED 1.0.1 backport for sles 9 on ppc64

[Moshe Kazir]

Michael, 

I found the bug that privent the compile of  OFED 1.1 or OFED 1.0.1
backport for sles 9 on my ppc64.

This bug is not restricted to ppc64 only. I suspect that it relate to
any non x86 machine.

atomic.h backport code in linux_atomic_8802_to_2_6_5-7_244.patch or
linux_atomic_8111_to_2_6_5-7_244.patch
Compilation of  atomic.h reports an error on one of the assembly lines.

After a close look at the code (See below) I notice that the function
atomic_add_return() overrides the machine specific asm volatile 
Functions included in  the system <asm/atomic.h> .

After removing the functions atomic_add_return() and atomic_sub_return()
compile pass o.k.

I think that these two functions has to be limited to #ifdef
MY_MACHINE_SPECIFIC and not as they are coded now.

Moshe
  
> cat  atomic.h
========================================
#ifndef LINUX_ATOMIC_BACKPORT_H
#define LINUX_ATOMIC_BACKPORT_H

#include_next <asm/atomic.h>

#ifndef atomic_inc_return
static __inline__ int atomic_add_return(int i, atomic_t *v)
{
	int __i = i;
	__asm__ __volatile__(
		LOCK "xaddl %0, %1;"
		:"=r"(i)
		:"m"(v->counter), "0"(i));
	return i + __i;
}

static __inline__ int atomic_sub_return(int i, atomic_t *v)
{
	return atomic_add_return(-i,v);
}
#define atomic_inc_return(v)  (atomic_add_return(1,v))
#define atomic_dec_return(v)  (atomic_sub_return(1,v))

#endif

#endif


____________________________________________________________
Moshe Katzir   |  +972-9971-8639 (o)   |   +972-52-860-6042  (m)
 
Voltaire - The Grid Backbone
 
 www.voltaire.com

  


-----Original Message-----
From: Tziporet Koren [mailto:tziporet at dev.mellanox.co.il] 
Sent: Tuesday, September 12, 2006 2:37 PM
To: Michael S. Tsirkin
Cc: Moshe Kazir; openfabrics-ewg at openib.org
Subject: Re: [openfabrics-ewg] Any one tried OFED 1.1 or OFED 1.0.1
backport for sles 9 on ppc64


Michael S. Tsirkin wrote:
> I don't know of any issues.
> Post the make log?
>
> Quoting r. Moshe Kazir <moshek at voltaire.com>:
> Subject: Any one tried OFED 1.1 or OFED 1.0.1 backport for sles 9 on 
> ppc64
>
>
> I tried the two versions on my js21 ppc64 ->
>
> The builds  failed due to compilation error.
>
> Are there any known fixes ?
>
>   
Hi,
We do not test SLES9 on PPC since we don't have a system like this.
Please fix the backport patches for SLES9 and test it. If its working 
please send the patches to us so we can include them in OFED.

Tziporet

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: OFED_atomic.h_bug.txt
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20060913/4a721f47/attachment.txt>