[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

[Michael S. Tsirkin]

> Quoting Hoang-Nam Nguyen <hnguyen at linux.vnet.ibm.com>:
> Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1
> 
> On Tuesday 07 August 2007 15:23, Michael S. Tsirkin wrote:
> > > Quoting Hoang-Nam Nguyen <hnguyen at linux.vnet.ibm.com>:
> > > Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1
> > > 
> > > Hello Michael!
> > > Below is the patch to backport kmem_cache_zalloc() for 2.6.16/sles10/sles10_sp1
> > > as we've discussed previously. Thereby I realized current backport code
> > > in slab.h looks weird to me (sort of copy&paste mixture) - actually no build
> > > error, only coding "issue". 
> > > Therefore this patch also includes some cleanup. If it's ok, please apply.
> > > PS: The mentioned issue in backport slab.h exists also in other versions.
> > > If you want me to fix them as well, let me know.
> > > Regards
> > > Nam
> > 
> > Would not the following work? If yes, Vlad, I parked this at
> Wow, you're pretty quick. Yes, it should work. And you're right we need
> this patch for <=2.6.16.
> PS: The weird thing in slab.h I meant previously is that the 
> ifdef-kmem_dup()-block exists twice in same file, which does not harm 
> the build.
> Thanks!
> Nam

I haven't seen this. Right.
Can you please post a separate patch that just kills
the duplicates?


-- 
MST