[ewg] Re: [PATCH 2/14] nes: device structures and defines

Andi Kleen andi at firstfloor.org
Wed Aug 8 05:38:10 PDT 2007


Jeff Garzik <jeff at garzik.org> writes:
> > +			val, reg_index, addr, addr+4); */
> > +	writel(cpu_to_le32(reg_index), addr);
> > +	writel(cpu_to_le32(val),(u8 *)addr + 4);
> 
> wrong -- endian conversion macros not needed with writel()

Are you sure? I don't think that's true. e.g. powerpc writel 
doesn't convert endian

-Andi




More information about the ewg mailing list