[ewg] Re: [PATCH] IB/ehca: fix bugs to support rhel 4.5 in OFED 1.2.c-11

[Michael S. Tsirkin]

> Quoting Stefan Roscher <ossrosch at linux.vnet.ibm.com>:
> Subject: [PATCH] IB/ehca: fix bugs to support rhel 4.5 in OFED 1.2.c-11
> 
> After OFED-1.2.c uses another kernelcode base

Another base as compared to what?

> we have to adapt the backport
> files for rhel-4.5.
> 

We do? What is the problem you are solving? Is the build broken?

> 
> Signed-off-by: Stefan Roscher <stefan.roscher at de.ibm.com>

By the way, it looks like you have the kernel headers for rhel 4.5 ppc.
Can you upoad these to openfabrics.org so we can use the for cross-build?

> ---
> 
> kernel_addons/backport/2.6.9_U5/include/linux/slab.h                |    2 -
>  kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch |   11 ++++++++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> 
> diff -Nurp ofa_kernel-1.2.c/kernel_addons/backport/2.6.9_U5/include/linux/slab.h ofa_kernel-1.2.c_new/kernel_addons/backport/2.6.9_U5/include/linux/slab.h
> --- ofa_kernel-1.2.c/kernel_addons/backport/2.6.9_U5/include/linux/slab.h	2007-08-07 16:11:51.000000000 +0200
> +++ ofa_kernel-1.2.c_new/kernel_addons/backport/2.6.9_U5/include/linux/slab.h	2007-08-10 14:35:39.000000000 +0200
> @@ -25,7 +25,7 @@ void *kmalloc_node(size_t size, gfp_t fl
>  #define SLAB_H_KMEMCACHE_ZALLOC_BACKPORT_TO_2_6_16
>  
>  static inline
> -void *kmem_cache_zalloc(struct kmem_cache *cache, gfp_t flags)
> +void *kmem_cache_zalloc(kmem_cache_t *cache, gfp_t flags)
>  {
>         void *ret = kmem_cache_alloc(cache, flags);
>         if (ret)

Why is this needed?

> diff -Nurp ofa_kernel-1.2.c/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch ofa_kernel-1.2.c_new/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch
> --- ofa_kernel-1.2.c/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch	1970-01-01 01:00:00.000000000 +0100
> +++ ofa_kernel-1.2.c_new/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch	2007-08-10 16:23:32.000000000 +0200
> @@ -0,0 +1,11 @@
> +diff -Nurp ofa_kernel-1.2.c/drivers/infiniband/hw/ehca/ehca_classes.h ofa_kernel-1.2.c_new/drivers/infiniband/hw/ehca/ehca_classes.h
> +--- ofa_kernel-1.2.c/drivers/infiniband/hw/ehca/ehca_classes.h	2007-08-07 16:11:49.000000000 +0200
> ++++ ofa_kernel-1.2.c_new/drivers/infiniband/hw/ehca/ehca_classes.h	2007-08-10 14:55:27.000000000 +0200
> +@@ -53,6 +53,7 @@ struct ehca_pd;
> + struct ehca_av;
> + 
> + #include <linux/wait.h>
> ++#include <linux/mutex.h>
> + 
> + #include <rdma/ib_verbs.h>
> + #include <rdma/ib_user_verbs.h>

What happens here? Looks like something we can handle by an addon rather than a
patch.

-- 
MST