[ewg] Re: [PATCH] IB/ehca: fix bugs to support rhel 4.5 in OFED 1.2.c-11

[Stefan Roscher]

On Tuesday 14 August 2007 15:54, Michael S. Tsirkin wrote:
> > diff -Nurp ofa_kernel-1.2.c/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch ofa_kernel-1.2.c_new/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch
> > --- ofa_kernel-1.2.c/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch	1970-01-01 01:00:00.000000000 +0100
> > +++ ofa_kernel-1.2.c_new/kernel_patches/backport/2.6.9_U5/backport_ehca_4_rhel45_mutex.patch	2007-08-10 16:23:32.000000000 +0200
> 
> What's this?
> 
> > @@ -0,0 +1,11 @@
> > +diff -Nurp ofa_kernel-1.2.c/drivers/infiniband/hw/ehca/ehca_classes.h ofa_kernel-1.2.c_new/drivers/infiniband/hw/ehca/ehca_classes.h
> > +--- ofa_kernel-1.2.c/drivers/infiniband/hw/ehca/ehca_classes.h	2007-08-07 16:11:49.000000000 +0200
> > ++++ ofa_kernel-1.2.c_new/drivers/infiniband/hw/ehca/ehca_classes.h	2007-08-10 14:55:27.000000000 +0200
> > +@@ -53,6 +53,7 @@ struct ehca_pd;
> > + struct ehca_av;
> > + 
> > + #include <linux/wait.h>
> > ++#include <linux/mutex.h>
> > + 
> > + #include <rdma/ib_verbs.h>
> > + #include <rdma/ib_user_verbs.h>
> 
> ehca_classes.h uses struct mutex to it really should include mutex.h
> rather than rely on it being pulled in indirectly.
> 
> So this bit should go into kernel_patches/fixes, and be queued for 2.6.24.

Hi Michael,

you are right, my thoughts where that this problem hit us only with rhel-4.5,
so we will fix it as fast as we can in kernel upstream, but in OFED-1.2.5 we
only backport it for rhel-4.5, because all other suported kernels are working fine.

regards Stefan