[ewg] Re: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC

[Roland Dreier]

 > Or you said I could submit patches to you.  One problem with
 > only using your tree is that I need to supply updates and backports
 > for OFED builds.  I've cloned Vlad's tree for that.

How you manage OFED is up to you.  However, once your driver is in the
upstream tree there is no alternative except to supply patches that
apply to my tree or the upstream tree, and you might as well get in
the habit now.  (And in fact, making a convincing case that you can
maintain a driver in the upstream kernel is part of getting your
driver merged)

 > How about this for the future: Let me know when you've made
 > changes and I'll pull and merge your changes into my code.
 > That way I can still provide everything for OFED and patches
 > I create should apply cleanly in your branch.  I assume
 > you could also pull from my tree as well, right?  If you have
 > a better way to satisfy all we can discuss it.

I can't pull from your current tree, because it has a bunch of OFED
crap in it.  If you want me to pull, then you need to provide a tree
that is based on the tree I'm pulling into and has no changes except
the ones you're trying to give to me.

Anyway.  I just threw away my old neteffect branch, and pushed out a
new branch with the nes driver from your OFED tree.  It seems as if
that tree already had all the patches you emailed out.  I also ran
scripts/cleanfile on the nes driver to fix the obvious whitespace
problems.  However there is still a lot of cosmetic work that needs to
get done -- for example, while I'm not a stickler about the 80-column
limit, having lines more than 150 characters long is clearly
excessive.

 - R.