[ewg] Re: [PATCH] IB/iser: fix wrong error message in open-iscsi installation

[Erez Zilber]

Sorry. My mistake (I thought that since all other entries in ofed.conf use y/n, this one does the same).

Erez

Vladimir Sokolovsky wrote:
> Hi Erez,
> The original message seems to be right:
> In unattended installation you check  if [ "X${upgrade_open_iscsi}" !=
> "Xyes" ]; then ...
> 
> So, the message should include "yes" and not "y".
> 
> Regards,
> Vladimir
> 
> 
>> -----Original Message-----
>> From: Erez Zilber [mailto:erezz at voltaire.com]
>> Sent: Tuesday, June 12, 2007 2:17 PM
>> To: Tziporet Koren; Vladimir Sokolovsky
>> Cc: ewg at lists.openfabrics.org
>> Subject: [PATCH] IB/iser: fix wrong error message in
>> open-iscsi installation
>>
>> Tziporet, Vlad,
>>
>>
>> This patch fixes an error message in an installation script
>> (build_env.sh). Please approve.
>>
>> diff --git a/build_env.sh b/build_env.sh index b757155..1781915 100644
>> --- a/build_env.sh
>> +++ b/build_env.sh
>> @@ -1336,7 +1336,7 @@ check_open_iscsi()
>>                  else
>>                          if [ "X${upgrade_open_iscsi}" !=
>> "Xyes" ]; then
>>                                  err_echo "Please uninstall
>> ${open_iscsi_rpm_name} before installing ${PACKAGE} with iSER
>> support."
>> -                                echo "  Or put
>> \"upgrade_open_iscsi=yes\" in the $CONFIG"
>> +                                echo "  Or put
>> \"upgrade_open_iscsi=y\" in $CONFIG"
>>                                  exit 1
>>                          fi
>>                  fi
>> --
>> ____________________________________________________________
>>
>> Erez Zilber   |  972-9-971-7689
>>
>> Software Engineer, Storage Team
>>
>> Voltaire - _The Grid Backbone_
>>
>>  __
>>
>>  www.voltaire.com <http://www.voltaire.com/>
>>
>> <mailto:erezz at voltaire.com>
>>
>> 
>>
>>
>>
>